[INFO] updating cached repository nlordell/aoc-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nlordell/aoc-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nlordell/aoc-rs" "work/ex/clippy-test-run/sources/stable/gh/nlordell/aoc-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nlordell/aoc-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nlordell/aoc-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nlordell/aoc-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nlordell/aoc-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf6170cd0c22089aec528177d7e03496cd380568 [INFO] sha for GitHub repo nlordell/aoc-rs: cf6170cd0c22089aec528177d7e03496cd380568 [INFO] validating manifest of nlordell/aoc-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nlordell/aoc-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nlordell/aoc-rs [INFO] finished frobbing nlordell/aoc-rs [INFO] frobbed toml for nlordell/aoc-rs written to work/ex/clippy-test-run/sources/stable/gh/nlordell/aoc-rs/Cargo.toml [INFO] started frobbing nlordell/aoc-rs [INFO] finished frobbing nlordell/aoc-rs [INFO] frobbed toml for nlordell/aoc-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nlordell/aoc-rs/Cargo.toml [INFO] crate nlordell/aoc-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nlordell/aoc-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nlordell/aoc-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aef5278fa492e3e3096fb80a73214f36c519694739dcd3bbb856960c4c13c9a0 [INFO] running `"docker" "start" "-a" "aef5278fa492e3e3096fb80a73214f36c519694739dcd3bbb856960c4c13c9a0"` [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking nalgebra v0.16.12 [INFO] [stderr] Checking aoc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/year2018/day03.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/year2018/day03.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | let result = { no_overlap.drain().nth(0).unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/year2018/day03.rs:88:5 [INFO] [stderr] | [INFO] [stderr] 88 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/year2018/day03.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | let result = { no_overlap.drain().nth(0).unwrap() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/year2018/day09.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | 146373 [INFO] [stderr] | ^^^^^^ help: consider: `146_373` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/year2018/day12.rs:165:19 [INFO] [stderr] | [INFO] [stderr] 165 | puzzle(input, 50000000000) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/year2018/day14.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | let scoreboard = puzzle(0x400000, |s| slice_end(&s, input.len()).contains(input)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/year2018/day12.rs:165:19 [INFO] [stderr] | [INFO] [stderr] 165 | puzzle(input, 50000000000) [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/year2018/day14.rs:55:29 [INFO] [stderr] | [INFO] [stderr] 55 | let scoreboard = puzzle(0x400000, |s| slice_end(&s, input.len()).contains(input)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day15.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn puzzle1(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day15.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn puzzle2(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day16.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn puzzle1(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day16.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn puzzle2(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day15.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn puzzle1(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day15.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn puzzle2(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day16.rs:1:16 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn puzzle1(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `input` [INFO] [stderr] --> src/year2018/day16.rs:5:16 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn puzzle2(input: &str) -> i64 { [INFO] [stderr] | ^^^^^ help: consider using `_input` instead [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .expect(&format!("failed to get input for {} day {}", year, day)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to get input for {} day {}", year))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:48 [INFO] [stderr] | [INFO] [stderr] 57 | let time = time.as_secs() as f64 + time.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/year2018/day04.rs:110:14 [INFO] [stderr] | [INFO] [stderr] 110 | max_id * (max_min as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(max_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/year2018/day04.rs:130:14 [INFO] [stderr] | [INFO] [stderr] 130 | max_id * (max_min as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(max_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:133:17 [INFO] [stderr] | [INFO] [stderr] 133 | assert!(input.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/year2018/day06.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | fn manhattan_dist(&self, other: Vec2) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/year2018/day06.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | fn span_out(&self, mut f: F) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .expect(&format!("failed to get input for {} day {}", year, day)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failed to get input for {} day {}", year))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/year2018/day06.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | fn sprawl_out(&self, mut f: F) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:48 [INFO] [stderr] | [INFO] [stderr] 57 | let time = time.as_secs() as f64 + time.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/year2018/day07.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | nodes.entry(n).or_insert(Node::new(n)).deps.insert(dep); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Node::new(n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/year2018/day07.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | nodes.entry(dep).or_insert(Node::new(dep)).ns.insert(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Node::new(dep))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/year2018/day07.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | if node.deps.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!node.deps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/year2018/day04.rs:110:14 [INFO] [stderr] | [INFO] [stderr] 110 | max_id * (max_min as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(max_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/year2018/day04.rs:130:14 [INFO] [stderr] | [INFO] [stderr] 130 | max_id * (max_min as i64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(max_min)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/year2018/day06.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | fn manhattan_dist(&self, other: Vec2) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/year2018/day06.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | fn span_out(&self, mut f: F) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/year2018/day06.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | fn sprawl_out(&self, mut f: F) [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/year2018/day11.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | / if !self.powers.contains_key(&(x, y, s)) { [INFO] [stderr] 64 | | self.powers.insert((x, y, s), self.power3(x, y)); [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.powers.entry((x, y, s)).or_insert(self.power3(x, y))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/year2018/day11.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if !self.powers.contains_key(&(x, y, s)) { [INFO] [stderr] 70 | | let mut p = self.power(x + 1, y + 1, s - 1); [INFO] [stderr] 71 | | for i in 0..s { [INFO] [stderr] 72 | | p += self.cells[xx + i][yy] + self.cells[xx][yy + i] [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | self.powers.insert((x, y, s), p); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.powers.entry((x, y, s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/year2018/day12.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/year2018/day07.rs:56:28 [INFO] [stderr] | [INFO] [stderr] 56 | nodes.entry(n).or_insert(Node::new(n)).deps.insert(dep); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Node::new(n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/year2018/day07.rs:57:30 [INFO] [stderr] | [INFO] [stderr] 57 | nodes.entry(dep).or_insert(Node::new(dep)).ns.insert(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| Node::new(dep))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/year2018/day07.rs:72:12 [INFO] [stderr] | [INFO] [stderr] 72 | if node.deps.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!node.deps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `tracks` [INFO] [stderr] --> src/year2018/day13.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for y in 0..tracks.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for (y, ) in tracks.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/year2018/day13.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | if collisions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!collisions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/year2018/day11.rs:63:17 [INFO] [stderr] | [INFO] [stderr] 63 | / if !self.powers.contains_key(&(x, y, s)) { [INFO] [stderr] 64 | | self.powers.insert((x, y, s), self.power3(x, y)); [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.powers.entry((x, y, s)).or_insert(self.power3(x, y))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/year2018/day11.rs:69:17 [INFO] [stderr] | [INFO] [stderr] 69 | / if !self.powers.contains_key(&(x, y, s)) { [INFO] [stderr] 70 | | let mut p = self.power(x + 1, y + 1, s - 1); [INFO] [stderr] 71 | | for i in 0..s { [INFO] [stderr] 72 | | p += self.cells[xx + i][yy] + self.cells[xx][yy + i] [INFO] [stderr] 73 | | } [INFO] [stderr] 74 | | self.powers.insert((x, y, s), p); [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________^ help: consider using: `self.powers.entry((x, y, s))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/year2018/day12.rs:114:32 [INFO] [stderr] | [INFO] [stderr] 114 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: the loop variable `y` is used to index `tracks` [INFO] [stderr] --> src/year2018/day13.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for y in 0..tracks.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 47 | for (y, ) in tracks.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/year2018/day13.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | if collisions.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!collisions.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.37s [INFO] running `"docker" "inspect" "aef5278fa492e3e3096fb80a73214f36c519694739dcd3bbb856960c4c13c9a0"` [INFO] running `"docker" "rm" "-f" "aef5278fa492e3e3096fb80a73214f36c519694739dcd3bbb856960c4c13c9a0"` [INFO] [stdout] aef5278fa492e3e3096fb80a73214f36c519694739dcd3bbb856960c4c13c9a0