[INFO] updating cached repository nishtahir/identicon-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nishtahir/identicon-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nishtahir/identicon-generator" "work/ex/clippy-test-run/sources/stable/gh/nishtahir/identicon-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nishtahir/identicon-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nishtahir/identicon-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nishtahir/identicon-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nishtahir/identicon-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 959caf8831fbc2e2fb2dd79acd6fb735d79ec241 [INFO] sha for GitHub repo nishtahir/identicon-generator: 959caf8831fbc2e2fb2dd79acd6fb735d79ec241 [INFO] validating manifest of nishtahir/identicon-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nishtahir/identicon-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nishtahir/identicon-generator [INFO] finished frobbing nishtahir/identicon-generator [INFO] frobbed toml for nishtahir/identicon-generator written to work/ex/clippy-test-run/sources/stable/gh/nishtahir/identicon-generator/Cargo.toml [INFO] started frobbing nishtahir/identicon-generator [INFO] finished frobbing nishtahir/identicon-generator [INFO] frobbed toml for nishtahir/identicon-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nishtahir/identicon-generator/Cargo.toml [INFO] crate nishtahir/identicon-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nishtahir/identicon-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nishtahir/identicon-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 94b59461a43f778edb10b455540897b7dc554932d5e0a969d97303f3d95ce8be [INFO] running `"docker" "start" "-a" "94b59461a43f778edb10b455540897b7dc554932d5e0a969d97303f3d95ce8be"` [INFO] [stderr] Checking futures v0.1.15 [INFO] [stderr] Compiling gcc v0.3.53 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking image-generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is used to index `tiles` [INFO] [stderr] --> src/main.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for (i, ) in tiles.iter_mut().enumerate().take(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for j in 0..5 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `tiles[4 - i][..5].clone_from_slice(&tiles[i][..5])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | let ref mut fout = File::create(format!("{}.png", value)).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------------- help: try: `let fout = &mut File::create(format!("{}.png", value)).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `tiles` [INFO] [stderr] --> src/main.rs:37:14 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for (i, ) in tiles.iter_mut().enumerate().take(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:46:18 [INFO] [stderr] | [INFO] [stderr] 46 | for j in 0..5 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `tiles[4 - i][..5].clone_from_slice(&tiles[i][..5])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | let ref mut fout = File::create(format!("{}.png", value)).unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^--------------------------------------------------- help: try: `let fout = &mut File::create(format!("{}.png", value)).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.37s [INFO] running `"docker" "inspect" "94b59461a43f778edb10b455540897b7dc554932d5e0a969d97303f3d95ce8be"` [INFO] running `"docker" "rm" "-f" "94b59461a43f778edb10b455540897b7dc554932d5e0a969d97303f3d95ce8be"` [INFO] [stdout] 94b59461a43f778edb10b455540897b7dc554932d5e0a969d97303f3d95ce8be