[INFO] updating cached repository nilq/helix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nilq/helix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nilq/helix" "work/ex/clippy-test-run/sources/stable/gh/nilq/helix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nilq/helix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nilq/helix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nilq/helix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nilq/helix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28e40d3292f5d8292e115f56ef0fe86f5a3d2d77 [INFO] sha for GitHub repo nilq/helix: 28e40d3292f5d8292e115f56ef0fe86f5a3d2d77 [INFO] validating manifest of nilq/helix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nilq/helix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nilq/helix [INFO] finished frobbing nilq/helix [INFO] frobbed toml for nilq/helix written to work/ex/clippy-test-run/sources/stable/gh/nilq/helix/Cargo.toml [INFO] started frobbing nilq/helix [INFO] finished frobbing nilq/helix [INFO] frobbed toml for nilq/helix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nilq/helix/Cargo.toml [INFO] crate nilq/helix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nilq/helix against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nilq/helix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b324f6cfab50a5f4db6736fa354294415735cd5bd6404e7b6f6c37ee2f4270d4 [INFO] running `"docker" "start" "-a" "b324f6cfab50a5f4db6736fa354294415735cd5bd6404e7b6f6c37ee2f4270d4"` [INFO] [stderr] Checking docopt v0.7.0 [INFO] [stderr] Checking helix-lang v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Chunk { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Branch { content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/tokenizer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Parser { tokenizer: tokenizer } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tokenizer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Chunk { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Branch { content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/tokenizer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Parser { tokenizer: tokenizer } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tokenizer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/translater/mod.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 385 | | CElement::Include(ref n) => format!("#include {}\n", n), [INFO] [stderr] 386 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 155 | match *ce { [INFO] [stderr] 156 | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] 159 | CElement::Ident(ref i) => i.to_string(), [INFO] [stderr] 160 | CElement::Text(ref i) => format!("\"{}\"", i.to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/translater/mod.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 385 | | CElement::Include(ref n) => format!("#include {}\n", n), [INFO] [stderr] 386 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 155 | match *ce { [INFO] [stderr] 156 | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] 159 | CElement::Ident(ref i) => i.to_string(), [INFO] [stderr] 160 | CElement::Text(ref i) => format!("\"{}\"", i.to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser/block_tree.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/block_tree.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let parts: Vec<&str> = line.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/block_tree.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | let ln = parts.get(0).unwrap().trim(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&parts[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block_tree.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if ln.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ln.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/block_tree.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn make_tree(&mut self, indents: &Vec<(usize, &'a str)>) -> Branch<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, &'a str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::tokenizer::Tokenizer` [INFO] [stderr] --> src/parser/tokenizer.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Tokenizer { [INFO] [stderr] 16 | | Tokenizer { [INFO] [stderr] 17 | | tokens: Vec::new(), [INFO] [stderr] 18 | | lines: 0, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser/tokenizer.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | fn is_operator(&mut self, line: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/tokenizer.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match operator(&line[self.start..self.pos + offset]) { [INFO] [stderr] 87 | | Some(_) => is_op = true, [INFO] [stderr] 88 | | None => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = operator(&line[self.start..self.pos + offset]) { is_op = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/tokenizer.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match self.current().get_type() == token { [INFO] [stderr] 137 | | true => Ok(self.current()), [INFO] [stderr] 138 | | false => Err(format!("expected {:?} but found {:#?}", token, self.current())), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.current().get_type() == token { Ok(self.current()) } else { Err(format!("expected {:?} but found {:#?}", token, self.current())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | Function(String, Vec<(String, String)>, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser::ast::Parser` [INFO] [stderr] --> src/parser/ast.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Parser { [INFO] [stderr] 66 | | Parser { tokenizer: Tokenizer::new() } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | impl Default for parser::ast::Parser { [INFO] [stderr] 65 | fn default() -> Self { [INFO] [stderr] 66 | Self::new() [INFO] [stderr] 67 | } [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser/block_tree.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/block_tree.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let parts: Vec<&str> = line.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/block_tree.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | let ln = parts.get(0).unwrap().trim(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&parts[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block_tree.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if ln.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ln.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/ast.rs:427:29 [INFO] [stderr] | [INFO] [stderr] 427 | / match self.tokenizer.current().get_type() { [INFO] [stderr] 428 | | TokenType::Block(_) => { [INFO] [stderr] 429 | | let body = try!(self.block()); [INFO] [stderr] 430 | | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 431 | | } [INFO] [stderr] 432 | | _ => (), [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 427 | if let TokenType::Block(_) = self.tokenizer.current().get_type() { [INFO] [stderr] 428 | let body = try!(self.block()); [INFO] [stderr] 429 | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 430 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/block_tree.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn make_tree(&mut self, indents: &Vec<(usize, &'a str)>) -> Branch<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, &'a str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::tokenizer::Tokenizer` [INFO] [stderr] --> src/parser/tokenizer.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Tokenizer { [INFO] [stderr] 16 | | Tokenizer { [INFO] [stderr] 17 | | tokens: Vec::new(), [INFO] [stderr] 18 | | lines: 0, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser/tokenizer.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | fn is_operator(&mut self, line: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/tokenizer.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match operator(&line[self.start..self.pos + offset]) { [INFO] [stderr] 87 | | Some(_) => is_op = true, [INFO] [stderr] 88 | | None => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = operator(&line[self.start..self.pos + offset]) { is_op = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/tokenizer.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match self.current().get_type() == token { [INFO] [stderr] 137 | | true => Ok(self.current()), [INFO] [stderr] 138 | | false => Err(format!("expected {:?} but found {:#?}", token, self.current())), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.current().get_type() == token { Ok(self.current()) } else { Err(format!("expected {:?} but found {:#?}", token, self.current())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | Function(String, Vec<(String, String)>, Box>, Option), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | Function(String, Vec<(String, String)>, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser::ast::Parser` [INFO] [stderr] --> src/parser/ast.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Parser { [INFO] [stderr] 66 | | Parser { tokenizer: Tokenizer::new() } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | impl Default for parser::ast::Parser { [INFO] [stderr] 65 | fn default() -> Self { [INFO] [stderr] 66 | Self::new() [INFO] [stderr] 67 | } [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/parser/translater/mod.rs:154:1 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn translate_element(ce: &CElement) -> String { [INFO] [stderr] 155 | | return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/translater/mod.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | / match e { [INFO] [stderr] 211 | | &CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] 212 | | &translate_element( [INFO] [stderr] 213 | | &CElement::Function(format!("{}::{}", n, n1), a.clone(), c.clone(), t.clone()), [INFO] [stderr] ... | [INFO] [stderr] 216 | | _ => panic!("Unexpected impementation of: {:?}", e), [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 210 | match *e { [INFO] [stderr] 211 | CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/translater/mod.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | / format!( [INFO] [stderr] 237 | | "{}", [INFO] [stderr] 238 | | block, [INFO] [stderr] 239 | | ) [INFO] [stderr] | |_____________________^ help: consider using .to_string(): `block.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:288:40 [INFO] [stderr] | [INFO] [stderr] 288 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/ast.rs:427:29 [INFO] [stderr] | [INFO] [stderr] 427 | / match self.tokenizer.current().get_type() { [INFO] [stderr] 428 | | TokenType::Block(_) => { [INFO] [stderr] 429 | | let body = try!(self.block()); [INFO] [stderr] 430 | | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 431 | | } [INFO] [stderr] 432 | | _ => (), [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 427 | if let TokenType::Block(_) = self.tokenizer.current().get_type() { [INFO] [stderr] 428 | let body = try!(self.block()); [INFO] [stderr] 429 | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 430 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:391:73 [INFO] [stderr] | [INFO] [stderr] 391 | Expression::Integer(ref i) => CElement::Integer(i.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:392:71 [INFO] [stderr] | [INFO] [stderr] 392 | Expression::Float(ref f) => CElement::Float(f.clone()), [INFO] [stderr] [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:394:73 [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] | [INFO] [stderr] 394 | Expression::Boolean(ref f) => CElement::Boolean(f.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | Function(String, Vec<(String, String)>, Box>, Option), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parser/translater/mod.rs:533:32 [INFO] [stderr] | [INFO] [stderr] 533 | if let None = retty { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 534 | | let expr = get_return(&c); [INFO] [stderr] 535 | | if let Some(e) = expr { [INFO] [stderr] 536 | | retty = Some(type_of(&e).to_string()) [INFO] [stderr] 537 | | } [INFO] [stderr] 538 | | } [INFO] [stderr] | |_________________________- help: try this: `if retty.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser/translater/mod.rs:546:28 [INFO] [stderr] | [INFO] [stderr] 546 | if &&t == &&n { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 546 | if &t == &n { [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/parser/translater/mod.rs:154:1 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn translate_element(ce: &CElement) -> String { [INFO] [stderr] 155 | | return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/translater/mod.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | / match e { [INFO] [stderr] 211 | | &CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] 212 | | &translate_element( [INFO] [stderr] 213 | | &CElement::Function(format!("{}::{}", n, n1), a.clone(), c.clone(), t.clone()), [INFO] [stderr] ... | [INFO] [stderr] 216 | | _ => panic!("Unexpected impementation of: {:?}", e), [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 210 | match *e { [INFO] [stderr] 211 | CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/translater/mod.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | / format!( [INFO] [stderr] 237 | | "{}", [INFO] [stderr] 238 | | block, [INFO] [stderr] 239 | | ) [INFO] [stderr] | |_____________________^ help: consider using .to_string(): `block.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:288:40 [INFO] [stderr] | [INFO] [stderr] 288 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:391:73 [INFO] [stderr] | [INFO] [stderr] 391 | Expression::Integer(ref i) => CElement::Integer(i.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:392:71 [INFO] [stderr] | [INFO] [stderr] 392 | Expression::Float(ref f) => CElement::Float(f.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:394:73 [INFO] [stderr] | [INFO] [stderr] 394 | Expression::Boolean(ref f) => CElement::Boolean(f.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parser/translater/mod.rs:533:32 [INFO] [stderr] | [INFO] [stderr] 533 | if let None = retty { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 534 | | let expr = get_return(&c); [INFO] [stderr] 535 | | if let Some(e) = expr { [INFO] [stderr] 536 | | retty = Some(type_of(&e).to_string()) [INFO] [stderr] 537 | | } [INFO] [stderr] 538 | | } [INFO] [stderr] | |_________________________- help: try this: `if retty.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser/translater/mod.rs:546:28 [INFO] [stderr] | [INFO] [stderr] 546 | if &&t == &&n { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 546 | if &t == &n { [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | token_type: token_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `token_type` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Chunk { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Branch { content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | row: row, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/token.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/tokenizer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | Chunk { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:34:18 [INFO] [stderr] | [INFO] [stderr] 34 | Branch { content: content } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Parser { tokenizer: tokenizer } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tokenizer` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/block_tree.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/tokenizer.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/ast.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | Parser { tokenizer: tokenizer } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tokenizer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/translater/mod.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 385 | | CElement::Include(ref n) => format!("#include {}\n", n), [INFO] [stderr] 386 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/translater/mod.rs:155:5 [INFO] [stderr] | [INFO] [stderr] 155 | / return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 385 | | CElement::Include(ref n) => format!("#include {}\n", n), [INFO] [stderr] 386 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 155 | match *ce { [INFO] [stderr] 156 | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] 159 | CElement::Ident(ref i) => i.to_string(), [INFO] [stderr] 160 | CElement::Text(ref i) => format!("\"{}\"", i.to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 155 | match *ce { [INFO] [stderr] 156 | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] 158 | CElement::Boolean(ref i) => i.to_string(), [INFO] [stderr] 159 | CElement::Ident(ref i) => i.to_string(), [INFO] [stderr] 160 | CElement::Text(ref i) => format!("\"{}\"", i.to_string()), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | const USAGE: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser/block_tree.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/block_tree.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let parts: Vec<&str> = line.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/block_tree.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | let ln = parts.get(0).unwrap().trim(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&parts[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block_tree.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if ln.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ln.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/block_tree.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn make_tree(&mut self, indents: &Vec<(usize, &'a str)>) -> Branch<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, &'a str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/parser/block_tree.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/block_tree.rs:62:47 [INFO] [stderr] | [INFO] [stderr] 62 | let parts: Vec<&str> = line.split("#").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser/block_tree.rs:63:22 [INFO] [stderr] | [INFO] [stderr] 63 | let ln = parts.get(0).unwrap().trim(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&parts[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/block_tree.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if ln.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ln.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser/block_tree.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | pub fn make_tree(&mut self, indents: &Vec<(usize, &'a str)>) -> Branch<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, &'a str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::tokenizer::Tokenizer` [INFO] [stderr] --> src/parser/tokenizer.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Tokenizer { [INFO] [stderr] 16 | | Tokenizer { [INFO] [stderr] 17 | | tokens: Vec::new(), [INFO] [stderr] 18 | | lines: 0, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::tokenizer::Tokenizer` [INFO] [stderr] --> src/parser/tokenizer.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Tokenizer { [INFO] [stderr] 16 | | Tokenizer { [INFO] [stderr] 17 | | tokens: Vec::new(), [INFO] [stderr] 18 | | lines: 0, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser/tokenizer.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | fn is_operator(&mut self, line: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/tokenizer.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match operator(&line[self.start..self.pos + offset]) { [INFO] [stderr] 87 | | Some(_) => is_op = true, [INFO] [stderr] 88 | | None => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = operator(&line[self.start..self.pos + offset]) { is_op = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser/tokenizer.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | fn is_operator(&mut self, line: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/tokenizer.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match self.current().get_type() == token { [INFO] [stderr] 137 | | true => Ok(self.current()), [INFO] [stderr] 138 | | false => Err(format!("expected {:?} but found {:#?}", token, self.current())), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.current().get_type() == token { Ok(self.current()) } else { Err(format!("expected {:?} but found {:#?}", token, self.current())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/tokenizer.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | / match operator(&line[self.start..self.pos + offset]) { [INFO] [stderr] 87 | | Some(_) => is_op = true, [INFO] [stderr] 88 | | None => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(_) = operator(&line[self.start..self.pos + offset]) { is_op = true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/parser/tokenizer.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / match self.current().get_type() == token { [INFO] [stderr] 137 | | true => Ok(self.current()), [INFO] [stderr] 138 | | false => Err(format!("expected {:?} but found {:#?}", token, self.current())), [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.current().get_type() == token { Ok(self.current()) } else { Err(format!("expected {:?} but found {:#?}", token, self.current())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | Function(String, Vec<(String, String)>, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::box_vec)] on by default [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | Function(String, Vec<(String, String)>, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/ast.rs:50:11 [INFO] [stderr] | [INFO] [stderr] 50 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser::ast::Parser` [INFO] [stderr] --> src/parser/ast.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Parser { [INFO] [stderr] 66 | | Parser { tokenizer: Tokenizer::new() } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | impl Default for parser::ast::Parser { [INFO] [stderr] 65 | fn default() -> Self { [INFO] [stderr] 66 | Self::new() [INFO] [stderr] 67 | } [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `parser::ast::Parser` [INFO] [stderr] --> src/parser/ast.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn new() -> Parser { [INFO] [stderr] 66 | | Parser { tokenizer: Tokenizer::new() } [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | impl Default for parser::ast::Parser { [INFO] [stderr] 65 | fn default() -> Self { [INFO] [stderr] 66 | Self::new() [INFO] [stderr] 67 | } [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/ast.rs:427:29 [INFO] [stderr] | [INFO] [stderr] 427 | / match self.tokenizer.current().get_type() { [INFO] [stderr] 428 | | TokenType::Block(_) => { [INFO] [stderr] 429 | | let body = try!(self.block()); [INFO] [stderr] 430 | | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 431 | | } [INFO] [stderr] 432 | | _ => (), [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 427 | if let TokenType::Block(_) = self.tokenizer.current().get_type() { [INFO] [stderr] 428 | let body = try!(self.block()); [INFO] [stderr] 429 | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 430 | } [INFO] [stderr] | [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] [INFO] [stderr] --> src/parser/ast.rs:427:29 [INFO] [stderr] | [INFO] [stderr] 427 | / match self.tokenizer.current().get_type() { [INFO] [stderr] 428 | | TokenType::Block(_) => { [INFO] [stderr] 429 | | let body = try!(self.block()); [INFO] [stderr] 430 | | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 431 | | } [INFO] [stderr] 432 | | _ => (), [INFO] [stderr] 433 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 427 | if let TokenType::Block(_) = self.tokenizer.current().get_type() { [INFO] [stderr] 428 | let body = try!(self.block()); [INFO] [stderr] 429 | return Ok(Expression::Function(name, args, Box::new(body), Some(Box::new(retty)))) [INFO] [stderr] 430 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | Function(String, Vec<(String, String)>, Box>, Option), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:19:11 [INFO] [stderr] | [INFO] [stderr] 19 | Block(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:21:25 [INFO] [stderr] | [INFO] [stderr] 21 | Call(Box, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | Class(String, Box>, Option>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:24:23 [INFO] [stderr] | [INFO] [stderr] 24 | Implement(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:32:20 [INFO] [stderr] | [INFO] [stderr] 32 | Module(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:33:20 [INFO] [stderr] | [INFO] [stderr] 33 | Struct(String, Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `Box>`. Consider using just `Vec` [INFO] [stderr] --> src/parser/translater/mod.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | Function(String, Vec<(String, String)>, Box>, Option), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: `Vec` is already on the heap, `Box>` makes an extra allocation. [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_vec [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/parser/translater/mod.rs:154:1 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn translate_element(ce: &CElement) -> String { [INFO] [stderr] 155 | | return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 40 [INFO] [stderr] --> src/parser/translater/mod.rs:154:1 [INFO] [stderr] | [INFO] [stderr] 154 | / pub fn translate_element(ce: &CElement) -> String { [INFO] [stderr] 155 | | return match *ce { [INFO] [stderr] 156 | | CElement::Integer(ref i) => i.to_string(), [INFO] [stderr] 157 | | CElement::Float(ref i) => i.to_string(), [INFO] [stderr] ... | [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/translater/mod.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | / match e { [INFO] [stderr] 211 | | &CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] 212 | | &translate_element( [INFO] [stderr] 213 | | &CElement::Function(format!("{}::{}", n, n1), a.clone(), c.clone(), t.clone()), [INFO] [stderr] ... | [INFO] [stderr] 216 | | _ => panic!("Unexpected impementation of: {:?}", e), [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 210 | match *e { [INFO] [stderr] 211 | CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/translater/mod.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | / format!( [INFO] [stderr] 237 | | "{}", [INFO] [stderr] 238 | | block, [INFO] [stderr] 239 | | ) [INFO] [stderr] | |_____________________^ help: consider using .to_string(): `block.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:288:40 [INFO] [stderr] | [INFO] [stderr] 288 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:169:36 [INFO] [stderr] | [INFO] [stderr] 169 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser/translater/mod.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | / match e { [INFO] [stderr] 211 | | &CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] 212 | | &translate_element( [INFO] [stderr] 213 | | &CElement::Function(format!("{}::{}", n, n1), a.clone(), c.clone(), t.clone()), [INFO] [stderr] ... | [INFO] [stderr] 216 | | _ => panic!("Unexpected impementation of: {:?}", e), [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 210 | match *e { [INFO] [stderr] 211 | CElement::Function(ref n1, ref a, ref c, ref t) => implementation.push_str( [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/parser/translater/mod.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | / format!( [INFO] [stderr] 237 | | "{}", [INFO] [stderr] 238 | | block, [INFO] [stderr] 239 | | ) [INFO] [stderr] | |_____________________^ help: consider using .to_string(): `block.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:391:73 [INFO] [stderr] | [INFO] [stderr] 391 | Expression::Integer(ref i) => CElement::Integer(i.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the variable `accum` is used as a loop counter. Consider using `for (accum, item) in a.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/parser/translater/mod.rs:288:40 [INFO] [stderr] | [INFO] [stderr] 288 | for &(ref t, ref n) in a.iter() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:392:71 [INFO] [stderr] | [INFO] [stderr] 392 | Expression::Float(ref f) => CElement::Float(f.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:394:73 [INFO] [stderr] | [INFO] [stderr] 394 | Expression::Boolean(ref f) => CElement::Boolean(f.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parser/translater/mod.rs:533:32 [INFO] [stderr] | [INFO] [stderr] 533 | if let None = retty { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 534 | | let expr = get_return(&c); [INFO] [stderr] 535 | | if let Some(e) = expr { [INFO] [stderr] 536 | | retty = Some(type_of(&e).to_string()) [INFO] [stderr] 537 | | } [INFO] [stderr] 538 | | } [INFO] [stderr] | |_________________________- help: try this: `if retty.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser/translater/mod.rs:546:28 [INFO] [stderr] | [INFO] [stderr] 546 | if &&t == &&n { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 546 | if &t == &n { [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | if input_line.trim() == String::from(":quit") || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `":quit"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | input_line.trim() == String::from(":q") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `":q"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | fn file<'a>(source: &str) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | Err(_) => panic!("failed to open path: {}", source), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:391:73 [INFO] [stderr] | [INFO] [stderr] 391 | Expression::Integer(ref i) => CElement::Integer(i.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:392:71 [INFO] [stderr] | [INFO] [stderr] 392 | Expression::Float(ref f) => CElement::Float(f.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/parser/translater/mod.rs:394:73 [INFO] [stderr] | [INFO] [stderr] 394 | Expression::Boolean(ref f) => CElement::Boolean(f.clone()), [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/parser/translater/mod.rs:533:32 [INFO] [stderr] | [INFO] [stderr] 533 | if let None = retty { [INFO] [stderr] | _________________________- ^^^^ [INFO] [stderr] 534 | | let expr = get_return(&c); [INFO] [stderr] 535 | | if let Some(e) = expr { [INFO] [stderr] 536 | | retty = Some(type_of(&e).to_string()) [INFO] [stderr] 537 | | } [INFO] [stderr] 538 | | } [INFO] [stderr] | |_________________________- help: try this: `if retty.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/parser/translater/mod.rs:546:28 [INFO] [stderr] | [INFO] [stderr] 546 | if &&t == &&n { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 546 | if &t == &n { [INFO] [stderr] | ^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | if input_line.trim() == String::from(":quit") || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `":quit"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | input_line.trim() == String::from(":q") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `":q"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | fn file<'a>(source: &str) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | Err(_) => panic!("failed to open path: {}", source), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.28s [INFO] running `"docker" "inspect" "b324f6cfab50a5f4db6736fa354294415735cd5bd6404e7b6f6c37ee2f4270d4"` [INFO] running `"docker" "rm" "-f" "b324f6cfab50a5f4db6736fa354294415735cd5bd6404e7b6f6c37ee2f4270d4"` [INFO] [stdout] b324f6cfab50a5f4db6736fa354294415735cd5bd6404e7b6f6c37ee2f4270d4