[INFO] updating cached repository nikita-b/f-console [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nikita-b/f-console [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nikita-b/f-console" "work/ex/clippy-test-run/sources/stable/gh/nikita-b/f-console"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nikita-b/f-console'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nikita-b/f-console" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nikita-b/f-console"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nikita-b/f-console'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ffe1b04a7d66fdadc3bcfcf839d1656362ca2ed2 [INFO] sha for GitHub repo nikita-b/f-console: ffe1b04a7d66fdadc3bcfcf839d1656362ca2ed2 [INFO] validating manifest of nikita-b/f-console on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nikita-b/f-console on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nikita-b/f-console [INFO] finished frobbing nikita-b/f-console [INFO] frobbed toml for nikita-b/f-console written to work/ex/clippy-test-run/sources/stable/gh/nikita-b/f-console/Cargo.toml [INFO] started frobbing nikita-b/f-console [INFO] finished frobbing nikita-b/f-console [INFO] frobbed toml for nikita-b/f-console written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nikita-b/f-console/Cargo.toml [INFO] crate nikita-b/f-console has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nikita-b/f-console against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nikita-b/f-console:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f588a92b1d7eec77e92615119f945c58dd84100371300162b0eb700626610eb0 [INFO] running `"docker" "start" "-a" "f588a92b1d7eec77e92615119f945c58dd84100371300162b0eb700626610eb0"` [INFO] [stderr] Checking mio v0.6.1 [INFO] [stderr] Checking f-console v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/main.rs:2:22 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Write, Read, BufReader, BufRead}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Read` [INFO] [stderr] --> src/main.rs:2:22 [INFO] [stderr] | [INFO] [stderr] 2 | use std::io::{Write, Read, BufReader, BufRead}; [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `PASSWORD` should have a snake case name such as `password` [INFO] [stderr] --> src/main.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let PASSWORD = String::from("12345"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | stream.write(b"Welcome to F-Console, Stranger!\nEnter password:").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match check_password(buffer) { [INFO] [stderr] 21 | | false => { [INFO] [stderr] 22 | | println!("Password correct!"); [INFO] [stderr] 23 | | } [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 20 | if check_password(buffer) { [INFO] [stderr] 21 | println!("Nope"); [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | println!("Password correct!"); [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `f-console`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable `PASSWORD` should have a snake case name such as `password` [INFO] [stderr] --> src/main.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let PASSWORD = String::from("12345"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | stream.write(b"Welcome to F-Console, Stranger!\nEnter password:").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match check_password(buffer) { [INFO] [stderr] 21 | | false => { [INFO] [stderr] 22 | | println!("Password correct!"); [INFO] [stderr] 23 | | } [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 20 | if check_password(buffer) { [INFO] [stderr] 21 | println!("Nope"); [INFO] [stderr] 22 | } else { [INFO] [stderr] 23 | println!("Password correct!"); [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `f-console`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f588a92b1d7eec77e92615119f945c58dd84100371300162b0eb700626610eb0"` [INFO] running `"docker" "rm" "-f" "f588a92b1d7eec77e92615119f945c58dd84100371300162b0eb700626610eb0"` [INFO] [stdout] f588a92b1d7eec77e92615119f945c58dd84100371300162b0eb700626610eb0