[INFO] updating cached repository nifey/tictactoe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nifey/tictactoe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nifey/tictactoe" "work/ex/clippy-test-run/sources/stable/gh/nifey/tictactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nifey/tictactoe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nifey/tictactoe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nifey/tictactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nifey/tictactoe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 367c28c2344aab153867359ba89aca01151ce5f4 [INFO] sha for GitHub repo nifey/tictactoe: 367c28c2344aab153867359ba89aca01151ce5f4 [INFO] validating manifest of nifey/tictactoe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nifey/tictactoe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nifey/tictactoe [INFO] finished frobbing nifey/tictactoe [INFO] frobbed toml for nifey/tictactoe written to work/ex/clippy-test-run/sources/stable/gh/nifey/tictactoe/Cargo.toml [INFO] started frobbing nifey/tictactoe [INFO] finished frobbing nifey/tictactoe [INFO] frobbed toml for nifey/tictactoe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nifey/tictactoe/Cargo.toml [INFO] crate nifey/tictactoe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nifey/tictactoe against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nifey/tictactoe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 498e905f58493c3f15f9ee9e77f845d8fe968c7193bcc07da074758ae9c55364 [INFO] running `"docker" "start" "-a" "498e905f58493c3f15f9ee9e77f845d8fe968c7193bcc07da074758ae9c55364"` [INFO] [stderr] Checking termion v1.1.3 [INFO] [stderr] Checking tictactoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return PlayerSymbol::N; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PlayerSymbol::N` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 70 | | if c == PlayerSymbol::X { [INFO] [stderr] 71 | | return true; [INFO] [stderr] 72 | | } else if c == PlayerSymbol::O { [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | } else if c == PlayerSymbol::X { [INFO] [stderr] 70 | return true; [INFO] [stderr] 71 | } else if c == PlayerSymbol::O { [INFO] [stderr] 72 | return false; [INFO] [stderr] 73 | } else { [INFO] [stderr] 74 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 97 | | if b == PlayerSymbol::X { [INFO] [stderr] 98 | | if c == PlayerSymbol::X { [INFO] [stderr] 99 | | return true; [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | } else if b == PlayerSymbol::X { [INFO] [stderr] 97 | if c == PlayerSymbol::X { [INFO] [stderr] 98 | return true; [INFO] [stderr] 99 | } else if c == PlayerSymbol::O { [INFO] [stderr] 100 | return false; [INFO] [stderr] 101 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 88 | | if c == PlayerSymbol::X { [INFO] [stderr] 89 | | return false; [INFO] [stderr] 90 | | } else if c == PlayerSymbol::O { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if c == PlayerSymbol::X { [INFO] [stderr] 88 | return false; [INFO] [stderr] 89 | } else if c == PlayerSymbol::O { [INFO] [stderr] 90 | return true; [INFO] [stderr] 91 | } else { [INFO] [stderr] 92 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | newgame [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:187:23 [INFO] [stderr] | [INFO] [stderr] 187 | let newgame = Game { [INFO] [stderr] | _______________________^ [INFO] [stderr] 188 | | board: newboard, [INFO] [stderr] 189 | | xwin: 0, [INFO] [stderr] 190 | | owin: 0, [INFO] [stderr] 191 | | currentsymbol: PlayerSymbol::X, [INFO] [stderr] 192 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 232 | | if self.board.check_draw() == true { [INFO] [stderr] 233 | | println!("It's a draw "); [INFO] [stderr] 234 | | return true; [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 231 | } else if self.board.check_draw() == true { [INFO] [stderr] 232 | println!("It's a draw "); [INFO] [stderr] 233 | return true; [INFO] [stderr] 234 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return PlayerSymbol::N; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PlayerSymbol::N` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:63:25 [INFO] [stderr] | [INFO] [stderr] 63 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:75:25 [INFO] [stderr] | [INFO] [stderr] 75 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:83:25 [INFO] [stderr] | [INFO] [stderr] 83 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:25 [INFO] [stderr] | [INFO] [stderr] 91 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:101:25 [INFO] [stderr] | [INFO] [stderr] 101 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:103:25 [INFO] [stderr] | [INFO] [stderr] 103 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:109:25 [INFO] [stderr] | [INFO] [stderr] 109 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:111:25 [INFO] [stderr] | [INFO] [stderr] 111 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:69:24 [INFO] [stderr] | [INFO] [stderr] 69 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 70 | | if c == PlayerSymbol::X { [INFO] [stderr] 71 | | return true; [INFO] [stderr] 72 | | } else if c == PlayerSymbol::O { [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | } else if c == PlayerSymbol::X { [INFO] [stderr] 70 | return true; [INFO] [stderr] 71 | } else if c == PlayerSymbol::O { [INFO] [stderr] 72 | return false; [INFO] [stderr] 73 | } else { [INFO] [stderr] 74 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:96:20 [INFO] [stderr] | [INFO] [stderr] 96 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 97 | | if b == PlayerSymbol::X { [INFO] [stderr] 98 | | if c == PlayerSymbol::X { [INFO] [stderr] 99 | | return true; [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 96 | } else if b == PlayerSymbol::X { [INFO] [stderr] 97 | if c == PlayerSymbol::X { [INFO] [stderr] 98 | return true; [INFO] [stderr] 99 | } else if c == PlayerSymbol::O { [INFO] [stderr] 100 | return false; [INFO] [stderr] 101 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:87:24 [INFO] [stderr] | [INFO] [stderr] 87 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 88 | | if c == PlayerSymbol::X { [INFO] [stderr] 89 | | return false; [INFO] [stderr] 90 | | } else if c == PlayerSymbol::O { [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 87 | } else if c == PlayerSymbol::X { [INFO] [stderr] 88 | return false; [INFO] [stderr] 89 | } else if c == PlayerSymbol::O { [INFO] [stderr] 90 | return true; [INFO] [stderr] 91 | } else { [INFO] [stderr] 92 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | newgame [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:187:23 [INFO] [stderr] | [INFO] [stderr] 187 | let newgame = Game { [INFO] [stderr] | _______________________^ [INFO] [stderr] 188 | | board: newboard, [INFO] [stderr] 189 | | xwin: 0, [INFO] [stderr] 190 | | owin: 0, [INFO] [stderr] 191 | | currentsymbol: PlayerSymbol::X, [INFO] [stderr] 192 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:231:16 [INFO] [stderr] | [INFO] [stderr] 231 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 232 | | if self.board.check_draw() == true { [INFO] [stderr] 233 | | println!("It's a draw "); [INFO] [stderr] 234 | | return true; [INFO] [stderr] 235 | | } [INFO] [stderr] 236 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 231 | } else if self.board.check_draw() == true { [INFO] [stderr] 232 | println!("It's a draw "); [INFO] [stderr] 233 | return true; [INFO] [stderr] 234 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playersymbol.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | let x: &str = match self { [INFO] [stderr] | _______________________^ [INFO] [stderr] 11 | | &PlayerSymbol::N => " ", [INFO] [stderr] 12 | | &PlayerSymbol::X => "X", [INFO] [stderr] 13 | | &PlayerSymbol::O => "O", [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | let x: &str = match *self { [INFO] [stderr] 11 | PlayerSymbol::N => " ", [INFO] [stderr] 12 | PlayerSymbol::X => "X", [INFO] [stderr] 13 | PlayerSymbol::O => "O", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | / if c == PlayerSymbol::O { [INFO] [stderr] 63 | | return false; [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | return true; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::O)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 73 | | return false; [INFO] [stderr] 74 | | } else { [INFO] [stderr] 75 | | return true; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::O)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | / if c == PlayerSymbol::X { [INFO] [stderr] 83 | | return false; [INFO] [stderr] 84 | | } else { [INFO] [stderr] 85 | | return true; [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:92:28 [INFO] [stderr] | [INFO] [stderr] 92 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 93 | | return true; [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:90:52 [INFO] [stderr] | [INFO] [stderr] 90 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 91 | | return true; [INFO] [stderr] 92 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression will always return true [INFO] [stderr] --> src/main.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 91 | | return true; [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | return true; [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 101 | | return false; [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | return true; [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::O)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:110:28 [INFO] [stderr] | [INFO] [stderr] 110 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 111 | | return true; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:108:52 [INFO] [stderr] | [INFO] [stderr] 108 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 109 | | return true; [INFO] [stderr] 110 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression will always return true [INFO] [stderr] --> src/main.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 109 | | return true; [INFO] [stderr] 110 | | } else { [INFO] [stderr] 111 | | return true; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:232:16 [INFO] [stderr] | [INFO] [stderr] 232 | if self.board.check_draw() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.board.check_draw()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:255:16 [INFO] [stderr] | [INFO] [stderr] 255 | if is_success == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_success` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:292:12 [INFO] [stderr] | [INFO] [stderr] 292 | if game.play_again() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!game.play_again()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tictactoe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/playersymbol.rs:10:23 [INFO] [stderr] | [INFO] [stderr] 10 | let x: &str = match self { [INFO] [stderr] | _______________________^ [INFO] [stderr] 11 | | &PlayerSymbol::N => " ", [INFO] [stderr] 12 | | &PlayerSymbol::X => "X", [INFO] [stderr] 13 | | &PlayerSymbol::O => "O", [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | let x: &str = match *self { [INFO] [stderr] 11 | PlayerSymbol::N => " ", [INFO] [stderr] 12 | PlayerSymbol::X => "X", [INFO] [stderr] 13 | PlayerSymbol::O => "O", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | / if c == PlayerSymbol::O { [INFO] [stderr] 63 | | return false; [INFO] [stderr] 64 | | } else { [INFO] [stderr] 65 | | return true; [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::O)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:72:28 [INFO] [stderr] | [INFO] [stderr] 72 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 73 | | return false; [INFO] [stderr] 74 | | } else { [INFO] [stderr] 75 | | return true; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::O)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | / if c == PlayerSymbol::X { [INFO] [stderr] 83 | | return false; [INFO] [stderr] 84 | | } else { [INFO] [stderr] 85 | | return true; [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::X)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:92:28 [INFO] [stderr] | [INFO] [stderr] 92 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 93 | | return true; [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:90:52 [INFO] [stderr] | [INFO] [stderr] 90 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 91 | | return true; [INFO] [stderr] 92 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression will always return true [INFO] [stderr] --> src/main.rs:90:28 [INFO] [stderr] | [INFO] [stderr] 90 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 91 | | return true; [INFO] [stderr] 92 | | } else { [INFO] [stderr] 93 | | return true; [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:100:28 [INFO] [stderr] | [INFO] [stderr] 100 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 101 | | return false; [INFO] [stderr] 102 | | } else { [INFO] [stderr] 103 | | return true; [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________________^ help: you can reduce it to: `return !(c == PlayerSymbol::O)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:110:28 [INFO] [stderr] | [INFO] [stderr] 110 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 111 | | return true; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:108:52 [INFO] [stderr] | [INFO] [stderr] 108 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 109 | | return true; [INFO] [stderr] 110 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression will always return true [INFO] [stderr] --> src/main.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | } else if c == PlayerSymbol::O { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 109 | | return true; [INFO] [stderr] 110 | | } else { [INFO] [stderr] 111 | | return true; [INFO] [stderr] 112 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:232:16 [INFO] [stderr] | [INFO] [stderr] 232 | if self.board.check_draw() == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `self.board.check_draw()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:255:16 [INFO] [stderr] | [INFO] [stderr] 255 | if is_success == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `is_success` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:292:12 [INFO] [stderr] | [INFO] [stderr] 292 | if game.play_again() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!game.play_again()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `tictactoe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "498e905f58493c3f15f9ee9e77f845d8fe968c7193bcc07da074758ae9c55364"` [INFO] running `"docker" "rm" "-f" "498e905f58493c3f15f9ee9e77f845d8fe968c7193bcc07da074758ae9c55364"` [INFO] [stdout] 498e905f58493c3f15f9ee9e77f845d8fe968c7193bcc07da074758ae9c55364