[INFO] updating cached repository nicksanders/test1-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nicksanders/test1-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nicksanders/test1-rs" "work/ex/clippy-test-run/sources/stable/gh/nicksanders/test1-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nicksanders/test1-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nicksanders/test1-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicksanders/test1-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicksanders/test1-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 513f89bc072737c83f035ee679ccf3d41616005f [INFO] sha for GitHub repo nicksanders/test1-rs: 513f89bc072737c83f035ee679ccf3d41616005f [INFO] validating manifest of nicksanders/test1-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nicksanders/test1-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nicksanders/test1-rs [INFO] finished frobbing nicksanders/test1-rs [INFO] frobbed toml for nicksanders/test1-rs written to work/ex/clippy-test-run/sources/stable/gh/nicksanders/test1-rs/Cargo.toml [INFO] started frobbing nicksanders/test1-rs [INFO] finished frobbing nicksanders/test1-rs [INFO] frobbed toml for nicksanders/test1-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicksanders/test1-rs/Cargo.toml [INFO] crate nicksanders/test1-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nicksanders/test1-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nicksanders/test1-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 951fbd28ec52a280c9a5ce3c913b25fb3e9e20d8a57eb08f77ab06ece7774a9d [INFO] running `"docker" "start" "-a" "951fbd28ec52a280c9a5ce3c913b25fb3e9e20d8a57eb08f77ab06ece7774a9d"` [INFO] [stderr] Checking test1-rs v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | let mut table = Tbl{name: name, cols: BTreeMap::new()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | Col{name: name, col_type: col_type, null: false, length: None} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | Col{name: name, col_type: col_type, null: false, length: None} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `col_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | let mut table = Tbl{name: name, cols: BTreeMap::new()}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:17 [INFO] [stderr] | [INFO] [stderr] 77 | Col{name: name, col_type: col_type, null: false, length: None} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | Col{name: name, col_type: col_type, null: false, length: None} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `col_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/main.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | v.connect(", ") [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/main.rs:132:62 [INFO] [stderr] | [INFO] [stderr] 132 | s = format!("{} WHERE {}", s, self.where_sql.connect(" AND ")); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code, unused_variables)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code, unused_variables)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | for (_, col) in &self.cols { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 68 | for col in self.cols.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:107:28 [INFO] [stderr] | [INFO] [stderr] 107 | let null_str = match self.null { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 108 | | true => "NULL", [INFO] [stderr] 109 | | false => "NOT NULL", [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.null { "NULL" } else { "NOT NULL" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | if self.where_sql.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.where_sql.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `test1-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/main.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | v.connect(", ") [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::slice::SliceConcatExt::connect': renamed to join [INFO] [stderr] --> src/main.rs:132:62 [INFO] [stderr] | [INFO] [stderr] 132 | s = format!("{} WHERE {}", s, self.where_sql.connect(" AND ")); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code, unused_variables)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code, unused_variables)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:68:29 [INFO] [stderr] | [INFO] [stderr] 68 | for (_, col) in &self.cols { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 68 | for col in self.cols.values() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:107:28 [INFO] [stderr] | [INFO] [stderr] 107 | let null_str = match self.null { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 108 | | true => "NULL", [INFO] [stderr] 109 | | false => "NOT NULL", [INFO] [stderr] 110 | | }; [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.null { "NULL" } else { "NOT NULL" }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | if self.where_sql.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.where_sql.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `test1-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "951fbd28ec52a280c9a5ce3c913b25fb3e9e20d8a57eb08f77ab06ece7774a9d"` [INFO] running `"docker" "rm" "-f" "951fbd28ec52a280c9a5ce3c913b25fb3e9e20d8a57eb08f77ab06ece7774a9d"` [INFO] [stdout] 951fbd28ec52a280c9a5ce3c913b25fb3e9e20d8a57eb08f77ab06ece7774a9d