[INFO] updating cached repository nickmass/mass-renderer
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nickmass/mass-renderer
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/mass-renderer" "work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-renderer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-renderer'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/mass-renderer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/mass-renderer"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/mass-renderer'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5ab559ff38beb36f259a8e8234b2a00801dcabc6
[INFO] sha for GitHub repo nickmass/mass-renderer: 5ab559ff38beb36f259a8e8234b2a00801dcabc6
[INFO] validating manifest of nickmass/mass-renderer on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nickmass/mass-renderer on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nickmass/mass-renderer
[INFO] finished frobbing nickmass/mass-renderer
[INFO] frobbed toml for nickmass/mass-renderer written to work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-renderer/Cargo.toml
[INFO] started frobbing nickmass/mass-renderer
[INFO] finished frobbing nickmass/mass-renderer
[INFO] frobbed toml for nickmass/mass-renderer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/mass-renderer/Cargo.toml
[INFO] crate nickmass/mass-renderer has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nickmass/mass-renderer against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-renderer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e3b3e9714311aa5f3b607a006dd17dda940151a215deaef0f12014ee2e643cd1
[INFO] running `"docker" "start" "-a" "e3b3e9714311aa5f3b607a006dd17dda940151a215deaef0f12014ee2e643cd1"`
[INFO] [stderr]    Compiling gcc v0.3.42
[INFO] [stderr]     Checking smallvec v0.1.8
[INFO] [stderr]     Checking deflate v0.7.2
[INFO] [stderr]    Compiling wayland-scanner v0.7.6
[INFO] [stderr]     Checking num-bigint v0.1.35
[INFO] [stderr]    Compiling glium v0.16.0
[INFO] [stderr]     Checking wayland-sys v0.7.6
[INFO] [stderr]     Checking num-rational v0.1.35
[INFO] [stderr]     Checking png v0.6.2
[INFO] [stderr]    Compiling wayland-client v0.7.6
[INFO] [stderr]    Compiling backtrace-sys v0.1.5
[INFO] [stderr]     Checking image v0.12.1
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]     Checking wayland-kbd v0.6.2
[INFO] [stderr]     Checking wayland-window v0.4.3
[INFO] [stderr]     Checking winit v0.5.10
[INFO] [stderr]     Checking glutin v0.7.4
[INFO] [stderr]     Checking mass-renderer v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderer.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderer.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:209:13
[INFO] [stderr]     |
[INFO] [stderr] 209 |             start: start,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             end: end,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:211:13
[INFO] [stderr]     |
[INFO] [stderr] 211 |             cur: cur,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `cur`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:212:13
[INFO] [stderr]     |
[INFO] [stderr] 212 |             done: done,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `done`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:260:13
[INFO] [stderr]     |
[INFO] [stderr] 260 |             pixels: pixels,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `pixels`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/renderer.rs:310:21
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:316:13
[INFO] [stderr]     |
[INFO] [stderr] 316 |             pixels: pixels,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `pixels`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:317:13
[INFO] [stderr]     |
[INFO] [stderr] 317 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:318:13
[INFO] [stderr]     |
[INFO] [stderr] 318 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/shaders.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             light_matrix: light_matrix,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_matrix`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |         let j = ai * v3(self.uv[1].y - self.uv[0].y, self.uv[2].y - self.uv[0].y, 0.);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:121:13
[INFO] [stderr]     |
[INFO] [stderr] 121 |         let b = M3::from_cols(
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |         let n = (b * ctx.model.normal(uv)).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |         let l = matrix_transform(self.light_dir, self.pm).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |         let r = ((n * n.dot(l * 2.)) - l).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 10th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |         let c = ctx.model.diffuse(uv);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:152:13
[INFO] [stderr]     |
[INFO] [stderr] 152 |             faces: faces,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `faces`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 |             verts: verts,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `verts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:154:13
[INFO] [stderr]     |
[INFO] [stderr] 154 |             uvs: uvs,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `uvs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:155:13
[INFO] [stderr]     |
[INFO] [stderr] 155 |             norms: norms,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `norms`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             display: display,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:76:13
[INFO] [stderr]    |
[INFO] [stderr] 76 |             indicies: indicies,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `indicies`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:77:13
[INFO] [stderr]    |
[INFO] [stderr] 77 |             program: program,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `program`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             vertex_buffer: vertex_buffer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderer.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             width: width,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/renderer.rs:32:13
[INFO] [stderr]    |
[INFO] [stderr] 32 |             height: height,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:209:13
[INFO] [stderr]     |
[INFO] [stderr] 209 |             start: start,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `start`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 |             end: end,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `end`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:211:13
[INFO] [stderr]     |
[INFO] [stderr] 211 |             cur: cur,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `cur`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:212:13
[INFO] [stderr]     |
[INFO] [stderr] 212 |             done: done,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `done`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:260:13
[INFO] [stderr]     |
[INFO] [stderr] 260 |             pixels: pixels,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `pixels`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/renderer.rs:310:21
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:316:13
[INFO] [stderr]     |
[INFO] [stderr] 316 |             pixels: pixels,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `pixels`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:317:13
[INFO] [stderr]     |
[INFO] [stderr] 317 |             width: width,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `width`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/renderer.rs:318:13
[INFO] [stderr]     |
[INFO] [stderr] 318 |             height: height,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `height`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/shaders.rs:67:13
[INFO] [stderr]    |
[INFO] [stderr] 67 |             light_matrix: light_matrix,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_matrix`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:119:13
[INFO] [stderr]     |
[INFO] [stderr] 119 |         let j = ai * v3(self.uv[1].y - self.uv[0].y, self.uv[2].y - self.uv[0].y, 0.);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:121:13
[INFO] [stderr]     |
[INFO] [stderr] 121 |         let b = M3::from_cols(
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:127:13
[INFO] [stderr]     |
[INFO] [stderr] 127 |         let n = (b * ctx.model.normal(uv)).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |         let l = matrix_transform(self.light_dir, self.pm).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |         let r = ((n * n.dot(l * 2.)) - l).normalize();
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 10th binding whose name is just one char
[INFO] [stderr]    --> src/shaders.rs:133:13
[INFO] [stderr]     |
[INFO] [stderr] 133 |         let c = ctx.model.diffuse(uv);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:152:13
[INFO] [stderr]     |
[INFO] [stderr] 152 |             faces: faces,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `faces`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 |             verts: verts,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `verts`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:154:13
[INFO] [stderr]     |
[INFO] [stderr] 154 |             uvs: uvs,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `uvs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:155:13
[INFO] [stderr]     |
[INFO] [stderr] 155 |             norms: norms,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `norms`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:75:13
[INFO] [stderr]    |
[INFO] [stderr] 75 |             display: display,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `display`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:76:13
[INFO] [stderr]    |
[INFO] [stderr] 76 |             indicies: indicies,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `indicies`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:77:13
[INFO] [stderr]    |
[INFO] [stderr] 77 |             program: program,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `program`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/window.rs:78:13
[INFO] [stderr]    |
[INFO] [stderr] 78 |             vertex_buffer: vertex_buffer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertex_buffer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/renderer.rs:472:31
[INFO] [stderr]     |
[INFO] [stderr] 472 |             c[i] = if c[i] <= 0.0031308 {
[INFO] [stderr]     |                               ^^^^^^^^^ help: consider: `0.003_130_8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `SolidShader`
[INFO] [stderr]   --> src/main.rs:31:15
[INFO] [stderr]    |
[INFO] [stderr] 31 | use shaders::{SolidShader, DefaultShader, DepthShader};
[INFO] [stderr]    |               ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/renderer.rs:472:31
[INFO] [stderr]     |
[INFO] [stderr] 472 |             c[i] = if c[i] <= 0.0031308 {
[INFO] [stderr]     |                               ^^^^^^^^^ help: consider: `0.003_130_8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `SolidShader`
[INFO] [stderr]   --> src/main.rs:31:15
[INFO] [stderr]    |
[INFO] [stderr] 31 | use shaders::{SolidShader, DefaultShader, DepthShader};
[INFO] [stderr]    |               ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/renderer.rs:92:28
[INFO] [stderr]    |
[INFO] [stderr] 92 |             let clamp = v2((self.width-1) as f64, (self.height-1) as f64);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width-1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/renderer.rs:92:51
[INFO] [stderr]    |
[INFO] [stderr] 92 |             let clamp = v2((self.width-1) as f64, (self.height-1) as f64);
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height-1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/renderer.rs:123:17
[INFO] [stderr]     |
[INFO] [stderr] 123 |                    shader.fragment(ctx, clip).map(|c| {
[INFO] [stderr]     |   _________________^
[INFO] [stderr]     |  |_________________|
[INFO] [stderr]     | ||
[INFO] [stderr] 124 | ||                     self.display_buf.set(image_x, image_y, c);
[INFO] [stderr] 125 | ||                     self.z_buf.set(image_x, image_y, z);
[INFO] [stderr] 126 | ||                 });
[INFO] [stderr]     | ||__________________^- help: try this: `if let Some(c) = shader.fragment(ctx, clip) { ... }`
[INFO] [stderr]     | |___________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/renderer.rs:172:21
[INFO] [stderr]     |
[INFO] [stderr] 172 | fn barycentric(tri: &Vec<V3>, p: &V2) -> V3 {
[INFO] [stderr]     |                     ^^^^^^^^ help: change this to: `&[V3]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/renderer.rs:268:9
[INFO] [stderr]     |
[INFO] [stderr] 268 | /         let mut steep = false;
[INFO] [stderr] 269 | |         if (x0 - x1).abs() < (y0 - y1).abs() {
[INFO] [stderr] 270 | |             ::std::mem::swap(&mut x0, &mut y0);
[INFO] [stderr] 271 | |             ::std::mem::swap(&mut x1, &mut y1);
[INFO] [stderr] 272 | |             steep = true;
[INFO] [stderr] 273 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> steep = if (x0 - x1).abs() < (y0 - y1).abs() { ..; true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/renderer.rs:286:18
[INFO] [stderr]     |
[INFO] [stderr] 286 |         for x in x0..x1 + 1 {
[INFO] [stderr]     |                  ^^^^^^^^^^ help: use: `x0..=x1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:28
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                            ^^^^^^^^ help: try: `f64::from(r)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:45
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                                             ^^^^^^^^ help: try: `f64::from(g)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:62
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                                                              ^^^^^^^^ help: try: `f64::from(b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:79
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                                                                               ^^^^^^^^ help: try: `f64::from(a)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/renderer.rs:311:29
[INFO] [stderr]     |
[INFO] [stderr] 311 |                 pixels.push(c.into());
[INFO] [stderr]     |                             ^^^^^^^^ help: consider removing `.into()`: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:350:21
[INFO] [stderr]     |
[INFO] [stderr] 350 |         self.get((x*(self.width - 1) as f64) as u32, (y*(self.height - 1) as f64) as u32)
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:350:57
[INFO] [stderr]     |
[INFO] [stderr] 350 |         self.get((x*(self.width - 1) as f64) as u32, (y*(self.height - 1) as f64) as u32)
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:390:39
[INFO] [stderr]     |
[INFO] [stderr] 390 |         let x = x.max(0.0).min(1.0) * (self.width() - 1) as f64;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:391:39
[INFO] [stderr]     |
[INFO] [stderr] 391 |         let y = y.max(0.0).min(1.0) * (self.height() - 1) as f64;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:445:14
[INFO] [stderr]     |
[INFO] [stderr] 445 |     pub fn a(&self) -> u8 { self.alpha }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:446:14
[INFO] [stderr]     |
[INFO] [stderr] 446 |     pub fn r(&self) -> u8 { self.red }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:447:14
[INFO] [stderr]     |
[INFO] [stderr] 447 |     pub fn g(&self) -> u8 { self.green }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:448:14
[INFO] [stderr]     |
[INFO] [stderr] 448 |     pub fn b(&self) -> u8 { self.blue }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:451:17
[INFO] [stderr]     |
[INFO] [stderr] 451 |         let a = self.a() as f64 / 255.;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try: `f64::from(self.a())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `c`.
[INFO] [stderr]    --> src/renderer.rs:454:18
[INFO] [stderr]     |
[INFO] [stderr] 454 |         for i in 0..3 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 454 |         for <item> in c.iter_mut().take(3) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:468:17
[INFO] [stderr]     |
[INFO] [stderr] 468 |         let a = self.a() as f64 / 255.;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try: `f64::from(self.a())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `c`.
[INFO] [stderr]    --> src/renderer.rs:471:18
[INFO] [stderr]     |
[INFO] [stderr] 471 |         for i in 0..3 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 471 |         for <item> in c.iter_mut().take(3) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:488:13
[INFO] [stderr]     |
[INFO] [stderr] 488 |             c.r() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.r())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:489:13
[INFO] [stderr]     |
[INFO] [stderr] 489 |             c.g() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.g())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:490:13
[INFO] [stderr]     |
[INFO] [stderr] 490 |             c.b() as f64 / 255.0
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.b())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:498:13
[INFO] [stderr]     |
[INFO] [stderr] 498 |             c.r() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.r())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:499:13
[INFO] [stderr]     |
[INFO] [stderr] 499 |             c.g() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.g())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:500:13
[INFO] [stderr]     |
[INFO] [stderr] 500 |             c.b() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.b())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:501:13
[INFO] [stderr]     |
[INFO] [stderr] 501 |             c.a() as f64 / 255.0
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.a())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/shaders.rs:102:36
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let (x ,y) = (shadow_c.x / (self.light_depth.width() - 1) as f64,
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.light_depth.width() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/shaders.rs:103:36
[INFO] [stderr]     |
[INFO] [stderr] 103 |                       shadow_c.y / (self.light_depth.height() - 1) as f64);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.light_depth.height() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `c`.
[INFO] [stderr]    --> src/shaders.rs:136:18
[INFO] [stderr]     |
[INFO] [stderr] 136 |         for i in 0..3 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 136 |         for <item> in c.iter_mut().take(3) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `shaders::DepthShader`
[INFO] [stderr]    --> src/shaders.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 | /     pub fn new() -> DepthShader {
[INFO] [stderr] 150 | |         DepthShader {
[INFO] [stderr] 151 | |             transform: M4::identity(),
[INFO] [stderr] 152 | |         }
[INFO] [stderr] 153 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 148 | impl Default for shaders::DepthShader {
[INFO] [stderr] 149 |     fn default() -> Self {
[INFO] [stderr] 150 |         Self::new()
[INFO] [stderr] 151 |     }
[INFO] [stderr] 152 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model.rs:44:60
[INFO] [stderr]    |
[INFO] [stderr] 44 |             let parts: Vec<&str> = l.split(' ').filter(|x| x.len() > 0).collect();
[INFO] [stderr]    |                                                            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 |             if parts.len() == 0 { return None; }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/model.rs:162:5
[INFO] [stderr]     |
[INFO] [stderr] 162 | /     pub fn faces<'a>(&'a self) -> FaceIterator<'a> {
[INFO] [stderr] 163 | |         FaceIterator {
[INFO] [stderr] 164 | |             model: self,
[INFO] [stderr] 165 | |             cur: 0,
[INFO] [stderr] 166 | |         }
[INFO] [stderr] 167 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/model.rs:194:27
[INFO] [stderr]     |
[INFO] [stderr] 194 |                 a.0.push(*self.model.verts.get(t[0] - 1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.model.verts[t[0] - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/model.rs:195:27
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 a.1.push(*self.model.uvs.get(t[1] - 1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.model.uvs[t[1] - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/model.rs:196:27
[INFO] [stderr]     |
[INFO] [stderr] 196 |                 a.2.push(*self.model.norms.get(t[2] - 1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.model.norms[t[2] - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/window.rs:31:25
[INFO] [stderr]    |
[INFO] [stderr] 31 |             .with_title(format!("Mass Renderer"))
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Mass Renderer".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/window.rs:85:13
[INFO] [stderr]    |
[INFO] [stderr] 85 | /             match ev {
[INFO] [stderr] 86 | |                 glium::glutin::Event::Closed => self.closed = true,
[INFO] [stderr] 87 | |                 _ => ()
[INFO] [stderr] 88 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let glium::glutin::Event::Closed = ev { self.closed = true }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:58:27
[INFO] [stderr]    |
[INFO] [stderr] 58 |         renderer.viewport(width as f64 / 4.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:59:27
[INFO] [stderr]    |
[INFO] [stderr] 59 |                           height as f64 / 4.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:60:27
[INFO] [stderr]    |
[INFO] [stderr] 60 |                           width as f64 * 0.5,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:61:27
[INFO] [stderr]    |
[INFO] [stderr] 61 |                           height as f64 * 0.5);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:75:27
[INFO] [stderr]    |
[INFO] [stderr] 75 |         renderer.viewport(width as f64 / 8.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:76:27
[INFO] [stderr]    |
[INFO] [stderr] 76 |                           height as f64 / 8.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:77:27
[INFO] [stderr]    |
[INFO] [stderr] 77 |                           width as f64 * 0.75,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:78:27
[INFO] [stderr]    |
[INFO] [stderr] 78 |                           height as f64 * 0.75);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/renderer.rs:92:28
[INFO] [stderr]    |
[INFO] [stderr] 92 |             let clamp = v2((self.width-1) as f64, (self.height-1) as f64);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width-1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/renderer.rs:92:51
[INFO] [stderr]    |
[INFO] [stderr] 92 |             let clamp = v2((self.width-1) as f64, (self.height-1) as f64);
[INFO] [stderr]    |                                                   ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height-1)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]    --> src/renderer.rs:123:17
[INFO] [stderr]     |
[INFO] [stderr] 123 |                    shader.fragment(ctx, clip).map(|c| {
[INFO] [stderr]     |   _________________^
[INFO] [stderr]     |  |_________________|
[INFO] [stderr]     | ||
[INFO] [stderr] 124 | ||                     self.display_buf.set(image_x, image_y, c);
[INFO] [stderr] 125 | ||                     self.z_buf.set(image_x, image_y, z);
[INFO] [stderr] 126 | ||                 });
[INFO] [stderr]     | ||__________________^- help: try this: `if let Some(c) = shader.fragment(ctx, clip) { ... }`
[INFO] [stderr]     | |___________________|
[INFO] [stderr]     | 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/renderer.rs:172:21
[INFO] [stderr]     |
[INFO] [stderr] 172 | fn barycentric(tri: &Vec<V3>, p: &V2) -> V3 {
[INFO] [stderr]     |                     ^^^^^^^^ help: change this to: `&[V3]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/renderer.rs:268:9
[INFO] [stderr]     |
[INFO] [stderr] 268 | /         let mut steep = false;
[INFO] [stderr] 269 | |         if (x0 - x1).abs() < (y0 - y1).abs() {
[INFO] [stderr] 270 | |             ::std::mem::swap(&mut x0, &mut y0);
[INFO] [stderr] 271 | |             ::std::mem::swap(&mut x1, &mut y1);
[INFO] [stderr] 272 | |             steep = true;
[INFO] [stderr] 273 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> steep = if (x0 - x1).abs() < (y0 - y1).abs() { ..; true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/renderer.rs:286:18
[INFO] [stderr]     |
[INFO] [stderr] 286 |         for x in x0..x1 + 1 {
[INFO] [stderr]     |                  ^^^^^^^^^^ help: use: `x0..=x1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:28
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                            ^^^^^^^^ help: try: `f64::from(r)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:45
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                                             ^^^^^^^^ help: try: `f64::from(g)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:62
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                                                              ^^^^^^^^ help: try: `f64::from(b)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:310:79
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 let c = v4(r as f64 / 255., g as f64 / 255., b as f64 / 255., a as f64 / 255.);
[INFO] [stderr]     |                                                                               ^^^^^^^^ help: try: `f64::from(a)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/renderer.rs:311:29
[INFO] [stderr]     |
[INFO] [stderr] 311 |                 pixels.push(c.into());
[INFO] [stderr]     |                             ^^^^^^^^ help: consider removing `.into()`: `c`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:350:21
[INFO] [stderr]     |
[INFO] [stderr] 350 |         self.get((x*(self.width - 1) as f64) as u32, (y*(self.height - 1) as f64) as u32)
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:350:57
[INFO] [stderr]     |
[INFO] [stderr] 350 |         self.get((x*(self.width - 1) as f64) as u32, (y*(self.height - 1) as f64) as u32)
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:390:39
[INFO] [stderr]     |
[INFO] [stderr] 390 |         let x = x.max(0.0).min(1.0) * (self.width() - 1) as f64;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.width() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:391:39
[INFO] [stderr]     |
[INFO] [stderr] 391 |         let y = y.max(0.0).min(1.0) * (self.height() - 1) as f64;
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.height() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:445:14
[INFO] [stderr]     |
[INFO] [stderr] 445 |     pub fn a(&self) -> u8 { self.alpha }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:446:14
[INFO] [stderr]     |
[INFO] [stderr] 446 |     pub fn r(&self) -> u8 { self.red }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:447:14
[INFO] [stderr]     |
[INFO] [stderr] 447 |     pub fn g(&self) -> u8 { self.green }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/renderer.rs:448:14
[INFO] [stderr]     |
[INFO] [stderr] 448 |     pub fn b(&self) -> u8 { self.blue }
[INFO] [stderr]     |              ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:451:17
[INFO] [stderr]     |
[INFO] [stderr] 451 |         let a = self.a() as f64 / 255.;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try: `f64::from(self.a())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `c`.
[INFO] [stderr]    --> src/renderer.rs:454:18
[INFO] [stderr]     |
[INFO] [stderr] 454 |         for i in 0..3 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 454 |         for <item> in c.iter_mut().take(3) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:468:17
[INFO] [stderr]     |
[INFO] [stderr] 468 |         let a = self.a() as f64 / 255.;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^ help: try: `f64::from(self.a())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `c`.
[INFO] [stderr]    --> src/renderer.rs:471:18
[INFO] [stderr]     |
[INFO] [stderr] 471 |         for i in 0..3 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 471 |         for <item> in c.iter_mut().take(3) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:488:13
[INFO] [stderr]     |
[INFO] [stderr] 488 |             c.r() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.r())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:489:13
[INFO] [stderr]     |
[INFO] [stderr] 489 |             c.g() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.g())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:490:13
[INFO] [stderr]     |
[INFO] [stderr] 490 |             c.b() as f64 / 255.0
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.b())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:498:13
[INFO] [stderr]     |
[INFO] [stderr] 498 |             c.r() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.r())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:499:13
[INFO] [stderr]     |
[INFO] [stderr] 499 |             c.g() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.g())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:500:13
[INFO] [stderr]     |
[INFO] [stderr] 500 |             c.b() as f64 / 255.0,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.b())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/renderer.rs:501:13
[INFO] [stderr]     |
[INFO] [stderr] 501 |             c.a() as f64 / 255.0
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: try: `f64::from(c.a())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/shaders.rs:102:36
[INFO] [stderr]     |
[INFO] [stderr] 102 |         let (x ,y) = (shadow_c.x / (self.light_depth.width() - 1) as f64,
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.light_depth.width() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/shaders.rs:103:36
[INFO] [stderr]     |
[INFO] [stderr] 103 |                       shadow_c.y / (self.light_depth.height() - 1) as f64);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.light_depth.height() - 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `c`.
[INFO] [stderr]    --> src/shaders.rs:136:18
[INFO] [stderr]     |
[INFO] [stderr] 136 |         for i in 0..3 {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 136 |         for <item> in c.iter_mut().take(3) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `shaders::DepthShader`
[INFO] [stderr]    --> src/shaders.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 | /     pub fn new() -> DepthShader {
[INFO] [stderr] 150 | |         DepthShader {
[INFO] [stderr] 151 | |             transform: M4::identity(),
[INFO] [stderr] 152 | |         }
[INFO] [stderr] 153 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 148 | impl Default for shaders::DepthShader {
[INFO] [stderr] 149 |     fn default() -> Self {
[INFO] [stderr] 150 |         Self::new()
[INFO] [stderr] 151 |     }
[INFO] [stderr] 152 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model.rs:44:60
[INFO] [stderr]    |
[INFO] [stderr] 44 |             let parts: Vec<&str> = l.split(' ').filter(|x| x.len() > 0).collect();
[INFO] [stderr]    |                                                            ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/model.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 |             if parts.len() == 0 { return None; }
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/model.rs:162:5
[INFO] [stderr]     |
[INFO] [stderr] 162 | /     pub fn faces<'a>(&'a self) -> FaceIterator<'a> {
[INFO] [stderr] 163 | |         FaceIterator {
[INFO] [stderr] 164 | |             model: self,
[INFO] [stderr] 165 | |             cur: 0,
[INFO] [stderr] 166 | |         }
[INFO] [stderr] 167 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/model.rs:194:27
[INFO] [stderr]     |
[INFO] [stderr] 194 |                 a.0.push(*self.model.verts.get(t[0] - 1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.model.verts[t[0] - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/model.rs:195:27
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 a.1.push(*self.model.uvs.get(t[1] - 1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.model.uvs[t[1] - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/model.rs:196:27
[INFO] [stderr]     |
[INFO] [stderr] 196 |                 a.2.push(*self.model.norms.get(t[2] - 1).unwrap());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.model.norms[t[2] - 1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/window.rs:31:25
[INFO] [stderr]    |
[INFO] [stderr] 31 |             .with_title(format!("Mass Renderer"))
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Mass Renderer".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/window.rs:85:13
[INFO] [stderr]    |
[INFO] [stderr] 85 | /             match ev {
[INFO] [stderr] 86 | |                 glium::glutin::Event::Closed => self.closed = true,
[INFO] [stderr] 87 | |                 _ => ()
[INFO] [stderr] 88 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let glium::glutin::Event::Closed = ev { self.closed = true }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:58:27
[INFO] [stderr]    |
[INFO] [stderr] 58 |         renderer.viewport(width as f64 / 4.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:59:27
[INFO] [stderr]    |
[INFO] [stderr] 59 |                           height as f64 / 4.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:60:27
[INFO] [stderr]    |
[INFO] [stderr] 60 |                           width as f64 * 0.5,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:61:27
[INFO] [stderr]    |
[INFO] [stderr] 61 |                           height as f64 * 0.5);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:75:27
[INFO] [stderr]    |
[INFO] [stderr] 75 |         renderer.viewport(width as f64 / 8.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:76:27
[INFO] [stderr]    |
[INFO] [stderr] 76 |                           height as f64 / 8.,
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:77:27
[INFO] [stderr]    |
[INFO] [stderr] 77 |                           width as f64 * 0.75,
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `f64::from(width)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:78:27
[INFO] [stderr]    |
[INFO] [stderr] 78 |                           height as f64 * 0.75);
[INFO] [stderr]    |                           ^^^^^^^^^^^^^ help: try: `f64::from(height)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 43.97s
[INFO] running `"docker" "inspect" "e3b3e9714311aa5f3b607a006dd17dda940151a215deaef0f12014ee2e643cd1"`
[INFO] running `"docker" "rm" "-f" "e3b3e9714311aa5f3b607a006dd17dda940151a215deaef0f12014ee2e643cd1"`
[INFO] [stdout] e3b3e9714311aa5f3b607a006dd17dda940151a215deaef0f12014ee2e643cd1