[INFO] updating cached repository nickmass/mass-acme [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nickmass/mass-acme [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/mass-acme" "work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-acme"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-acme'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/mass-acme" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/mass-acme"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/mass-acme'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4d800164c4d0bcc273ad326a2611ae38ffb6223d [INFO] sha for GitHub repo nickmass/mass-acme: 4d800164c4d0bcc273ad326a2611ae38ffb6223d [INFO] validating manifest of nickmass/mass-acme on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickmass/mass-acme on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickmass/mass-acme [INFO] finished frobbing nickmass/mass-acme [INFO] frobbed toml for nickmass/mass-acme written to work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-acme/Cargo.toml [INFO] started frobbing nickmass/mass-acme [INFO] finished frobbing nickmass/mass-acme [INFO] frobbed toml for nickmass/mass-acme written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/mass-acme/Cargo.toml [INFO] crate nickmass/mass-acme has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickmass/mass-acme against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nickmass/mass-acme:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8d3c9b1bfec98747c2f1c8e4ff5ff5a4ebdf941fcd1e56ccfb5ed64d38df1cfc [INFO] running `"docker" "start" "-a" "8d3c9b1bfec98747c2f1c8e4ff5ff5a4ebdf941fcd1e56ccfb5ed64d38df1cfc"` [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Checking serde_json v1.0.10 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking backtrace-sys v0.1.16 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Compiling rusoto_core v0.31.0 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking env_logger v0.5.4 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking mio v0.6.13 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking digest v0.7.2 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking sha2 v0.7.0 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking hyper v0.11.21 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking acme-client v0.5.1 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking rusoto_credential v0.10.0 [INFO] [stderr] Checking rusoto_route53 v0.31.0 [INFO] [stderr] Checking mass-acme v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | name: name, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | change_batch: change_batch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change_batch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | name: name, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | change_batch: change_batch, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `change_batch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/main.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / fn run() -> Result<(), Error> { [INFO] [stderr] 119 | | let mut builder = ::env_logger::Builder::new(); [INFO] [stderr] 120 | | builder.filter(None, ::log::LevelFilter::Info); [INFO] [stderr] 121 | | builder.init(); [INFO] [stderr] ... | [INFO] [stderr] 266 | | Ok(()) [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:125:30 [INFO] [stderr] | [INFO] [stderr] 125 | let config = args.next().unwrap_or(String::from("config.json")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("config.json"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | let _ = std::fs::create_dir_all(&*config.certificate_directory).context("Could not create SSL directory")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / let _ = std::fs::create_dir_all(cert_dir) [INFO] [stderr] 208 | | .context(format!("Unable to create cert directory for: {}", cert.name))?; [INFO] [stderr] | |_____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: the `s @ _` pattern can be written as just `s` [INFO] [stderr] --> src/main.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | s @ _ => Err(AcmeError::Route53InvalidChangeResponse(s.to_string()))?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/main.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / fn run() -> Result<(), Error> { [INFO] [stderr] 119 | | let mut builder = ::env_logger::Builder::new(); [INFO] [stderr] 120 | | builder.filter(None, ::log::LevelFilter::Info); [INFO] [stderr] 121 | | builder.init(); [INFO] [stderr] ... | [INFO] [stderr] 266 | | Ok(()) [INFO] [stderr] 267 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:125:30 [INFO] [stderr] | [INFO] [stderr] 125 | let config = args.next().unwrap_or(String::from("config.json")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from("config.json"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:133:5 [INFO] [stderr] | [INFO] [stderr] 133 | let _ = std::fs::create_dir_all(&*config.certificate_directory).context("Could not create SSL directory")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/main.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / let _ = std::fs::create_dir_all(cert_dir) [INFO] [stderr] 208 | | .context(format!("Unable to create cert directory for: {}", cert.name))?; [INFO] [stderr] | |_____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: the `s @ _` pattern can be written as just `s` [INFO] [stderr] --> src/main.rs:381:17 [INFO] [stderr] | [INFO] [stderr] 381 | s @ _ => Err(AcmeError::Route53InvalidChangeResponse(s.to_string()))?, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.92s [INFO] running `"docker" "inspect" "8d3c9b1bfec98747c2f1c8e4ff5ff5a4ebdf941fcd1e56ccfb5ed64d38df1cfc"` [INFO] running `"docker" "rm" "-f" "8d3c9b1bfec98747c2f1c8e4ff5ff5a4ebdf941fcd1e56ccfb5ed64d38df1cfc"` [INFO] [stdout] 8d3c9b1bfec98747c2f1c8e4ff5ff5a4ebdf941fcd1e56ccfb5ed64d38df1cfc