[INFO] updating cached repository nickmass/create-gh-repo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nickmass/create-gh-repo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/create-gh-repo" "work/ex/clippy-test-run/sources/stable/gh/nickmass/create-gh-repo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickmass/create-gh-repo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/create-gh-repo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/create-gh-repo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/create-gh-repo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 04c0a72c85d0c439617e5969aeb1a1b2997e193a [INFO] sha for GitHub repo nickmass/create-gh-repo: 04c0a72c85d0c439617e5969aeb1a1b2997e193a [INFO] validating manifest of nickmass/create-gh-repo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickmass/create-gh-repo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickmass/create-gh-repo [INFO] finished frobbing nickmass/create-gh-repo [INFO] frobbed toml for nickmass/create-gh-repo written to work/ex/clippy-test-run/sources/stable/gh/nickmass/create-gh-repo/Cargo.toml [INFO] started frobbing nickmass/create-gh-repo [INFO] finished frobbing nickmass/create-gh-repo [INFO] frobbed toml for nickmass/create-gh-repo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/create-gh-repo/Cargo.toml [INFO] crate nickmass/create-gh-repo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickmass/create-gh-repo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nickmass/create-gh-repo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd376db0c7d46efa8f6dbd013e41fb5376e77ed3c32a7a95ea163d9a7396e6fc [INFO] running `"docker" "start" "-a" "fd376db0c7d46efa8f6dbd013e41fb5376e77ed3c32a7a95ea163d9a7396e6fc"` [INFO] [stderr] Compiling openssl v0.9.6 [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Compiling libz-sys v1.0.12 [INFO] [stderr] Compiling curl-sys v0.3.9 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking term_size v0.2.2 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking serde_json v0.9.5 [INFO] [stderr] Compiling openssl-sys v0.9.6 [INFO] [stderr] Compiling libssh2-sys v0.2.5 [INFO] [stderr] Compiling libgit2-sys v0.6.6 [INFO] [stderr] Checking idna v0.1.0 [INFO] [stderr] Checking rpassword v0.2.3 [INFO] [stderr] Checking clap v2.20.3 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking url v1.4.0 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] Checking hyper v0.10.4 [INFO] [stderr] Checking serde_urlencoded v0.4.2 [INFO] [stderr] Checking native-tls v0.1.1 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking git2 v0.6.4 [INFO] [stderr] Checking create-gh-repo v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | editor: editor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `editor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cli.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | editor: editor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `editor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | auth: auth, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `auth` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cli.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Deserialize` [INFO] [stderr] --> src/error.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Deserialize(serde::de::value::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | let auth = try!(auth.ok_or(Error::MissingParameter("authentication".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingParameter("authentication".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:157:39 [INFO] [stderr] | [INFO] [stderr] 157 | let editor = try!(self.editor.ok_or(Error::MissingParameter("editor".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingParameter("editor".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:158:35 [INFO] [stderr] | [INFO] [stderr] 158 | let mode = try!(self.mode.ok_or(Error::MissingParameter("mode".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingParameter("mode".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Deserialize` [INFO] [stderr] --> src/error.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Deserialize(serde::de::value::Error), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/git.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | match url.to_file_path() [INFO] [stderr] | _______________^ [INFO] [stderr] 28 | | .ok() [INFO] [stderr] 29 | | .map_or(None, |x| { [INFO] [stderr] 30 | | x.file_stem() [INFO] [stderr] 31 | | .map(|x| x.to_string_lossy().into_owned()) [INFO] [stderr] 32 | | }) { [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 27 | match url.to_file_path() [INFO] [stderr] 28 | .ok().and_then(|x| { [INFO] [stderr] 29 | x.file_stem() [INFO] [stderr] 30 | .map(|x| x.to_string_lossy().into_owned()) [INFO] [stderr] 31 | }) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:156:30 [INFO] [stderr] | [INFO] [stderr] 156 | let auth = try!(auth.ok_or(Error::MissingParameter("authentication".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingParameter("authentication".into()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:157:39 [INFO] [stderr] | [INFO] [stderr] 157 | let editor = try!(self.editor.ok_or(Error::MissingParameter("editor".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingParameter("editor".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:158:35 [INFO] [stderr] | [INFO] [stderr] 158 | let mode = try!(self.mode.ok_or(Error::MissingParameter("mode".into()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::MissingParameter("mode".into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/git.rs:27:15 [INFO] [stderr] | [INFO] [stderr] 27 | match url.to_file_path() [INFO] [stderr] | _______________^ [INFO] [stderr] 28 | | .ok() [INFO] [stderr] 29 | | .map_or(None, |x| { [INFO] [stderr] 30 | | x.file_stem() [INFO] [stderr] 31 | | .map(|x| x.to_string_lossy().into_owned()) [INFO] [stderr] 32 | | }) { [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] help: try using and_then instead [INFO] [stderr] | [INFO] [stderr] 27 | match url.to_file_path() [INFO] [stderr] 28 | .ok().and_then(|x| { [INFO] [stderr] 29 | x.file_stem() [INFO] [stderr] 30 | .map(|x| x.to_string_lossy().into_owned()) [INFO] [stderr] 31 | }) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / named!(strip_comments<&str, String>, fold_many0!(alt!(chain!( [INFO] [stderr] 132 | | val: take_until_s!(" //") ~ [INFO] [stderr] 133 | | is_not_s!("\r\n")~ [INFO] [stderr] 134 | | tag_s!("\r")?~ [INFO] [stderr] ... | [INFO] [stderr] 140 | | acc [INFO] [stderr] 141 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | name: git::get_repo_name(dir).unwrap_or("".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:131:9 [INFO] [stderr] | [INFO] [stderr] 131 | / named!(strip_comments<&str, String>, fold_many0!(alt!(chain!( [INFO] [stderr] 132 | | val: take_until_s!(" //") ~ [INFO] [stderr] 133 | | is_not_s!("\r\n")~ [INFO] [stderr] 134 | | tag_s!("\r")?~ [INFO] [stderr] ... | [INFO] [stderr] 140 | | acc [INFO] [stderr] 141 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:163:39 [INFO] [stderr] | [INFO] [stderr] 163 | name: git::get_repo_name(dir).unwrap_or("".into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 01s [INFO] running `"docker" "inspect" "fd376db0c7d46efa8f6dbd013e41fb5376e77ed3c32a7a95ea163d9a7396e6fc"` [INFO] running `"docker" "rm" "-f" "fd376db0c7d46efa8f6dbd013e41fb5376e77ed3c32a7a95ea163d9a7396e6fc"` [INFO] [stdout] fd376db0c7d46efa8f6dbd013e41fb5376e77ed3c32a7a95ea163d9a7396e6fc