[INFO] updating cached repository nickmass/brainfuck-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nickmass/brainfuck-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/brainfuck-rust" "work/ex/clippy-test-run/sources/stable/gh/nickmass/brainfuck-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickmass/brainfuck-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/brainfuck-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/brainfuck-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/brainfuck-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 99facfcf65fcaec7379352183e17811c5cfa028a [INFO] sha for GitHub repo nickmass/brainfuck-rust: 99facfcf65fcaec7379352183e17811c5cfa028a [INFO] validating manifest of nickmass/brainfuck-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickmass/brainfuck-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickmass/brainfuck-rust [INFO] finished frobbing nickmass/brainfuck-rust [INFO] frobbed toml for nickmass/brainfuck-rust written to work/ex/clippy-test-run/sources/stable/gh/nickmass/brainfuck-rust/Cargo.toml [INFO] started frobbing nickmass/brainfuck-rust [INFO] finished frobbing nickmass/brainfuck-rust [INFO] frobbed toml for nickmass/brainfuck-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/brainfuck-rust/Cargo.toml [INFO] crate nickmass/brainfuck-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting nickmass/brainfuck-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nickmass/brainfuck-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb53df295e0008369c6506173c61c5b096f608516c32dbe4b745e9925f06db64 [INFO] running `"docker" "start" "-a" "bb53df295e0008369c6506173c61c5b096f608516c32dbe4b745e9925f06db64"` [INFO] [stderr] Checking clap v2.14.0 [INFO] [stderr] Checking brainfuck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | mem_size: mem_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | mem_size: mem_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | directory: directory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | column: column, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:259:13 [INFO] [stderr] | [INFO] [stderr] 259 | mem: mem, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mem` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | mem_size: mem_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:298:13 [INFO] [stderr] | [INFO] [stderr] 298 | ast: ast, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/brainfuck.rs:299:13 [INFO] [stderr] | [INFO] [stderr] 299 | mem_size: mem_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mem_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/brainfuck.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | program: Program::new(x, 100000) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/brainfuck.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | prog [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/brainfuck.rs:297:20 [INFO] [stderr] | [INFO] [stderr] 297 | let prog = Program { [INFO] [stderr] | ____________________^ [INFO] [stderr] 298 | | ast: ast, [INFO] [stderr] 299 | | mem_size: mem_size, [INFO] [stderr] 300 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/brainfuck.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | program: Program::new(x, 100000) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/brainfuck.rs:302:9 [INFO] [stderr] | [INFO] [stderr] 302 | prog [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/brainfuck.rs:297:20 [INFO] [stderr] | [INFO] [stderr] 297 | let prog = Program { [INFO] [stderr] | ____________________^ [INFO] [stderr] 298 | | ast: ast, [INFO] [stderr] 299 | | mem_size: mem_size, [INFO] [stderr] 300 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/brainfuck.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | / match node { [INFO] [stderr] 314 | | &Node::IncPtr(v, _) => state.ptr = state.ptr.wrapping_add(v), [INFO] [stderr] 315 | | &Node::DecPtr(v, _) => state.ptr = state.ptr.wrapping_sub(v), [INFO] [stderr] 316 | | &Node::Increment(v, ref d) => { [INFO] [stderr] ... | [INFO] [stderr] 356 | | }, [INFO] [stderr] 357 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 313 | match *node { [INFO] [stderr] 314 | Node::IncPtr(v, _) => state.ptr = state.ptr.wrapping_add(v), [INFO] [stderr] 315 | Node::DecPtr(v, _) => state.ptr = state.ptr.wrapping_sub(v), [INFO] [stderr] 316 | Node::Increment(v, ref d) => { [INFO] [stderr] 317 | if state.is_oob() { [INFO] [stderr] 318 | return Err(ExecError::OutOfBounds(d)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/brainfuck.rs:348:25 [INFO] [stderr] | [INFO] [stderr] 348 | / match Self::exec_nodes(state, nodes) { [INFO] [stderr] 349 | | Err(e) => return Err(e), [INFO] [stderr] 350 | | _ => (), [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(e) = Self::exec_nodes(state, nodes) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/brainfuck.rs:375:24 [INFO] [stderr] | [INFO] [stderr] 375 | let epilogue = format!(" [INFO] [stderr] | ________________________^ [INFO] [stderr] 376 | | \tret i32 0 [INFO] [stderr] 377 | | }}"); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 375 | let epilogue = " [INFO] [stderr] 376 | \tret i32 0 [INFO] [stderr] 377 | }}".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/brainfuck.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | / match node { [INFO] [stderr] 385 | | &Node::IncPtr(v, _) => { [INFO] [stderr] 386 | | let i0 = state.ident(); [INFO] [stderr] 387 | | let i1 = state.ident(); [INFO] [stderr] ... | [INFO] [stderr] 485 | | }, [INFO] [stderr] 486 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 384 | match *node { [INFO] [stderr] 385 | Node::IncPtr(v, _) => { [INFO] [stderr] 386 | let i0 = state.ident(); [INFO] [stderr] 387 | let i1 = state.ident(); [INFO] [stderr] 388 | let r = format!(" [INFO] [stderr] 389 | \t{ptr} = load i32* %ptr [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/brainfuck.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | / match node { [INFO] [stderr] 314 | | &Node::IncPtr(v, _) => state.ptr = state.ptr.wrapping_add(v), [INFO] [stderr] 315 | | &Node::DecPtr(v, _) => state.ptr = state.ptr.wrapping_sub(v), [INFO] [stderr] 316 | | &Node::Increment(v, ref d) => { [INFO] [stderr] ... | [INFO] [stderr] 356 | | }, [INFO] [stderr] 357 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 313 | match *node { [INFO] [stderr] 314 | Node::IncPtr(v, _) => state.ptr = state.ptr.wrapping_add(v), [INFO] [stderr] 315 | Node::DecPtr(v, _) => state.ptr = state.ptr.wrapping_sub(v), [INFO] [stderr] 316 | Node::Increment(v, ref d) => { [INFO] [stderr] 317 | if state.is_oob() { [INFO] [stderr] 318 | return Err(ExecError::OutOfBounds(d)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/brainfuck.rs:348:25 [INFO] [stderr] | [INFO] [stderr] 348 | / match Self::exec_nodes(state, nodes) { [INFO] [stderr] 349 | | Err(e) => return Err(e), [INFO] [stderr] 350 | | _ => (), [INFO] [stderr] 351 | | } [INFO] [stderr] | |_________________________^ help: try this: `if let Err(e) = Self::exec_nodes(state, nodes) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/brainfuck.rs:375:24 [INFO] [stderr] | [INFO] [stderr] 375 | let epilogue = format!(" [INFO] [stderr] | ________________________^ [INFO] [stderr] 376 | | \tret i32 0 [INFO] [stderr] 377 | | }}"); [INFO] [stderr] | |____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 375 | let epilogue = " [INFO] [stderr] 376 | \tret i32 0 [INFO] [stderr] 377 | }}".to_string(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/brainfuck.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | / match node { [INFO] [stderr] 385 | | &Node::IncPtr(v, _) => { [INFO] [stderr] 386 | | let i0 = state.ident(); [INFO] [stderr] 387 | | let i1 = state.ident(); [INFO] [stderr] ... | [INFO] [stderr] 485 | | }, [INFO] [stderr] 486 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 384 | match *node { [INFO] [stderr] 385 | Node::IncPtr(v, _) => { [INFO] [stderr] 386 | let i0 = state.ident(); [INFO] [stderr] 387 | let i1 = state.ident(); [INFO] [stderr] 388 | let r = format!(" [INFO] [stderr] 389 | \t{ptr} = load i32* %ptr [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.51s [INFO] running `"docker" "inspect" "bb53df295e0008369c6506173c61c5b096f608516c32dbe4b745e9925f06db64"` [INFO] running `"docker" "rm" "-f" "bb53df295e0008369c6506173c61c5b096f608516c32dbe4b745e9925f06db64"` [INFO] [stdout] bb53df295e0008369c6506173c61c5b096f608516c32dbe4b745e9925f06db64