[INFO] updating cached repository nickmass/boomshine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nickmass/boomshine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/boomshine" "work/ex/clippy-test-run/sources/stable/gh/nickmass/boomshine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickmass/boomshine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nickmass/boomshine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/boomshine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/boomshine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 887ca02a4810ac63d0805cddfd64edce263164a7 [INFO] sha for GitHub repo nickmass/boomshine: 887ca02a4810ac63d0805cddfd64edce263164a7 [INFO] validating manifest of nickmass/boomshine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickmass/boomshine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickmass/boomshine [INFO] finished frobbing nickmass/boomshine [INFO] frobbed toml for nickmass/boomshine written to work/ex/clippy-test-run/sources/stable/gh/nickmass/boomshine/Cargo.toml [INFO] started frobbing nickmass/boomshine [INFO] finished frobbing nickmass/boomshine [INFO] frobbed toml for nickmass/boomshine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickmass/boomshine/Cargo.toml [INFO] crate nickmass/boomshine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickmass/boomshine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nickmass/boomshine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba903ba50aeedf144e84a3be1791ae71fb18d757bcc6b7636e7ca59f7f6abd3c [INFO] running `"docker" "start" "-a" "ba903ba50aeedf144e84a3be1791ae71fb18d757bcc6b7636e7ca59f7f6abd3c"` [INFO] [stderr] Compiling libc v0.2.18 [INFO] [stderr] Compiling phf_shared v0.7.20 [INFO] [stderr] Compiling serde v0.8.19 [INFO] [stderr] Compiling xml-rs v0.3.5 [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking clap v2.19.1 [INFO] [stderr] Compiling phf v0.7.20 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking x11-dl v2.11.0 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.4 [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Checking memmap v0.2.3 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling wayland-scanner v0.5.11 [INFO] [stderr] Compiling gl_generator v0.5.2 [INFO] [stderr] Compiling phf_generator v0.7.20 [INFO] [stderr] Compiling phf_codegen v0.7.20 [INFO] [stderr] Compiling target_build_utils v0.1.2 [INFO] [stderr] Compiling wayland-client v0.5.12 [INFO] [stderr] Compiling glutin v0.6.2 [INFO] [stderr] Compiling glium v0.15.0 [INFO] [stderr] Compiling serde_json v0.8.3 [INFO] [stderr] Compiling libloading v0.3.1 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.5.11 [INFO] [stderr] Checking wayland-window v0.2.3 [INFO] [stderr] Checking wayland-kbd v0.3.6 [INFO] [stderr] Checking boomshine v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:15 [INFO] [stderr] | [INFO] [stderr] 107 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:15 [INFO] [stderr] | [INFO] [stderr] 107 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:107:21 [INFO] [stderr] | [INFO] [stderr] 107 | Vector2 { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:232:13 [INFO] [stderr] | [INFO] [stderr] 232 | bounds: bounds, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:233:13 [INFO] [stderr] | [INFO] [stderr] 233 | center: center, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | display: display, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `display` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:406:13 [INFO] [stderr] | [INFO] [stderr] 406 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:209:35 [INFO] [stderr] | [INFO] [stderr] 209 | let sub = rng().gen_range(0x1000000, 0x3000000) << 8; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:209:46 [INFO] [stderr] | [INFO] [stderr] 209 | let sub = rng().gen_range(0x1000000, 0x3000000) << 8; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | let color = 0xffffff9f_u32 - sub; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ff9f_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:209:35 [INFO] [stderr] | [INFO] [stderr] 209 | let sub = rng().gen_range(0x1000000, 0x3000000) << 8; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:209:46 [INFO] [stderr] | [INFO] [stderr] 209 | let sub = rng().gen_range(0x1000000, 0x3000000) << 8; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:210:21 [INFO] [stderr] | [INFO] [stderr] 210 | let color = 0xffffff9f_u32 - sub; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ff9f_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | let nanos = elapased.subsec_nanos() as f64 / 1_000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapased.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if self.targets.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.targets.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if killers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!killers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `color` [INFO] [stderr] --> src/main.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let a = (color >> 0 & 0xff) as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | self.color.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:311:51 [INFO] [stderr] | [INFO] [stderr] 311 | let step = (2.0 * std::f64::consts::PI) / tri_count as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(tri_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:313:18 [INFO] [stderr] | [INFO] [stderr] 313 | for _ in 0..tri_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=tri_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:360:25 [INFO] [stderr] | [INFO] [stderr] 360 | .with_title(format!("Boomshine")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Boomshine".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:419:44 [INFO] [stderr] | [INFO] [stderr] 419 | self.mouse_position = (x as f64 / dims.0 as f64, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:419:55 [INFO] [stderr] | [INFO] [stderr] 419 | self.mouse_position = (x as f64 / dims.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dims.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:420:44 [INFO] [stderr] | [INFO] [stderr] 420 | (dims.1 as i32 - y) as f64 / dims.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dims.1 as i32 - y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:420:73 [INFO] [stderr] | [INFO] [stderr] 420 | (dims.1 as i32 - y) as f64 / dims.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dims.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:442:18 [INFO] [stderr] | [INFO] [stderr] 442 | .or_insert(VertexBuffer::new(&self.display, &M::model()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| VertexBuffer::new(&self.display, &M::model()).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:29 [INFO] [stderr] | [INFO] [stderr] 49 | let nanos = elapased.subsec_nanos() as f64 / 1_000_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapased.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:59:12 [INFO] [stderr] | [INFO] [stderr] 59 | if self.targets.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.targets.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | if killers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!killers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `color` [INFO] [stderr] --> src/main.rs:214:18 [INFO] [stderr] | [INFO] [stderr] 214 | let a = (color >> 0 & 0xff) as f32 / 255.0; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | self.color.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:311:51 [INFO] [stderr] | [INFO] [stderr] 311 | let step = (2.0 * std::f64::consts::PI) / tri_count as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(tri_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:313:18 [INFO] [stderr] | [INFO] [stderr] 313 | for _ in 0..tri_count + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=tri_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:360:25 [INFO] [stderr] | [INFO] [stderr] 360 | .with_title(format!("Boomshine")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Boomshine".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:419:44 [INFO] [stderr] | [INFO] [stderr] 419 | self.mouse_position = (x as f64 / dims.0 as f64, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:419:55 [INFO] [stderr] | [INFO] [stderr] 419 | self.mouse_position = (x as f64 / dims.0 as f64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dims.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:420:44 [INFO] [stderr] | [INFO] [stderr] 420 | (dims.1 as i32 - y) as f64 / dims.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dims.1 as i32 - y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:420:73 [INFO] [stderr] | [INFO] [stderr] 420 | (dims.1 as i32 - y) as f64 / dims.1 as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(dims.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:442:18 [INFO] [stderr] | [INFO] [stderr] 442 | .or_insert(VertexBuffer::new(&self.display, &M::model()).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| VertexBuffer::new(&self.display, &M::model()).unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "ba903ba50aeedf144e84a3be1791ae71fb18d757bcc6b7636e7ca59f7f6abd3c"` [INFO] running `"docker" "rm" "-f" "ba903ba50aeedf144e84a3be1791ae71fb18d757bcc6b7636e7ca59f7f6abd3c"` [INFO] [stdout] ba903ba50aeedf144e84a3be1791ae71fb18d757bcc6b7636e7ca59f7f6abd3c