[INFO] updating cached repository nicklauri/bfi
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nicklauri/bfi
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nicklauri/bfi" "work/ex/clippy-test-run/sources/stable/gh/nicklauri/bfi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nicklauri/bfi'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nicklauri/bfi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicklauri/bfi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicklauri/bfi'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 61db1b894217159a6c049c414951420c40d56a36
[INFO] sha for GitHub repo nicklauri/bfi: 61db1b894217159a6c049c414951420c40d56a36
[INFO] validating manifest of nicklauri/bfi on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nicklauri/bfi on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nicklauri/bfi
[INFO] finished frobbing nicklauri/bfi
[INFO] frobbed toml for nicklauri/bfi written to work/ex/clippy-test-run/sources/stable/gh/nicklauri/bfi/Cargo.toml
[INFO] started frobbing nicklauri/bfi
[INFO] finished frobbing nicklauri/bfi
[INFO] frobbed toml for nicklauri/bfi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nicklauri/bfi/Cargo.toml
[INFO] crate nicklauri/bfi has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nicklauri/bfi against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nicklauri/bfi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2861d8950bddeb7ddaaad00580b2d6cbd1aa77ae247f57144b510aefb61db0c9
[INFO] running `"docker" "start" "-a" "2861d8950bddeb7ddaaad00580b2d6cbd1aa77ae247f57144b510aefb61db0c9"`
[INFO] [stderr]     Checking bfi v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:3
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return step - (max_cells - current_cell);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `step - (max_cells - current_cell)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:38:3
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return current_cell + step;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_cell + step`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:44:3
[INFO] [stderr]    |
[INFO] [stderr] 44 |         return max_cells + 1 - (step - current_cell);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_cells + 1 - (step - current_cell)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:47:3
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return current_cell - step;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_cell - step`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:26:10
[INFO] [stderr]    |
[INFO] [stderr] 26 |     *var = (*var as u32 + value) as u8;
[INFO] [stderr]    |             ^^^^^^^^^^^ help: try: `u32::from(*var)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:10
[INFO] [stderr]    |
[INFO] [stderr] 30 |     *var = (*var as i64 - value as i64) as u8;
[INFO] [stderr]    |             ^^^^^^^^^^^ help: try: `i64::from(*var)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |     *var = (*var as i64 - value as i64) as u8;
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `i64::from(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     if current_cell as u64 + step as u64 >= max_cells as u64 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(current_cell)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:34:27
[INFO] [stderr]    |
[INFO] [stderr] 34 |     if current_cell as u64 + step as u64 >= max_cells as u64 {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: try: `u64::from(step)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:34:42
[INFO] [stderr]    |
[INFO] [stderr] 34 |     if current_cell as u64 + step as u64 >= max_cells as u64 {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: try: `u64::from(max_cells)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:53:6
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 .expect(format!("error: file `{}` not found!\n", filename).as_str());
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error: file `{}` not found!\n", filename))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 |                   stdout.write(iter::repeat(pointers[current_cell] as char)
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 182 | |                     .take(code[offset][1] as usize)
[INFO] [stderr] 183 | |                     .collect::<String>().as_bytes()).expect("bfi-runtime: system error");
[INFO] [stderr]     | |________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/main.rs:231:8
[INFO] [stderr]     |
[INFO] [stderr] 231 |           else {
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 232 | |             help();
[INFO] [stderr] 233 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/main.rs:228:16
[INFO] [stderr]     |
[INFO] [stderr] 228 |           if h == "-h" {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 229 | |             help();
[INFO] [stderr] 230 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `bfi`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:3
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return step - (max_cells - current_cell);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `step - (max_cells - current_cell)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:38:3
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return current_cell + step;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_cell + step`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:44:3
[INFO] [stderr]    |
[INFO] [stderr] 44 |         return max_cells + 1 - (step - current_cell);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `max_cells + 1 - (step - current_cell)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:47:3
[INFO] [stderr]    |
[INFO] [stderr] 47 |         return current_cell - step;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `current_cell - step`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:26:10
[INFO] [stderr]    |
[INFO] [stderr] 26 |     *var = (*var as u32 + value) as u8;
[INFO] [stderr]    |             ^^^^^^^^^^^ help: try: `u32::from(*var)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:10
[INFO] [stderr]    |
[INFO] [stderr] 30 |     *var = (*var as i64 - value as i64) as u8;
[INFO] [stderr]    |             ^^^^^^^^^^^ help: try: `i64::from(*var)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:24
[INFO] [stderr]    |
[INFO] [stderr] 30 |     *var = (*var as i64 - value as i64) as u8;
[INFO] [stderr]    |                           ^^^^^^^^^^^^ help: try: `i64::from(value)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:34:5
[INFO] [stderr]    |
[INFO] [stderr] 34 |     if current_cell as u64 + step as u64 >= max_cells as u64 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(current_cell)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:34:27
[INFO] [stderr]    |
[INFO] [stderr] 34 |     if current_cell as u64 + step as u64 >= max_cells as u64 {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: try: `u64::from(step)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:34:42
[INFO] [stderr]    |
[INFO] [stderr] 34 |     if current_cell as u64 + step as u64 >= max_cells as u64 {
[INFO] [stderr]    |                                             ^^^^^^^^^^^^^^^^ help: try: `u64::from(max_cells)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:53:6
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 .expect(format!("error: file `{}` not found!\n", filename).as_str());
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error: file `{}` not found!\n", filename))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/main.rs:181:5
[INFO] [stderr]     |
[INFO] [stderr] 181 |                   stdout.write(iter::repeat(pointers[current_cell] as char)
[INFO] [stderr]     |  _________________^
[INFO] [stderr] 182 | |                     .take(code[offset][1] as usize)
[INFO] [stderr] 183 | |                     .collect::<String>().as_bytes()).expect("bfi-runtime: system error");
[INFO] [stderr]     | |________________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/main.rs:231:8
[INFO] [stderr]     |
[INFO] [stderr] 231 |           else {
[INFO] [stderr]     |  ______________^
[INFO] [stderr] 232 | |             help();
[INFO] [stderr] 233 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/main.rs:228:16
[INFO] [stderr]     |
[INFO] [stderr] 228 |           if h == "-h" {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 229 | |             help();
[INFO] [stderr] 230 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `bfi`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "2861d8950bddeb7ddaaad00580b2d6cbd1aa77ae247f57144b510aefb61db0c9"`
[INFO] running `"docker" "rm" "-f" "2861d8950bddeb7ddaaad00580b2d6cbd1aa77ae247f57144b510aefb61db0c9"`
[INFO] [stdout] 2861d8950bddeb7ddaaad00580b2d6cbd1aa77ae247f57144b510aefb61db0c9