[INFO] updating cached repository nickbrowne/sharejs-clobber [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nickbrowne/sharejs-clobber [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nickbrowne/sharejs-clobber" "work/ex/clippy-test-run/sources/stable/gh/nickbrowne/sharejs-clobber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nickbrowne/sharejs-clobber'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nickbrowne/sharejs-clobber" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickbrowne/sharejs-clobber"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickbrowne/sharejs-clobber'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2cf9d8a5f965b5d0b981d18902e7d322812649ff [INFO] sha for GitHub repo nickbrowne/sharejs-clobber: 2cf9d8a5f965b5d0b981d18902e7d322812649ff [INFO] validating manifest of nickbrowne/sharejs-clobber on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nickbrowne/sharejs-clobber on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nickbrowne/sharejs-clobber [INFO] finished frobbing nickbrowne/sharejs-clobber [INFO] frobbed toml for nickbrowne/sharejs-clobber written to work/ex/clippy-test-run/sources/stable/gh/nickbrowne/sharejs-clobber/Cargo.toml [INFO] started frobbing nickbrowne/sharejs-clobber [INFO] finished frobbing nickbrowne/sharejs-clobber [INFO] frobbed toml for nickbrowne/sharejs-clobber written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nickbrowne/sharejs-clobber/Cargo.toml [INFO] crate nickbrowne/sharejs-clobber has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nickbrowne/sharejs-clobber against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nickbrowne/sharejs-clobber:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d93f73ecb0fe881badabb2193c7ca827bf287a92a710bb4c7b3149b7bb3cf989 [INFO] running `"docker" "start" "-a" "d93f73ecb0fe881badabb2193c7ca827bf287a92a710bb4c7b3149b7bb3cf989"` [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.5 [INFO] [stderr] Checking socket2 v0.3.7 [INFO] [stderr] Checking curl v0.4.12 [INFO] [stderr] Checking sharejs-clobber v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/doc.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | easy.url(&url).expect(&format!("Possible bad url: {:?}", url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Possible bad url: {:?}", url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/doc.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | easy.url(&url).expect(&format!("Possible bad url: {:?}", url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Possible bad url: {:?}", url))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/doc.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | easy.url(&url).expect(&format!("Possible bad url: {:?}", url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Possible bad url: {:?}", url))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | let document_uids: Vec = (0..CONCURRENCY).into_iter().map(|_| random_alpha()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..CONCURRENCY)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/doc.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | easy.url(&url).expect(&format!("Possible bad url: {:?}", url)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Possible bad url: {:?}", url))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | while let Some(result) = rx_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `for result in rx_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | requests = requests + result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `requests += result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | let rps = requests as f64 / elapsed_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(requests)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:21:36 [INFO] [stderr] | [INFO] [stderr] 21 | let document_uids: Vec = (0..CONCURRENCY).into_iter().map(|_| random_alpha()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..CONCURRENCY)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/main.rs:50:28 [INFO] [stderr] | [INFO] [stderr] 50 | while let Some(result) = rx_iter.next() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `for result in rx_iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | requests = requests + result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `requests += result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:56:15 [INFO] [stderr] | [INFO] [stderr] 56 | let rps = requests as f64 / elapsed_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(requests)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 20s [INFO] running `"docker" "inspect" "d93f73ecb0fe881badabb2193c7ca827bf287a92a710bb4c7b3149b7bb3cf989"` [INFO] running `"docker" "rm" "-f" "d93f73ecb0fe881badabb2193c7ca827bf287a92a710bb4c7b3149b7bb3cf989"` [INFO] [stdout] d93f73ecb0fe881badabb2193c7ca827bf287a92a710bb4c7b3149b7bb3cf989