[INFO] updating cached repository nichuguen/casper-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nichuguen/casper-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nichuguen/casper-rust" "work/ex/clippy-test-run/sources/stable/gh/nichuguen/casper-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nichuguen/casper-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nichuguen/casper-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nichuguen/casper-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nichuguen/casper-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5f6bcd4cf4225dc43aa2b97bd72c3805301cb03a
[INFO] sha for GitHub repo nichuguen/casper-rust: 5f6bcd4cf4225dc43aa2b97bd72c3805301cb03a
[INFO] validating manifest of nichuguen/casper-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nichuguen/casper-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nichuguen/casper-rust
[INFO] finished frobbing nichuguen/casper-rust
[INFO] frobbed toml for nichuguen/casper-rust written to work/ex/clippy-test-run/sources/stable/gh/nichuguen/casper-rust/Cargo.toml
[INFO] started frobbing nichuguen/casper-rust
[INFO] finished frobbing nichuguen/casper-rust
[INFO] frobbed toml for nichuguen/casper-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nichuguen/casper-rust/Cargo.toml
[INFO] crate nichuguen/casper-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nichuguen/casper-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nichuguen/casper-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 99f43b56516a2e71983c2014f5987a172d62984037b792bd9fdc4409b5ef37a0
[INFO] running `"docker" "start" "-a" "99f43b56516a2e71983c2014f5987a172d62984037b792bd9fdc4409b5ef37a0"`
[INFO] [stderr]     Checking tl_casper v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:185:21
[INFO] [stderr]     |
[INFO] [stderr] 185 |                     return a.0.id.cmp(&b.0.id);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.0.id.cmp(&b.0.id)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:187:21
[INFO] [stderr]     |
[INFO] [stderr] 187 |                     return b.1.partial_cmp(&a.1).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `b.1.partial_cmp(&a.1).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:185:21
[INFO] [stderr]     |
[INFO] [stderr] 185 |                     return a.0.id.cmp(&b.0.id);
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `a.0.id.cmp(&b.0.id)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:187:21
[INFO] [stderr]     |
[INFO] [stderr] 187 |                     return b.1.partial_cmp(&a.1).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `b.1.partial_cmp(&a.1).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:84:45
[INFO] [stderr]    |
[INFO] [stderr] 84 |                         .field("estimate", &format!("-"))
[INFO] [stderr]    |                                             ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/lib.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 | /         loop{
[INFO] [stderr] 105 | |             match current_message {
[INFO] [stderr] 106 | |                 Some(m) => {
[INFO] [stderr] 107 | |                     if m.id == block.id{
[INFO] [stderr] ...   |
[INFO] [stderr] 117 | |             }
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(m) = current_message { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:145:12
[INFO] [stderr]     |
[INFO] [stderr] 145 |         if latest_messages.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!latest_messages.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/lib.rs:184:20
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 if a.1 == b.1{
[INFO] [stderr]     |                    ^^^^^^^^^^ help: consider comparing them within some error: `(a.1 - b.1).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/lib.rs:184:20
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 if a.1 == b.1{
[INFO] [stderr]     |                    ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:192:12
[INFO] [stderr]     |
[INFO] [stderr] 192 |         if sorted_by_score_and_hash.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sorted_by_score_and_hash.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tl_casper`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/lib.rs:84:45
[INFO] [stderr]    |
[INFO] [stderr] 84 |                         .field("estimate", &format!("-"))
[INFO] [stderr]    |                                             ^^^^^^^^^^^^ help: consider using .to_string(): `"-".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/lib.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 | /         loop{
[INFO] [stderr] 105 | |             match current_message {
[INFO] [stderr] 106 | |                 Some(m) => {
[INFO] [stderr] 107 | |                     if m.id == block.id{
[INFO] [stderr] ...   |
[INFO] [stderr] 117 | |             }
[INFO] [stderr] 118 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(m) = current_message { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:145:12
[INFO] [stderr]     |
[INFO] [stderr] 145 |         if latest_messages.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!latest_messages.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/lib.rs:184:20
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 if a.1 == b.1{
[INFO] [stderr]     |                    ^^^^^^^^^^ help: consider comparing them within some error: `(a.1 - b.1).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/lib.rs:184:20
[INFO] [stderr]     |
[INFO] [stderr] 184 |                 if a.1 == b.1{
[INFO] [stderr]     |                    ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:192:12
[INFO] [stderr]     |
[INFO] [stderr] 192 |         if sorted_by_score_and_hash.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!sorted_by_score_and_hash.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `tl_casper`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "99f43b56516a2e71983c2014f5987a172d62984037b792bd9fdc4409b5ef37a0"`
[INFO] running `"docker" "rm" "-f" "99f43b56516a2e71983c2014f5987a172d62984037b792bd9fdc4409b5ef37a0"`
[INFO] [stdout] 99f43b56516a2e71983c2014f5987a172d62984037b792bd9fdc4409b5ef37a0