[INFO] updating cached repository nical/backup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nical/backup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nical/backup" "work/ex/clippy-test-run/sources/stable/gh/nical/backup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nical/backup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nical/backup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nical/backup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nical/backup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fb625a9df257835a52edc37eb8e6e9b9adeaf01b [INFO] sha for GitHub repo nical/backup: fb625a9df257835a52edc37eb8e6e9b9adeaf01b [INFO] validating manifest of nical/backup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nical/backup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nical/backup [INFO] finished frobbing nical/backup [INFO] frobbed toml for nical/backup written to work/ex/clippy-test-run/sources/stable/gh/nical/backup/Cargo.toml [INFO] started frobbing nical/backup [INFO] finished frobbing nical/backup [INFO] frobbed toml for nical/backup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nical/backup/Cargo.toml [INFO] crate nical/backup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting nical/backup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nical/backup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08264b5f1f96ea8d4a1ff0141cac6a7ee3a39868284d9999409911832904ae31 [INFO] running `"docker" "start" "-a" "08264b5f1f96ea8d4a1ff0141cac6a7ee3a39868284d9999409911832904ae31"` [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking clap v2.31.1 [INFO] [stderr] Compiling serde_derive_internals v0.21.0 [INFO] [stderr] Compiling serde_derive v1.0.33 [INFO] [stderr] Checking backup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / if let Some(mut config_file) = File::open(format!("{}/.backup.toml", src_dir)).ok() { [INFO] [stderr] 108 | | if verbose { [INFO] [stderr] 109 | | println!(" ** Found config file at {}/.backup.toml", src_dir); [INFO] [stderr] 110 | | } [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut config_file)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | / if let Some(mut config_file) = File::create(path.clone()).ok() { [INFO] [stderr] 298 | | writeln!(config_file, "server = \"{}\"", address)?; [INFO] [stderr] 299 | | writeln!(config_file, "port = \"{}\"", port)?; [INFO] [stderr] 300 | | writeln!(config_file, "user = \"{}\"", user)?; [INFO] [stderr] ... | [INFO] [stderr] 316 | | println!("Created configuration file at {}", path); [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut config_file)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | / if let Some(mut config_file) = File::open(format!("{}/.backup.toml", src_dir)).ok() { [INFO] [stderr] 108 | | if verbose { [INFO] [stderr] 109 | | println!(" ** Found config file at {}/.backup.toml", src_dir); [INFO] [stderr] 110 | | } [INFO] [stderr] ... | [INFO] [stderr] 130 | | } [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(mut config_file)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/main.rs:297:5 [INFO] [stderr] | [INFO] [stderr] 297 | / if let Some(mut config_file) = File::create(path.clone()).ok() { [INFO] [stderr] 298 | | writeln!(config_file, "server = \"{}\"", address)?; [INFO] [stderr] 299 | | writeln!(config_file, "port = \"{}\"", port)?; [INFO] [stderr] 300 | | writeln!(config_file, "user = \"{}\"", user)?; [INFO] [stderr] ... | [INFO] [stderr] 316 | | println!("Created configuration file at {}", path); [INFO] [stderr] 317 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: Consider matching on `Ok(mut config_file)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.41s [INFO] running `"docker" "inspect" "08264b5f1f96ea8d4a1ff0141cac6a7ee3a39868284d9999409911832904ae31"` [INFO] running `"docker" "rm" "-f" "08264b5f1f96ea8d4a1ff0141cac6a7ee3a39868284d9999409911832904ae31"` [INFO] [stdout] 08264b5f1f96ea8d4a1ff0141cac6a7ee3a39868284d9999409911832904ae31