[INFO] updating cached repository nharward/nom-gzip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nharward/nom-gzip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nharward/nom-gzip" "work/ex/clippy-test-run/sources/stable/gh/nharward/nom-gzip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nharward/nom-gzip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nharward/nom-gzip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nharward/nom-gzip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nharward/nom-gzip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 180b3161e90a262cd24a9b87c617556c6f371b29 [INFO] sha for GitHub repo nharward/nom-gzip: 180b3161e90a262cd24a9b87c617556c6f371b29 [INFO] validating manifest of nharward/nom-gzip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nharward/nom-gzip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nharward/nom-gzip [INFO] finished frobbing nharward/nom-gzip [INFO] frobbed toml for nharward/nom-gzip written to work/ex/clippy-test-run/sources/stable/gh/nharward/nom-gzip/Cargo.toml [INFO] started frobbing nharward/nom-gzip [INFO] finished frobbing nharward/nom-gzip [INFO] frobbed toml for nharward/nom-gzip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nharward/nom-gzip/Cargo.toml [INFO] crate nharward/nom-gzip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nharward/nom-gzip against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nharward/nom-gzip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 234b34d5dbb7bfb6c0640d8409a61bd5a56a1d1726a43b33673ae7ff89507720 [INFO] running `"docker" "start" "-a" "234b34d5dbb7bfb6c0640d8409a61bd5a56a1d1726a43b33673ae7ff89507720"` [INFO] [stderr] Checking libc v0.2.29 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking nom v3.2.0 [INFO] [stderr] Checking nom-gzip v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:38 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] ... [INFO] [stderr] 310 | test_u32!(footer_crc32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:50 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 310 | test_u32!(footer_crc32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:62 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_ff00` [INFO] [stderr] ... [INFO] [stderr] 310 | test_u32!(footer_crc32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:74 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_00ff` [INFO] [stderr] ... [INFO] [stderr] 310 | test_u32!(footer_crc32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:86 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0123_4567` [INFO] [stderr] ... [INFO] [stderr] 310 | test_u32!(footer_crc32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:98 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x89ab_cdef` [INFO] [stderr] ... [INFO] [stderr] 310 | test_u32!(footer_crc32); [INFO] [stderr] | ------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:38 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] ... [INFO] [stderr] 315 | test_u32!(input_size); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:50 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 315 | test_u32!(input_size); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:62 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xff00_ff00` [INFO] [stderr] ... [INFO] [stderr] 315 | test_u32!(input_size); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:74 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_00ff` [INFO] [stderr] ... [INFO] [stderr] 315 | test_u32!(input_size); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:86 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0123_4567` [INFO] [stderr] ... [INFO] [stderr] 315 | test_u32!(input_size); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:129:98 [INFO] [stderr] | [INFO] [stderr] 129 | let samples: [u32; 6] = [0x00000000, 0xffffffff, 0xff00ff00, 0x00ff00ff, 0x01234567, 0x89abcdef]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x89ab_cdef` [INFO] [stderr] ... [INFO] [stderr] 315 | test_u32!(input_size); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:19:96 [INFO] [stderr] | [INFO] [stderr] 19 | named!(modified_time_as_secs_since_epoch, map!(u32!(Little), |t| Duration::from_secs(t as u64))); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:81:74 [INFO] [stderr] | [INFO] [stderr] 81 | GzipFile { header, footer: tup.1, compressed_blocks: tup.0.iter().map(|b| *b).collect() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tup.0.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:19:96 [INFO] [stderr] | [INFO] [stderr] 19 | named!(modified_time_as_secs_since_epoch, map!(u32!(Little), |t| Duration::from_secs(t as u64))); [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(t)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:81:74 [INFO] [stderr] | [INFO] [stderr] 81 | GzipFile { header, footer: tup.1, compressed_blocks: tup.0.iter().map(|b| *b).collect() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tup.0.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:240:18 [INFO] [stderr] | [INFO] [stderr] 240 | id1: 'c' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:241:18 [INFO] [stderr] | [INFO] [stderr] 241 | id2: 'p' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'p' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:261:26 [INFO] [stderr] | [INFO] [stderr] 261 | id1: 'c' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:262:26 [INFO] [stderr] | [INFO] [stderr] 262 | id2: 'p' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'p' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:266:26 [INFO] [stderr] | [INFO] [stderr] 266 | id1: 'A' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:267:26 [INFO] [stderr] | [INFO] [stderr] 267 | id2: 'c' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'c' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:271:26 [INFO] [stderr] | [INFO] [stderr] 271 | id1: 'K' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'K' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/lib.rs:272:26 [INFO] [stderr] | [INFO] [stderr] 272 | id2: 'N' as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'N' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/integration_test.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | const SAMPLE_GZIP_FILE: &'static [u8] = include_bytes!("sample.txt.gz"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:20:68 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(header.modified_time_as_secs_since_epoch.as_secs(), 0x599e86e7); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x599e_86e7` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:30:28 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(footer.crc, 0xbd47c3dc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbd47_c3dc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/integration_test.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | assert_eq!(footer.input_size, 0x0000738f); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_738f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.94s [INFO] running `"docker" "inspect" "234b34d5dbb7bfb6c0640d8409a61bd5a56a1d1726a43b33673ae7ff89507720"` [INFO] running `"docker" "rm" "-f" "234b34d5dbb7bfb6c0640d8409a61bd5a56a1d1726a43b33673ae7ff89507720"` [INFO] [stdout] 234b34d5dbb7bfb6c0640d8409a61bd5a56a1d1726a43b33673ae7ff89507720