[INFO] updating cached repository ngc0202/EnigmaMachine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ngc0202/EnigmaMachine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ngc0202/EnigmaMachine" "work/ex/clippy-test-run/sources/stable/gh/ngc0202/EnigmaMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ngc0202/EnigmaMachine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ngc0202/EnigmaMachine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ngc0202/EnigmaMachine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ngc0202/EnigmaMachine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9eec290711e19c7923d923d4bf5ee51bd54b7c52 [INFO] sha for GitHub repo ngc0202/EnigmaMachine: 9eec290711e19c7923d923d4bf5ee51bd54b7c52 [INFO] validating manifest of ngc0202/EnigmaMachine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ngc0202/EnigmaMachine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ngc0202/EnigmaMachine [INFO] finished frobbing ngc0202/EnigmaMachine [INFO] frobbed toml for ngc0202/EnigmaMachine written to work/ex/clippy-test-run/sources/stable/gh/ngc0202/EnigmaMachine/Cargo.toml [INFO] started frobbing ngc0202/EnigmaMachine [INFO] finished frobbing ngc0202/EnigmaMachine [INFO] frobbed toml for ngc0202/EnigmaMachine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ngc0202/EnigmaMachine/Cargo.toml [INFO] crate ngc0202/EnigmaMachine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ngc0202/EnigmaMachine against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ngc0202/EnigmaMachine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b944dfd4951861e09b24daa8468ed0446b9053fbcd07da9ac0ce521889107aa6 [INFO] running `"docker" "start" "-a" "b944dfd4951861e09b24daa8468ed0446b9053fbcd07da9ac0ce521889107aa6"` [INFO] [stderr] Checking enigma v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `j` is used to index `REF_ROTOR` [INFO] [stderr] --> src/main.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | for j in 0..26 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for (j, ) in REF_ROTOR.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:112:15 [INFO] [stderr] | [INFO] [stderr] 112 | for j in 0..26 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `self.data[0][..26].clone_from_slice(&self.data[i][..26])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `a` [INFO] [stderr] --> src/main.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | for idx in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 212 | for (idx, ) in a.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `REF_ROTOR` [INFO] [stderr] --> src/main.rs:92:12 [INFO] [stderr] | [INFO] [stderr] 92 | for j in 0..26 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for (j, ) in REF_ROTOR.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:112:15 [INFO] [stderr] | [INFO] [stderr] 112 | for j in 0..26 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `self.data[0][..26].clone_from_slice(&self.data[i][..26])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `a` [INFO] [stderr] --> src/main.rs:212:14 [INFO] [stderr] | [INFO] [stderr] 212 | for idx in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 212 | for (idx, ) in a.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "b944dfd4951861e09b24daa8468ed0446b9053fbcd07da9ac0ce521889107aa6"` [INFO] running `"docker" "rm" "-f" "b944dfd4951861e09b24daa8468ed0446b9053fbcd07da9ac0ce521889107aa6"` [INFO] [stdout] b944dfd4951861e09b24daa8468ed0446b9053fbcd07da9ac0ce521889107aa6