[INFO] updating cached repository next-dev/nxr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/next-dev/nxr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/next-dev/nxr" "work/ex/clippy-test-run/sources/stable/gh/next-dev/nxr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/next-dev/nxr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/next-dev/nxr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/next-dev/nxr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/next-dev/nxr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bbcb36ea14069532faff7ad1ab9f6d1a7cfa50c6 [INFO] sha for GitHub repo next-dev/nxr: bbcb36ea14069532faff7ad1ab9f6d1a7cfa50c6 [INFO] validating manifest of next-dev/nxr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of next-dev/nxr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing next-dev/nxr [INFO] finished frobbing next-dev/nxr [INFO] frobbed toml for next-dev/nxr written to work/ex/clippy-test-run/sources/stable/gh/next-dev/nxr/Cargo.toml [INFO] started frobbing next-dev/nxr [INFO] finished frobbing next-dev/nxr [INFO] frobbed toml for next-dev/nxr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/next-dev/nxr/Cargo.toml [INFO] crate next-dev/nxr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting next-dev/nxr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/next-dev/nxr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f375d54c2cf2e8e908b8e2a1a71558cca111833a98a1a4ccfa1b4ad0595231e6 [INFO] running `"docker" "start" "-a" "f375d54c2cf2e8e908b8e2a1a71558cca111833a98a1a4ccfa1b4ad0595231e6"` [INFO] [stderr] Compiling bitflags v1.0.2 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling x11-dl v2.17.5 [INFO] [stderr] Compiling log v0.4.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Compiling num-derive v0.2.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Compiling wayland-scanner v0.12.5 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Compiling wayland-client v0.12.5 [INFO] [stderr] Compiling wayland-protocols v0.12.5 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.46.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking piston_window v0.79.0 [INFO] [stderr] Checking nxr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | Spectrum { memory: memory } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/spectrum.rs:29:20 [INFO] [stderr] | [INFO] [stderr] 29 | Spectrum { memory: memory } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `memory` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/nx.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #![cfg_attr(feature = "cargo-clippy", warn(needless_lifetimes))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/nx.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #![cfg_attr(feature = "cargo-clippy", warn(needless_lifetimes))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/nx.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #![cfg_attr(feature = "cargo-clippy", warn(needless_lifetimes))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_lifetimes` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/nx.rs:15:44 [INFO] [stderr] | [INFO] [stderr] 15 | #![cfg_attr(feature = "cargo-clippy", warn(needless_lifetimes))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_lifetimes` [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/memory.rs:63:14 [INFO] [stderr] | [INFO] [stderr] 63 | fn peek(mem: &Vec, addr: Address) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/memory.rs:63:14 [INFO] [stderr] | [INFO] [stderr] 63 | fn peek(mem: &Vec, addr: Address) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 14s [INFO] running `"docker" "inspect" "f375d54c2cf2e8e908b8e2a1a71558cca111833a98a1a4ccfa1b4ad0595231e6"` [INFO] running `"docker" "rm" "-f" "f375d54c2cf2e8e908b8e2a1a71558cca111833a98a1a4ccfa1b4ad0595231e6"` [INFO] [stdout] f375d54c2cf2e8e908b8e2a1a71558cca111833a98a1a4ccfa1b4ad0595231e6