[INFO] updating cached repository neosmart/tac
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/neosmart/tac
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/tac" "work/ex/clippy-test-run/sources/stable/gh/neosmart/tac"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neosmart/tac'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/tac" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/tac"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/tac'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 0a8ff09e84e9d9eccbf164b914f17f39e397a312
[INFO] sha for GitHub repo neosmart/tac: 0a8ff09e84e9d9eccbf164b914f17f39e397a312
[INFO] validating manifest of neosmart/tac on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of neosmart/tac on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing neosmart/tac
[INFO] finished frobbing neosmart/tac
[INFO] frobbed toml for neosmart/tac written to work/ex/clippy-test-run/sources/stable/gh/neosmart/tac/Cargo.toml
[INFO] started frobbing neosmart/tac
[INFO] finished frobbing neosmart/tac
[INFO] frobbed toml for neosmart/tac written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/tac/Cargo.toml
[INFO] crate neosmart/tac has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting neosmart/tac against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/neosmart/tac:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3519f4125cd56ff399de1e121fb5254420c3e38c303c63e2b88c5d722804a5de
[INFO] running `"docker" "start" "-a" "3519f4125cd56ff399de1e121fb5254420c3e38c303c63e2b88c5d722804a5de"`
[INFO] [stderr]     Checking memmap v0.5.2
[INFO] [stderr]     Checking uuid v0.4.0
[INFO] [stderr]     Checking tac v0.2.3 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:17:5
[INFO] [stderr]    |
[INFO] [stderr] 17 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:154:5
[INFO] [stderr]     |
[INFO] [stderr] 154 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:64:16
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn print_bytes(mut stdout: &mut Stdout, bytes: &[u8]) {
[INFO] [stderr]    |                ----^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:41:37
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 if file.starts_with("-") && file != "-" {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:52:8
[INFO] [stderr]    |
[INFO] [stderr] 52 |     if files.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:117:17
[INFO] [stderr]     |
[INFO] [stderr] 117 | /                 match in_mem {
[INFO] [stderr] 118 | |                     true => (line.as_bytes(), line.as_bytes().len()),
[INFO] [stderr] 119 | |                     false => {
[INFO] [stderr] 120 | |                         mmap = Mmap::open_path(&temp_path, memmap::Protection::Read)?;
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |                     }
[INFO] [stderr] 124 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if in_mem { (line.as_bytes(), line.as_bytes().len()) } else {
[INFO] [stderr] 118 |     mmap = Mmap::open_path(&temp_path, memmap::Protection::Read)?;
[INFO] [stderr] 119 |     let bytes = unsafe { mmap.as_slice() };
[INFO] [stderr] 120 |     (bytes, mmap.len())
[INFO] [stderr] 121 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:138:55
[INFO] [stderr]     |
[INFO] [stderr] 138 |             if index == -1 || file[index as usize] == '\n' as u8 {
[INFO] [stderr]     |                                                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'\n'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:151:14
[INFO] [stderr]     |
[INFO] [stderr] 151 |             .expect(&format!("Failed to remove temporary file {}", temp_path.display()));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to remove temporary file {}", temp_path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:154:5
[INFO] [stderr]     |
[INFO] [stderr] 154 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:64:16
[INFO] [stderr]    |
[INFO] [stderr] 64 | fn print_bytes(mut stdout: &mut Stdout, bytes: &[u8]) {
[INFO] [stderr]    |                ----^^^^^^
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:41:37
[INFO] [stderr]    |
[INFO] [stderr] 41 |                 if file.starts_with("-") && file != "-" {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'-'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:52:8
[INFO] [stderr]    |
[INFO] [stderr] 52 |     if files.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `files.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:117:17
[INFO] [stderr]     |
[INFO] [stderr] 117 | /                 match in_mem {
[INFO] [stderr] 118 | |                     true => (line.as_bytes(), line.as_bytes().len()),
[INFO] [stderr] 119 | |                     false => {
[INFO] [stderr] 120 | |                         mmap = Mmap::open_path(&temp_path, memmap::Protection::Read)?;
[INFO] [stderr] ...   |
[INFO] [stderr] 123 | |                     }
[INFO] [stderr] 124 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 117 |                 if in_mem { (line.as_bytes(), line.as_bytes().len()) } else {
[INFO] [stderr] 118 |     mmap = Mmap::open_path(&temp_path, memmap::Protection::Read)?;
[INFO] [stderr] 119 |     let bytes = unsafe { mmap.as_slice() };
[INFO] [stderr] 120 |     (bytes, mmap.len())
[INFO] [stderr] 121 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:138:55
[INFO] [stderr]     |
[INFO] [stderr] 138 |             if index == -1 || file[index as usize] == '\n' as u8 {
[INFO] [stderr]     |                                                       ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'\n'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:151:14
[INFO] [stderr]     |
[INFO] [stderr] 151 |             .expect(&format!("Failed to remove temporary file {}", temp_path.display()));
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to remove temporary file {}", temp_path.display()))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.86s
[INFO] running `"docker" "inspect" "3519f4125cd56ff399de1e121fb5254420c3e38c303c63e2b88c5d722804a5de"`
[INFO] running `"docker" "rm" "-f" "3519f4125cd56ff399de1e121fb5254420c3e38c303c63e2b88c5d722804a5de"`
[INFO] [stdout] 3519f4125cd56ff399de1e121fb5254420c3e38c303c63e2b88c5d722804a5de