[INFO] updating cached repository neosmart/rsproxy
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/neosmart/rsproxy
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/rsproxy" "work/ex/clippy-test-run/sources/stable/gh/neosmart/rsproxy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neosmart/rsproxy'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/rsproxy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/rsproxy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/rsproxy'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 962b68c15b9f72f6361b4f73bfac7c6616d3b847
[INFO] sha for GitHub repo neosmart/rsproxy: 962b68c15b9f72f6361b4f73bfac7c6616d3b847
[INFO] validating manifest of neosmart/rsproxy on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of neosmart/rsproxy on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing neosmart/rsproxy
[INFO] finished frobbing neosmart/rsproxy
[INFO] frobbed toml for neosmart/rsproxy written to work/ex/clippy-test-run/sources/stable/gh/neosmart/rsproxy/Cargo.toml
[INFO] started frobbing neosmart/rsproxy
[INFO] finished frobbing neosmart/rsproxy
[INFO] frobbed toml for neosmart/rsproxy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/rsproxy/Cargo.toml
[INFO] crate neosmart/rsproxy has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting neosmart/rsproxy against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/neosmart/rsproxy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4479cf9faca6221ec3529d5f8fc063b977de47e393883e97ddc2ad5e729c4bfa
[INFO] running `"docker" "start" "-a" "4479cf9faca6221ec3529d5f8fc063b977de47e393883e97ddc2ad5e729c4bfa"`
[INFO] [stderr]     Checking rsproxy v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:50:20
[INFO] [stderr]    |
[INFO] [stderr] 50 |       let protocol = match matches.opt_present("u") {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 51 | |         true => Protocol::Udp,
[INFO] [stderr] 52 | |         false => Protocol::Tcp, //because it's the default
[INFO] [stderr] 53 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if matches.opt_present("u") { Protocol::Udp } else { Protocol::Tcp }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:61:31
[INFO] [stderr]    |
[INFO] [stderr] 61 |         cargo_install(server).expect(&format!("Failed to install {} package via cargo!", server));
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to install {} package via cargo!", server))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:84:10
[INFO] [stderr]    |
[INFO] [stderr] 84 |         .expect(&format!("{} failed to run!", server));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} failed to run!", server))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:71:14
[INFO] [stderr]    |
[INFO] [stderr] 71 |           .arg(match matches.opt_present("b") {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 72 | |             true => "-b",
[INFO] [stderr] 73 | |             false => "",
[INFO] [stderr] 74 | |         })
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if matches.opt_present("b") { "-b" } else { "" }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:75:14
[INFO] [stderr]    |
[INFO] [stderr] 75 |           .arg(match matches.opt_present("b") {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 76 | |             true => matches.opt_str("b").unwrap(),
[INFO] [stderr] 77 | |             false => "".to_owned(),
[INFO] [stderr] 78 | |         })
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if matches.opt_present("b") { matches.opt_str("b").unwrap() } else { "".to_owned() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |           .arg(match matches.opt_present("d") {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 80 | |             true => "-d",
[INFO] [stderr] 81 | |             false => "",
[INFO] [stderr] 82 | |         })
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if matches.opt_present("d") { "-d" } else { "" }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:104:10
[INFO] [stderr]     |
[INFO] [stderr] 104 |         .expect(&format!("Failed to install {} via cargo package manager!", package));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to install {} via cargo package manager!", package))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:115:18
[INFO] [stderr]     |
[INFO] [stderr] 115 |             .map(|p| PathBuf::from(p))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/main.rs:114:28
[INFO] [stderr]     |
[INFO] [stderr] 114 |         env_path.split(|c| [';', ':'].into_iter().find(|x| **x == c).is_some())
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|x| **x == c).is_some()` with `any(|x| **x == c)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/main.rs:114:39
[INFO] [stderr]     |
[INFO] [stderr] 114 |         env_path.split(|c| [';', ':'].into_iter().find(|x| **x == c).is_some())
[INFO] [stderr]     |                                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rsproxy`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:50:20
[INFO] [stderr]    |
[INFO] [stderr] 50 |       let protocol = match matches.opt_present("u") {
[INFO] [stderr]    |  ____________________^
[INFO] [stderr] 51 | |         true => Protocol::Udp,
[INFO] [stderr] 52 | |         false => Protocol::Tcp, //because it's the default
[INFO] [stderr] 53 | |     };
[INFO] [stderr]    | |_____^ help: consider using an if/else expression: `if matches.opt_present("u") { Protocol::Udp } else { Protocol::Tcp }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:61:31
[INFO] [stderr]    |
[INFO] [stderr] 61 |         cargo_install(server).expect(&format!("Failed to install {} package via cargo!", server));
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to install {} package via cargo!", server))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:84:10
[INFO] [stderr]    |
[INFO] [stderr] 84 |         .expect(&format!("{} failed to run!", server));
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("{} failed to run!", server))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:71:14
[INFO] [stderr]    |
[INFO] [stderr] 71 |           .arg(match matches.opt_present("b") {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 72 | |             true => "-b",
[INFO] [stderr] 73 | |             false => "",
[INFO] [stderr] 74 | |         })
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if matches.opt_present("b") { "-b" } else { "" }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:75:14
[INFO] [stderr]    |
[INFO] [stderr] 75 |           .arg(match matches.opt_present("b") {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 76 | |             true => matches.opt_str("b").unwrap(),
[INFO] [stderr] 77 | |             false => "".to_owned(),
[INFO] [stderr] 78 | |         })
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if matches.opt_present("b") { matches.opt_str("b").unwrap() } else { "".to_owned() }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:79:14
[INFO] [stderr]    |
[INFO] [stderr] 79 |           .arg(match matches.opt_present("d") {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 80 | |             true => "-d",
[INFO] [stderr] 81 | |             false => "",
[INFO] [stderr] 82 | |         })
[INFO] [stderr]    | |_________^ help: consider using an if/else expression: `if matches.opt_present("d") { "-d" } else { "" }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]    --> src/main.rs:104:10
[INFO] [stderr]     |
[INFO] [stderr] 104 |         .expect(&format!("Failed to install {} via cargo package manager!", package));
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to install {} via cargo package manager!", package))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:115:18
[INFO] [stderr]     |
[INFO] [stderr] 115 |             .map(|p| PathBuf::from(p))
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `PathBuf::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]    --> src/main.rs:114:28
[INFO] [stderr]     |
[INFO] [stderr] 114 |         env_path.split(|c| [';', ':'].into_iter().find(|x| **x == c).is_some())
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]     = note: replace `find(|x| **x == c).is_some()` with `any(|x| **x == c)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/main.rs:114:39
[INFO] [stderr]     |
[INFO] [stderr] 114 |         env_path.split(|c| [';', ':'].into_iter().find(|x| **x == c).is_some())
[INFO] [stderr]     |                                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::into_iter_on_array)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `rsproxy`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "4479cf9faca6221ec3529d5f8fc063b977de47e393883e97ddc2ad5e729c4bfa"`
[INFO] running `"docker" "rm" "-f" "4479cf9faca6221ec3529d5f8fc063b977de47e393883e97ddc2ad5e729c4bfa"`
[INFO] [stdout] 4479cf9faca6221ec3529d5f8fc063b977de47e393883e97ddc2ad5e729c4bfa