[INFO] updating cached repository neosmart/pkg-graph
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/neosmart/pkg-graph
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/pkg-graph" "work/ex/clippy-test-run/sources/stable/gh/neosmart/pkg-graph"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neosmart/pkg-graph'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/neosmart/pkg-graph" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/pkg-graph"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/pkg-graph'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3b1689806266a18766f7107fd41252cd1ad57e70
[INFO] sha for GitHub repo neosmart/pkg-graph: 3b1689806266a18766f7107fd41252cd1ad57e70
[INFO] validating manifest of neosmart/pkg-graph on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of neosmart/pkg-graph on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing neosmart/pkg-graph
[INFO] finished frobbing neosmart/pkg-graph
[INFO] frobbed toml for neosmart/pkg-graph written to work/ex/clippy-test-run/sources/stable/gh/neosmart/pkg-graph/Cargo.toml
[INFO] started frobbing neosmart/pkg-graph
[INFO] finished frobbing neosmart/pkg-graph
[INFO] frobbed toml for neosmart/pkg-graph written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neosmart/pkg-graph/Cargo.toml
[INFO] crate neosmart/pkg-graph has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting neosmart/pkg-graph against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/neosmart/pkg-graph:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b684e0fff51edb9a48e7c07936430738750cfc58b6f5fc827fbfa682bbc9b4df
[INFO] running `"docker" "start" "-a" "b684e0fff51edb9a48e7c07936430738750cfc58b6f5fc827fbfa682bbc9b4df"`
[INFO] [stderr]     Checking pkg-graph v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 |     return Ok(packages);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(packages)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 |     return Some((&combined[0..last_dash], &combined[last_dash + 1..]));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((&combined[0..last_dash], &combined[last_dash + 1..]))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:198:5
[INFO] [stderr]     |
[INFO] [stderr] 198 |     return Ok(Some(pdeps));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(pdeps))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:152:5
[INFO] [stderr]     |
[INFO] [stderr] 152 |     return Ok(packages);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(packages)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 |     return Some((&combined[0..last_dash], &combined[last_dash + 1..]));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((&combined[0..last_dash], &combined[last_dash + 1..]))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:198:5
[INFO] [stderr]     |
[INFO] [stderr] 198 |     return Ok(Some(pdeps));
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(pdeps))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:39:14
[INFO] [stderr]    |
[INFO] [stderr] 39 |             .expect(&format!("Could not get dependencies for package {}", package.name));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not get dependencies for package {}", package.name))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in line.chars().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:119:18
[INFO] [stderr]     |
[INFO] [stderr] 119 |         for c in line.chars() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:155:1
[INFO] [stderr]     |
[INFO] [stderr] 155 | / fn split_name_version<'a>(combined: &'a str) -> Option<(&'a str, &'a str)> {
[INFO] [stderr] 156 | |     let last_dash = match combined.rfind('-') {
[INFO] [stderr] 157 | |         None => return None,
[INFO] [stderr] 158 | |         Some(x) => x
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |     return Some((&combined[0..last_dash], &combined[last_dash + 1..]));
[INFO] [stderr] 162 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:39:14
[INFO] [stderr]    |
[INFO] [stderr] 39 |             .expect(&format!("Could not get dependencies for package {}", package.name));
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not get dependencies for package {}", package.name))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in line.chars().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:119:18
[INFO] [stderr]     |
[INFO] [stderr] 119 |         for c in line.chars() {
[INFO] [stderr]     |                  ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:155:1
[INFO] [stderr]     |
[INFO] [stderr] 155 | / fn split_name_version<'a>(combined: &'a str) -> Option<(&'a str, &'a str)> {
[INFO] [stderr] 156 | |     let last_dash = match combined.rfind('-') {
[INFO] [stderr] 157 | |         None => return None,
[INFO] [stderr] 158 | |         Some(x) => x
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |     return Some((&combined[0..last_dash], &combined[last_dash + 1..]));
[INFO] [stderr] 162 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.66s
[INFO] running `"docker" "inspect" "b684e0fff51edb9a48e7c07936430738750cfc58b6f5fc827fbfa682bbc9b4df"`
[INFO] running `"docker" "rm" "-f" "b684e0fff51edb9a48e7c07936430738750cfc58b6f5fc827fbfa682bbc9b4df"`
[INFO] [stdout] b684e0fff51edb9a48e7c07936430738750cfc58b6f5fc827fbfa682bbc9b4df