[INFO] updating cached repository neonmoe/oxilog
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/neonmoe/oxilog
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/neonmoe/oxilog" "work/ex/clippy-test-run/sources/stable/gh/neonmoe/oxilog"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neonmoe/oxilog'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/neonmoe/oxilog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neonmoe/oxilog"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neonmoe/oxilog'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 96ee290b753a6faf767dac442257c2cc34b1e17c
[INFO] sha for GitHub repo neonmoe/oxilog: 96ee290b753a6faf767dac442257c2cc34b1e17c
[INFO] validating manifest of neonmoe/oxilog on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of neonmoe/oxilog on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing neonmoe/oxilog
[INFO] finished frobbing neonmoe/oxilog
[INFO] frobbed toml for neonmoe/oxilog written to work/ex/clippy-test-run/sources/stable/gh/neonmoe/oxilog/Cargo.toml
[INFO] started frobbing neonmoe/oxilog
[INFO] finished frobbing neonmoe/oxilog
[INFO] frobbed toml for neonmoe/oxilog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neonmoe/oxilog/Cargo.toml
[INFO] crate neonmoe/oxilog has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting neonmoe/oxilog against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/neonmoe/oxilog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 36f6c84d910bdfa354abdd4946eb4c15e0573032de99e0f17ba1b29ef8c41c9a
[INFO] running `"docker" "start" "-a" "36f6c84d910bdfa354abdd4946eb4c15e0573032de99e0f17ba1b29ef8c41c9a"`
[INFO] [stderr]     Checking memchr v2.0.1
[INFO] [stderr]     Checking serde_json v1.0.10
[INFO] [stderr]     Checking signalbool v0.2.1
[INFO] [stderr]    Compiling syn v0.12.13
[INFO] [stderr]     Checking aho-corasick v0.6.4
[INFO] [stderr]     Checking regex v0.2.6
[INFO] [stderr]    Compiling structopt-derive v0.2.4
[INFO] [stderr]     Checking structopt v0.2.4
[INFO] [stderr]     Checking oxilog v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/files.rs:44:21
[INFO] [stderr]    |
[INFO] [stderr] 44 | /                     let post: Post;
[INFO] [stderr] 45 | |                     if config_path.exists() {
[INFO] [stderr] 46 | |                         post = serde_json::from_str(&read_file(&config_path)).unwrap();
[INFO] [stderr] 47 | |                     } else {
[INFO] [stderr] 48 | |                         let name = format!("{}", path.file_stem().unwrap().to_string_lossy());
[INFO] [stderr] 49 | |                         post = Post::new().with_name(name);
[INFO] [stderr] 50 | |                     }
[INFO] [stderr]    | |_____________________^ help: it is more idiomatic to write: `let post = if config_path.exists() { serde_json::from_str(&read_file(&config_path)).unwrap() } else { ..; Post::new().with_name(name) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/files.rs:71:40
[INFO] [stderr]    |
[INFO] [stderr] 71 | pub fn write_index(blog: &Blog, posts: &Vec<Post>, output_dir: &Path) {
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: change this to: `&[Post]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/files.rs:118:12
[INFO] [stderr]     |
[INFO] [stderr] 118 |       if let Ok(_) = File::open(&path) {
[INFO] [stderr]     |  _____-      ^^^^^
[INFO] [stderr] 119 | |         let message = format!(
[INFO] [stderr] 120 | |             "ERROR: {} already exists. Please remove it, and then try again.",
[INFO] [stderr] 121 | |             &path.display()
[INFO] [stderr] ...   |
[INFO] [stderr] 126 | |         true
[INFO] [stderr] 127 | |     }
[INFO] [stderr]     | |_____- help: try this: `if File::open(&path).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/log.rs:30:26
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 verbose: verbose as i32,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: try: `i32::from(verbose)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/util.rs:33:8
[INFO] [stderr]    |
[INFO] [stderr] 33 |     if input.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         match cmd {
[INFO] [stderr] 53 | |             &Command::Watch(ref watch) => {
[INFO] [stderr] 54 | |                 /* Enter watching mode */
[INFO] [stderr] 55 | |                 let log = Log::new(watch.quiet, watch.verbose);
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |             }
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 52 |         match *cmd {
[INFO] [stderr] 53 |             Command::Watch(ref watch) => {
[INFO] [stderr] 54 |                 /* Enter watching mode */
[INFO] [stderr] 55 |                 let log = Log::new(watch.quiet, watch.verbose);
[INFO] [stderr] 56 |                 let blog = files::load_blog(&watch.input_dir);
[INFO] [stderr] 57 |                 start_watching(&log, &blog, watch);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:77:8
[INFO] [stderr]    |
[INFO] [stderr] 77 |     if posts.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!posts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |     for ref post in &posts {
[INFO] [stderr]    |         ^^^^^^^^    ------ help: try: `let post = &&posts;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/files.rs:44:21
[INFO] [stderr]    |
[INFO] [stderr] 44 | /                     let post: Post;
[INFO] [stderr] 45 | |                     if config_path.exists() {
[INFO] [stderr] 46 | |                         post = serde_json::from_str(&read_file(&config_path)).unwrap();
[INFO] [stderr] 47 | |                     } else {
[INFO] [stderr] 48 | |                         let name = format!("{}", path.file_stem().unwrap().to_string_lossy());
[INFO] [stderr] 49 | |                         post = Post::new().with_name(name);
[INFO] [stderr] 50 | |                     }
[INFO] [stderr]    | |_____________________^ help: it is more idiomatic to write: `let post = if config_path.exists() { serde_json::from_str(&read_file(&config_path)).unwrap() } else { ..; Post::new().with_name(name) };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/files.rs:71:40
[INFO] [stderr]    |
[INFO] [stderr] 71 | pub fn write_index(blog: &Blog, posts: &Vec<Post>, output_dir: &Path) {
[INFO] [stderr]    |                                        ^^^^^^^^^^ help: change this to: `&[Post]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()`
[INFO] [stderr]    --> src/files.rs:118:12
[INFO] [stderr]     |
[INFO] [stderr] 118 |       if let Ok(_) = File::open(&path) {
[INFO] [stderr]     |  _____-      ^^^^^
[INFO] [stderr] 119 | |         let message = format!(
[INFO] [stderr] 120 | |             "ERROR: {} already exists. Please remove it, and then try again.",
[INFO] [stderr] 121 | |             &path.display()
[INFO] [stderr] ...   |
[INFO] [stderr] 126 | |         true
[INFO] [stderr] 127 | |     }
[INFO] [stderr]     | |_____- help: try this: `if File::open(&path).is_ok()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/log.rs:30:26
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 verbose: verbose as i32,
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^ help: try: `i32::from(verbose)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/util.rs:33:8
[INFO] [stderr]    |
[INFO] [stderr] 33 |     if input.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `input.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/main.rs:52:9
[INFO] [stderr]    |
[INFO] [stderr] 52 | /         match cmd {
[INFO] [stderr] 53 | |             &Command::Watch(ref watch) => {
[INFO] [stderr] 54 | |                 /* Enter watching mode */
[INFO] [stderr] 55 | |                 let log = Log::new(watch.quiet, watch.verbose);
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |             }
[INFO] [stderr] 64 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 52 |         match *cmd {
[INFO] [stderr] 53 |             Command::Watch(ref watch) => {
[INFO] [stderr] 54 |                 /* Enter watching mode */
[INFO] [stderr] 55 |                 let log = Log::new(watch.quiet, watch.verbose);
[INFO] [stderr] 56 |                 let blog = files::load_blog(&watch.input_dir);
[INFO] [stderr] 57 |                 start_watching(&log, &blog, watch);
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:77:8
[INFO] [stderr]    |
[INFO] [stderr] 77 |     if posts.len() > 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!posts.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |     for ref post in &posts {
[INFO] [stderr]    |         ^^^^^^^^    ------ help: try: `let post = &&posts;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.82s
[INFO] running `"docker" "inspect" "36f6c84d910bdfa354abdd4946eb4c15e0573032de99e0f17ba1b29ef8c41c9a"`
[INFO] running `"docker" "rm" "-f" "36f6c84d910bdfa354abdd4946eb4c15e0573032de99e0f17ba1b29ef8c41c9a"`
[INFO] [stdout] 36f6c84d910bdfa354abdd4946eb4c15e0573032de99e0f17ba1b29ef8c41c9a