[INFO] updating cached repository nelsonjchen/speedtest-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nelsonjchen/speedtest-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nelsonjchen/speedtest-rs" "work/ex/clippy-test-run/sources/stable/gh/nelsonjchen/speedtest-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nelsonjchen/speedtest-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nelsonjchen/speedtest-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nelsonjchen/speedtest-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nelsonjchen/speedtest-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3aaa17dbd58b7aa1febdf736ceb358c73a4e2918
[INFO] sha for GitHub repo nelsonjchen/speedtest-rs: 3aaa17dbd58b7aa1febdf736ceb358c73a4e2918
[INFO] validating manifest of nelsonjchen/speedtest-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nelsonjchen/speedtest-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nelsonjchen/speedtest-rs
[INFO] finished frobbing nelsonjchen/speedtest-rs
[INFO] frobbed toml for nelsonjchen/speedtest-rs written to work/ex/clippy-test-run/sources/stable/gh/nelsonjchen/speedtest-rs/Cargo.toml
[INFO] started frobbing nelsonjchen/speedtest-rs
[INFO] finished frobbing nelsonjchen/speedtest-rs
[INFO] frobbed toml for nelsonjchen/speedtest-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nelsonjchen/speedtest-rs/Cargo.toml
[INFO] crate nelsonjchen/speedtest-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nelsonjchen/speedtest-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nelsonjchen/speedtest-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 463053ec0eb785e421f16f60e7097b9b46f3167a225c76a12b19f5ecf5bd9911
[INFO] running `"docker" "start" "-a" "463053ec0eb785e421f16f60e7097b9b46f3167a225c76a12b19f5ecf5bd9911"`
[INFO] [stderr]    Compiling openssl v0.9.4
[INFO] [stderr]     Checking ansi_term v0.7.5
[INFO] [stderr]     Checking bitflags v0.3.3
[INFO] [stderr]     Checking strsim v0.4.1
[INFO] [stderr]     Checking vec_map v0.4.0
[INFO] [stderr]    Compiling rust-crypto v0.2.36
[INFO] [stderr]     Checking xml-rs v0.3.5
[INFO] [stderr]     Checking serde_urlencoded v0.3.0
[INFO] [stderr]     Checking backtrace v0.3.0
[INFO] [stderr]     Checking cookie v0.2.5
[INFO] [stderr]     Checking clap v1.5.5
[INFO] [stderr]     Checking error-chain v0.7.2
[INFO] [stderr]     Checking hyper v0.9.14
[INFO] [stderr]     Checking native-tls v0.1.0
[INFO] [stderr]     Checking reqwest v0.2.0
[INFO] [stderr]     Checking speedtest-rs v0.0.10 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/speedtest.rs:59:17
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 ip: ip,
[INFO] [stderr]    |                 ^^^^^^ help: replace it with: `ip`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/speedtest.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 isp: isp,
[INFO] [stderr]    |                 ^^^^^^^^ help: replace it with: `isp`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:158:29
[INFO] [stderr]     |
[INFO] [stderr] 158 |                             country: country,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: replace it with: `country`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:159:29
[INFO] [stderr]     |
[INFO] [stderr] 159 |                             host: host,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `host`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:160:29
[INFO] [stderr]     |
[INFO] [stderr] 160 |                             id: id,
[INFO] [stderr]     |                             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:161:29
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             location: location,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:162:29
[INFO] [stderr]     |
[INFO] [stderr] 162 |                             distance: distance,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:163:29
[INFO] [stderr]     |
[INFO] [stderr] 163 |                             name: name,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:164:29
[INFO] [stderr]     |
[INFO] [stderr] 164 |                             sponsor: sponsor,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: replace it with: `sponsor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:165:29
[INFO] [stderr]     |
[INFO] [stderr] 165 |                             url: url,
[INFO] [stderr]     |                             ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:172:37
[INFO] [stderr]     |
[INFO] [stderr] 172 |         Ok(SpeedTestServersConfig { servers: servers })
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^ help: replace it with: `servers`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/speedtest.rs:59:17
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 ip: ip,
[INFO] [stderr]    |                 ^^^^^^ help: replace it with: `ip`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/speedtest.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 isp: isp,
[INFO] [stderr]    |                 ^^^^^^^^ help: replace it with: `isp`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:158:29
[INFO] [stderr]     |
[INFO] [stderr] 158 |                             country: country,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: replace it with: `country`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:159:29
[INFO] [stderr]     |
[INFO] [stderr] 159 |                             host: host,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `host`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:160:29
[INFO] [stderr]     |
[INFO] [stderr] 160 |                             id: id,
[INFO] [stderr]     |                             ^^^^^^ help: replace it with: `id`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:161:29
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             location: location,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^ help: replace it with: `location`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:162:29
[INFO] [stderr]     |
[INFO] [stderr] 162 |                             distance: distance,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^ help: replace it with: `distance`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:163:29
[INFO] [stderr]     |
[INFO] [stderr] 163 |                             name: name,
[INFO] [stderr]     |                             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:164:29
[INFO] [stderr]     |
[INFO] [stderr] 164 |                             sponsor: sponsor,
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^ help: replace it with: `sponsor`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:165:29
[INFO] [stderr]     |
[INFO] [stderr] 165 |                             url: url,
[INFO] [stderr]     |                             ^^^^^^^^ help: replace it with: `url`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/speedtest.rs:172:37
[INFO] [stderr]     |
[INFO] [stderr] 172 |         Ok(SpeedTestServersConfig { servers: servers })
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^ help: replace it with: `servers`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:110:9
[INFO] [stderr]     |
[INFO] [stderr] 110 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/speedtest.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 | const USER_AGENT: &'static str = concat!("reqwest/speedtest-rs ", env!("CARGO_PKG_VERSION"));
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/speedtest.rs:393:24
[INFO] [stderr]     |
[INFO] [stderr] 393 |     let small_sizes = [250000; 25];
[INFO] [stderr]     |                        ^^^^^^ help: consider: `250_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/speedtest.rs:394:24
[INFO] [stderr]     |
[INFO] [stderr] 394 |     let large_sizes = [500000; 25];
[INFO] [stderr]     |                        ^^^^^^ help: consider: `500_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/speedtest.rs:555:5
[INFO] [stderr]     |
[INFO] [stderr] 555 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/distance.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     d
[INFO] [stderr]    |     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/distance.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let d = radius * c;
[INFO] [stderr]    |             ^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/speedtest.rs:18:20
[INFO] [stderr]    |
[INFO] [stderr] 18 | const USER_AGENT: &'static str = concat!("reqwest/speedtest-rs ", env!("CARGO_PKG_VERSION"));
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/speedtest.rs:393:24
[INFO] [stderr]     |
[INFO] [stderr] 393 |     let small_sizes = [250000; 25];
[INFO] [stderr]     |                        ^^^^^^ help: consider: `250_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/speedtest.rs:394:24
[INFO] [stderr]     |
[INFO] [stderr] 394 |     let large_sizes = [500000; 25];
[INFO] [stderr]     |                        ^^^^^^ help: consider: `500_000`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/speedtest.rs:555:5
[INFO] [stderr]     |
[INFO] [stderr] 555 |     return None;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/distance.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     d
[INFO] [stderr]    |     ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/distance.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let d = radius * c;
[INFO] [stderr]    |             ^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/speedtest.rs:328:24
[INFO] [stderr]     |
[INFO] [stderr] 328 |             let size = size.clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^ help: try dereferencing it: `*size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/speedtest.rs:356:34
[INFO] [stderr]     |
[INFO] [stderr] 356 |                         Ok(n) => size = size + n,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^ help: replace it with: `size += n`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/speedtest.rs:378:52
[INFO] [stderr]     |
[INFO] [stderr] 378 |     total_size = (*complete).read().unwrap().iter().fold(0, |val, i| val + i);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/speedtest.rs:407:20
[INFO] [stderr]     |
[INFO] [stderr] 407 |         let size = size.clone();
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: try dereferencing it: `*size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/speedtest.rs:457:52
[INFO] [stderr]     |
[INFO] [stderr] 457 |     total_size = (*complete).read().unwrap().iter().fold(0, |val, i| val + i);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/speedtest.rs:515:19
[INFO] [stderr]     |
[INFO] [stderr] 515 |         ("promo", format!("")),
[INFO] [stderr]     |                   ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/speedtest.rs:516:23
[INFO] [stderr]     |
[INFO] [stderr] 516 |         ("startmode", format!("pingselect")),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pingselect".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/speedtest.rs:518:22
[INFO] [stderr]     |
[INFO] [stderr] 518 |         ("accuracy", format!("1")),
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: consider using .to_string(): `"1".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/speedtest.rs:328:24
[INFO] [stderr]     |
[INFO] [stderr] 328 |             let size = size.clone();
[INFO] [stderr]     |                        ^^^^^^^^^^^^ help: try dereferencing it: `*size`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/speedtest.rs:356:34
[INFO] [stderr]     |
[INFO] [stderr] 356 |                         Ok(n) => size = size + n,
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^ help: replace it with: `size += n`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/speedtest.rs:378:52
[INFO] [stderr]     |
[INFO] [stderr] 378 |     total_size = (*complete).read().unwrap().iter().fold(0, |val, i| val + i);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_fold)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/speedtest.rs:407:20
[INFO] [stderr]     |
[INFO] [stderr] 407 |         let size = size.clone();
[INFO] [stderr]     |                    ^^^^^^^^^^^^ help: try dereferencing it: `*size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: this `.fold` can be written more succinctly using another method
[INFO] [stderr]    --> src/speedtest.rs:457:52
[INFO] [stderr]     |
[INFO] [stderr] 457 |     total_size = (*complete).read().unwrap().iter().fold(0, |val, i| val + i);
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/speedtest.rs:515:19
[INFO] [stderr]     |
[INFO] [stderr] 515 |         ("promo", format!("")),
[INFO] [stderr]     |                   ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/speedtest.rs:516:23
[INFO] [stderr]     |
[INFO] [stderr] 516 |         ("startmode", format!("pingselect")),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pingselect".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/speedtest.rs:518:22
[INFO] [stderr]     |
[INFO] [stderr] 518 |         ("accuracy", format!("1")),
[INFO] [stderr]     |                      ^^^^^^^^^^^^ help: consider using .to_string(): `"1".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]    --> src/speedtest.rs:567:20
[INFO] [stderr]     |
[INFO] [stderr] 567 |         let resp = "resultid=4932415710&date=12%2F21%2F2015&time=5%3A10+AM&rating=0".as_bytes();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"resultid=4932415710&date=12%2F21%2F2015&time=5%3A10+AM&rating=0"`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/speedtest.rs:642:22
[INFO] [stderr]     |
[INFO] [stderr] 642 |         let server = spt_server_config.servers.get(1).unwrap();
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&spt_server_config.servers[1]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/speedtest.rs:643:17
[INFO] [stderr]     |
[INFO] [stderr] 643 |         assert!(server.url.len() > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!server.url.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/speedtest.rs:644:17
[INFO] [stderr]     |
[INFO] [stderr] 644 |         assert!(server.country.len() > 0);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!server.country.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 20.85s
[INFO] running `"docker" "inspect" "463053ec0eb785e421f16f60e7097b9b46f3167a225c76a12b19f5ecf5bd9911"`
[INFO] running `"docker" "rm" "-f" "463053ec0eb785e421f16f60e7097b9b46f3167a225c76a12b19f5ecf5bd9911"`
[INFO] [stdout] 463053ec0eb785e421f16f60e7097b9b46f3167a225c76a12b19f5ecf5bd9911