[INFO] updating cached repository nellshamrell/redis-to-postgres-migrator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nellshamrell/redis-to-postgres-migrator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nellshamrell/redis-to-postgres-migrator" "work/ex/clippy-test-run/sources/stable/gh/nellshamrell/redis-to-postgres-migrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nellshamrell/redis-to-postgres-migrator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nellshamrell/redis-to-postgres-migrator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nellshamrell/redis-to-postgres-migrator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nellshamrell/redis-to-postgres-migrator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b10fe7a927788167922f40f573f838dcea5d6fe [INFO] sha for GitHub repo nellshamrell/redis-to-postgres-migrator: 0b10fe7a927788167922f40f573f838dcea5d6fe [INFO] validating manifest of nellshamrell/redis-to-postgres-migrator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nellshamrell/redis-to-postgres-migrator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nellshamrell/redis-to-postgres-migrator [INFO] finished frobbing nellshamrell/redis-to-postgres-migrator [INFO] frobbed toml for nellshamrell/redis-to-postgres-migrator written to work/ex/clippy-test-run/sources/stable/gh/nellshamrell/redis-to-postgres-migrator/Cargo.toml [INFO] started frobbing nellshamrell/redis-to-postgres-migrator [INFO] finished frobbing nellshamrell/redis-to-postgres-migrator [INFO] frobbed toml for nellshamrell/redis-to-postgres-migrator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nellshamrell/redis-to-postgres-migrator/Cargo.toml [INFO] crate nellshamrell/redis-to-postgres-migrator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nellshamrell/redis-to-postgres-migrator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nellshamrell/redis-to-postgres-migrator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c062de8f1fc14ca5d7cb16497ce33bf456108a5806bfa022ca836aecc4afd03d [INFO] running `"docker" "start" "-a" "c062de8f1fc14ca5d7cb16497ce33bf456108a5806bfa022ca836aecc4afd03d"` [INFO] [stderr] Checking libc v0.2.21 [INFO] [stderr] Checking md5 v0.3.4 [INFO] [stderr] Checking fallible-iterator v0.1.3 [INFO] [stderr] Checking bufstream v0.1.2 [INFO] [stderr] Checking sha1 v0.1.1 [INFO] [stderr] Checking redis v0.5.4 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking postgres-protocol v0.2.1 [INFO] [stderr] Checking postgres-shared v0.2.0 [INFO] [stderr] Checking postgres v0.14.0 [INFO] [stderr] Checking data-migrator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | connection [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | let connection = Connection::connect(address, TlsMode::None).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | let result = redis_conn.lrange(key, 0, -1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/main.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | connection [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | let connection = Connection::connect(address, TlsMode::None).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | let result = redis_conn.lrange(key, 0, -1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | redis_cleanup(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | create_redis_data(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | redis_cleanup(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.13s [INFO] running `"docker" "inspect" "c062de8f1fc14ca5d7cb16497ce33bf456108a5806bfa022ca836aecc4afd03d"` [INFO] running `"docker" "rm" "-f" "c062de8f1fc14ca5d7cb16497ce33bf456108a5806bfa022ca836aecc4afd03d"` [INFO] [stdout] c062de8f1fc14ca5d7cb16497ce33bf456108a5806bfa022ca836aecc4afd03d