[INFO] updating cached repository nejucomo/sappho-on-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nejucomo/sappho-on-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nejucomo/sappho-on-rust" "work/ex/clippy-test-run/sources/stable/gh/nejucomo/sappho-on-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nejucomo/sappho-on-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nejucomo/sappho-on-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nejucomo/sappho-on-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nejucomo/sappho-on-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d771023fcdea57ed965a67d91ba1805b291b74ae [INFO] sha for GitHub repo nejucomo/sappho-on-rust: d771023fcdea57ed965a67d91ba1805b291b74ae [INFO] validating manifest of nejucomo/sappho-on-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nejucomo/sappho-on-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nejucomo/sappho-on-rust [INFO] finished frobbing nejucomo/sappho-on-rust [INFO] frobbed toml for nejucomo/sappho-on-rust written to work/ex/clippy-test-run/sources/stable/gh/nejucomo/sappho-on-rust/Cargo.toml [INFO] started frobbing nejucomo/sappho-on-rust [INFO] finished frobbing nejucomo/sappho-on-rust [INFO] frobbed toml for nejucomo/sappho-on-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nejucomo/sappho-on-rust/Cargo.toml [INFO] crate nejucomo/sappho-on-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nejucomo/sappho-on-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nejucomo/sappho-on-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d85cb4f619bcc3e448ab10fc9fa96b260d1b3901bfc8590b00bdfe4cf708789 [INFO] running `"docker" "start" "-a" "0d85cb4f619bcc3e448ab10fc9fa96b260d1b3901bfc8590b00bdfe4cf708789"` [INFO] [stderr] Checking combine v2.5.2 [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Compiling backtrace-sys v0.1.23 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Compiling backtrace v0.3.9 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Compiling failure v0.1.2 [INFO] [stderr] Compiling include_dir_impl v0.2.1 [INFO] [stderr] Checking include_dir v0.2.1 [INFO] [stderr] Checking sappho-on-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser/atom/text.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | delim: delim, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delim` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser/expr/top.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | sc: sc, [INFO] [stderr] | ^^^^^^ help: replace it with: `sc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/value/number.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | Number { i: i, point: point } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/value/number.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | Number { i: i, point: point } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser/testutils.rs:186:13 [INFO] [stderr] | [INFO] [stderr] 186 | write!(flref.0, "{}\n", body).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::write_with_newline)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser/atom/text.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | delim: delim, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delim` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/parser/expr/top.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | sc: sc, [INFO] [stderr] | ^^^^^^ help: replace it with: `sc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/value/number.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | Number { i: i, point: point } [INFO] [stderr] | ^^^^ help: replace it with: `i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/value/number.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | Number { i: i, point: point } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ast/pattern.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::let_and_return)] implied by #[deny(warnings)] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ast/pattern.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | let result = match self.0 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 24 | | Some(&Pattern::Bind(ref id)) => { [INFO] [stderr] 25 | | self.0 = None; [INFO] [stderr] 26 | | Some(id) [INFO] [stderr] ... | [INFO] [stderr] 29 | | None => None, [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser/expr/scopecheck.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sappho-on-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ast/pattern.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::let_and_return)] implied by #[deny(warnings)] [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ast/pattern.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | let result = match self.0 { [INFO] [stderr] | ______________________^ [INFO] [stderr] 24 | | Some(&Pattern::Bind(ref id)) => { [INFO] [stderr] 25 | | self.0 = None; [INFO] [stderr] 26 | | Some(id) [INFO] [stderr] ... | [INFO] [stderr] 29 | | None => None, [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/parser/expr/scopecheck.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parser/expr/mod.rs:14:28 [INFO] [stderr] | [INFO] [stderr] 14 | const BINDINGS: &[&'static str] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `sappho-on-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0d85cb4f619bcc3e448ab10fc9fa96b260d1b3901bfc8590b00bdfe4cf708789"` [INFO] running `"docker" "rm" "-f" "0d85cb4f619bcc3e448ab10fc9fa96b260d1b3901bfc8590b00bdfe4cf708789"` [INFO] [stdout] 0d85cb4f619bcc3e448ab10fc9fa96b260d1b3901bfc8590b00bdfe4cf708789