[INFO] updating cached repository neilparikh/http
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/neilparikh/http
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/neilparikh/http" "work/ex/clippy-test-run/sources/stable/gh/neilparikh/http"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neilparikh/http'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/neilparikh/http" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neilparikh/http"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neilparikh/http'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 89453990fb6b8faad8cb83ce11658b762cf06c53
[INFO] sha for GitHub repo neilparikh/http: 89453990fb6b8faad8cb83ce11658b762cf06c53
[INFO] validating manifest of neilparikh/http on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of neilparikh/http on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing neilparikh/http
[INFO] finished frobbing neilparikh/http
[INFO] frobbed toml for neilparikh/http written to work/ex/clippy-test-run/sources/stable/gh/neilparikh/http/Cargo.toml
[INFO] started frobbing neilparikh/http
[INFO] finished frobbing neilparikh/http
[INFO] frobbed toml for neilparikh/http written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neilparikh/http/Cargo.toml
[INFO] crate neilparikh/http has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting neilparikh/http against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/neilparikh/http:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5d71ca377f9317836d94f688b8c8e54834d018872bdcc98dc7f8e2065eddcba4
[INFO] running `"docker" "start" "-a" "5d71ca377f9317836d94f688b8c8e54834d018872bdcc98dc7f8e2065eddcba4"`
[INFO] [stderr]     Checking libc v0.2.36
[INFO] [stderr]     Checking memchr v1.0.2
[INFO] [stderr]     Checking nom v3.2.1
[INFO] [stderr]     Checking http v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:31:1
[INFO] [stderr]    |
[INFO] [stderr] 31 | / named!(method_parser<&str, Method>,
[INFO] [stderr] 32 | |   map_res!(take_till!(is_space), to_method)
[INFO] [stderr] 33 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:35:1
[INFO] [stderr]    |
[INFO] [stderr] 35 | / named!(request_line<&str, Request>,
[INFO] [stderr] 36 | |   do_parse!(
[INFO] [stderr] 37 | |     method: method_parser >>
[INFO] [stderr] 38 | |             multispace >>
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |   )
[INFO] [stderr] 42 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     stream.read(&mut request).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:69:40
[INFO] [stderr]    |
[INFO] [stderr] 69 |             if request_.path.ends_with("/") {
[INFO] [stderr]    |                                        ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:81:21
[INFO] [stderr]    |
[INFO] [stderr] 81 | /                     let mut content_type;
[INFO] [stderr] 82 | |                     if path.ends_with(".html") {
[INFO] [stderr] 83 | |                         content_type = "text/html";
[INFO] [stderr] 84 | |                     } else {
[INFO] [stderr] 85 | |                         content_type = "text/plain";
[INFO] [stderr] 86 | |                     }
[INFO] [stderr]    | |_____________________^ help: it is more idiomatic to write: `let <mut> content_type = if path.ends_with(".html") { "text/html" } else { "text/plain" };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     stream.write(format!("{}", response).as_bytes()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |     stream.write(format!("{}", response).as_bytes()).unwrap();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `response.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `http`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:31:1
[INFO] [stderr]    |
[INFO] [stderr] 31 | / named!(method_parser<&str, Method>,
[INFO] [stderr] 32 | |   map_res!(take_till!(is_space), to_method)
[INFO] [stderr] 33 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:35:1
[INFO] [stderr]    |
[INFO] [stderr] 35 | / named!(request_line<&str, Request>,
[INFO] [stderr] 36 | |   do_parse!(
[INFO] [stderr] 37 | |     method: method_parser >>
[INFO] [stderr] 38 | |             multispace >>
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |   )
[INFO] [stderr] 42 | | );
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     stream.read(&mut request).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:69:40
[INFO] [stderr]    |
[INFO] [stderr] 69 |             if request_.path.ends_with("/") {
[INFO] [stderr]    |                                        ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:81:21
[INFO] [stderr]    |
[INFO] [stderr] 81 | /                     let mut content_type;
[INFO] [stderr] 82 | |                     if path.ends_with(".html") {
[INFO] [stderr] 83 | |                         content_type = "text/html";
[INFO] [stderr] 84 | |                     } else {
[INFO] [stderr] 85 | |                         content_type = "text/plain";
[INFO] [stderr] 86 | |                     }
[INFO] [stderr]    | |_____________________^ help: it is more idiomatic to write: `let <mut> content_type = if path.ends_with(".html") { "text/html" } else { "text/plain" };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/main.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     stream.write(format!("{}", response).as_bytes()).unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |     stream.write(format!("{}", response).as_bytes()).unwrap();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `response.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `http`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "5d71ca377f9317836d94f688b8c8e54834d018872bdcc98dc7f8e2065eddcba4"`
[INFO] running `"docker" "rm" "-f" "5d71ca377f9317836d94f688b8c8e54834d018872bdcc98dc7f8e2065eddcba4"`
[INFO] [stdout] 5d71ca377f9317836d94f688b8c8e54834d018872bdcc98dc7f8e2065eddcba4