[INFO] updating cached repository neilg63/astrojson [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/neilg63/astrojson [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/neilg63/astrojson" "work/ex/clippy-test-run/sources/stable/gh/neilg63/astrojson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neilg63/astrojson'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/neilg63/astrojson" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neilg63/astrojson"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neilg63/astrojson'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9a7cb2d3e3c2b0081078f077051288dc8c86699d [INFO] sha for GitHub repo neilg63/astrojson: 9a7cb2d3e3c2b0081078f077051288dc8c86699d [INFO] validating manifest of neilg63/astrojson on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neilg63/astrojson on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neilg63/astrojson [INFO] finished frobbing neilg63/astrojson [INFO] frobbed toml for neilg63/astrojson written to work/ex/clippy-test-run/sources/stable/gh/neilg63/astrojson/Cargo.toml [INFO] started frobbing neilg63/astrojson [INFO] finished frobbing neilg63/astrojson [INFO] frobbed toml for neilg63/astrojson written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neilg63/astrojson/Cargo.toml [INFO] crate neilg63/astrojson has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neilg63/astrojson against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/neilg63/astrojson:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 267901360a833cce86a02437f9ac70fe56bff3bed0c2e0bc15c26f243cc180a0 [INFO] running `"docker" "start" "-a" "267901360a833cce86a02437f9ac70fe56bff3bed0c2e0bc15c26f243cc180a0"` [INFO] [stderr] Compiling quote v0.3.12 [INFO] [stderr] Checking serde v0.9.6 [INFO] [stderr] Checking grabinput v0.2.1 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Compiling syn v0.11.4 [INFO] [stderr] Compiling serde_codegen_internals v0.13.0 [INFO] [stderr] Compiling serde_derive v0.9.6 [INFO] [stderr] Checking serde_json v0.9.5 [INFO] [stderr] Checking astro v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sweph.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | key:key, [INFO] [stderr] | ^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/astro.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | orb: orb [INFO] [stderr] | ^^^^^^^^ help: replace it with: `orb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/astro.rs:128:7 [INFO] [stderr] | [INFO] [stderr] 128 | angle: angle, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `angle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | bodies: bodies, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bodies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | houses: houses, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `houses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | ayanamsas: ayanamsas, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ayanamsas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sweph.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | key:key, [INFO] [stderr] | ^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/astro.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | orb: orb [INFO] [stderr] | ^^^^^^^^ help: replace it with: `orb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/astro.rs:128:7 [INFO] [stderr] | [INFO] [stderr] 128 | angle: angle, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `angle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | bodies: bodies, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bodies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | houses: houses, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `houses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:145:5 [INFO] [stderr] | [INFO] [stderr] 145 | ayanamsas: ayanamsas, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `ayanamsas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/astro.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | ag.push(AspectData::new("triseptile",(360.0/7.0*3.0) )); // 154.28571 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/astro.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | ag.push(AspectData::new("biseptile",(360.0/3.5))); // 102.85714 [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/astro.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | ag.push(AspectData::new("septile",(360.0/7.0))); // 51.42857 [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/astro.rs:97:40 [INFO] [stderr] | [INFO] [stderr] 97 | ag.push(AspectData::new("triseptile",(360.0/7.0*3.0) )); // 154.28571 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/astro.rs:103:39 [INFO] [stderr] | [INFO] [stderr] 103 | ag.push(AspectData::new("biseptile",(360.0/3.5))); // 102.85714 [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/astro.rs:108:37 [INFO] [stderr] | [INFO] [stderr] 108 | ag.push(AspectData::new("septile",(360.0/7.0))); // 51.42857 [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | let mut parts = line.trim().split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | let vals:Vec = val_str.split(",").map(|s| value_string_to_f64(s, has_float_key(first.as_str()) )).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sweph.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / match cap { [INFO] [stderr] 36 | | Some(matches) => { [INFO] [stderr] 37 | | key_parts = match_key_parts(matches,first.as_str()); [INFO] [stderr] 38 | | }, [INFO] [stderr] 39 | | None => () [INFO] [stderr] 40 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Some(matches) = cap { [INFO] [stderr] 36 | key_parts = match_key_parts(matches,first.as_str()); [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sweph.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | / match matches.get(2) { [INFO] [stderr] 55 | | Some(m1) => { [INFO] [stderr] 56 | | match m1.as_str() { [INFO] [stderr] 57 | | "-" => { [INFO] [stderr] ... | [INFO] [stderr] 80 | | _ => () [INFO] [stderr] 81 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(m1) = matches.get(2) { [INFO] [stderr] 55 | match m1.as_str() { [INFO] [stderr] 56 | "-" => { [INFO] [stderr] 57 | match matches.get(1) { [INFO] [stderr] 58 | Some(m2) => { [INFO] [stderr] 59 | if m2.as_str() == "ay" { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sweph.rs:58:11 [INFO] [stderr] | [INFO] [stderr] 58 | / match matches.get(1) { [INFO] [stderr] 59 | | Some(m2) => { [INFO] [stderr] 60 | | if m2.as_str() == "ay" { [INFO] [stderr] 61 | | str_section = "ayanamsas"; [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => () [INFO] [stderr] 70 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(m2) = matches.get(1) { [INFO] [stderr] 59 | if m2.as_str() == "ay" { [INFO] [stderr] 60 | str_section = "ayanamsas"; [INFO] [stderr] 61 | str_mode = matches.get(3).unwrap().as_str(); [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | str_section = "houses"; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | let mut parts = datestr.split("T"); [INFO] [stderr] | ^^^ help: try using a char instead: `'T'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:140:33 [INFO] [stderr] | [INFO] [stderr] 140 | let dt:Vec<&str> = date.split("-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:141:33 [INFO] [stderr] | [INFO] [stderr] 141 | let ti:Vec<&str> = time.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:149:32 [INFO] [stderr] | [INFO] [stderr] 149 | let mut parts = coords.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `aspect_groups`. [INFO] [stderr] --> src/astro.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | for i in 0..num_aspect_groups { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 19 | for in aspect_groups.iter_mut().take(num_aspect_groups) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:170:14 [INFO] [stderr] | [INFO] [stderr] 170 | lat: items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:171:14 [INFO] [stderr] | [INFO] [stderr] 171 | lng: items.get(0).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:172:14 [INFO] [stderr] | [INFO] [stderr] 172 | spd: items.get(2).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:176:14 [INFO] [stderr] | [INFO] [stderr] 176 | lat: items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | lng: items.get(0).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:190:14 [INFO] [stderr] | [INFO] [stderr] 190 | lat: items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | lng: items.get(0).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | spd: items.get(2).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:193:15 [INFO] [stderr] | [INFO] [stderr] 193 | glat: geo_items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_items[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:194:15 [INFO] [stderr] | [INFO] [stderr] 194 | glng: geo_items.get(0).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:195:15 [INFO] [stderr] | [INFO] [stderr] 195 | gspd: geo_items.get(2).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_items[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/astro.rs:232:63 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn add_rahuketu(bodies:&mut HashMap>,vals:&Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:235:6 [INFO] [stderr] | [INFO] [stderr] 235 | (vals.get(0).unwrap().to_owned() + 180.0) % 360.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vals[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | vals.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vals[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | vals.get(2).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vals[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | if coord_str.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | if line.contains(":") && !line.ends_with(":") && line.len() > 5 { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:62:46 [INFO] [stderr] | [INFO] [stderr] 62 | if line.contains(":") && !line.ends_with(":") && line.len() > 5 { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | ayanamsas.insert(li.mode,li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | let mut vals:Vec = houses.get(li.mode.as_str()).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&houses[li.mode.as_str()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | let nv = li.values.get(0).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:82:56 [INFO] [stderr] | [INFO] [stderr] 82 | f64_map.insert("ascendant".to_string(),li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | f64_map.insert("ut".to_string(),li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | f64_map.insert("delta_t".to_string(),li.values.get(1).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:95:39 [INFO] [stderr] | [INFO] [stderr] 95 | f64_map.insert(li.key,li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | let vals = topo_bodies.get(k).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&topo_bodies[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | let geo = geo_bodies.get(k).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_bodies[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | body_lngs.insert("ascendant".to_string(), *fm.get("ascendant").unwrap() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fm["ascendant"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:135:41 [INFO] [stderr] | [INFO] [stderr] 135 | body_lngs.insert("mc".to_string(), *fm.get("mc").unwrap() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fm["mc"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:21:37 [INFO] [stderr] | [INFO] [stderr] 21 | let mut parts = line.trim().split(":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:33:37 [INFO] [stderr] | [INFO] [stderr] 33 | let vals:Vec = val_str.split(",").map(|s| value_string_to_f64(s, has_float_key(first.as_str()) )).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sweph.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / match cap { [INFO] [stderr] 36 | | Some(matches) => { [INFO] [stderr] 37 | | key_parts = match_key_parts(matches,first.as_str()); [INFO] [stderr] 38 | | }, [INFO] [stderr] 39 | | None => () [INFO] [stderr] 40 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let Some(matches) = cap { [INFO] [stderr] 36 | key_parts = match_key_parts(matches,first.as_str()); [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sweph.rs:54:3 [INFO] [stderr] | [INFO] [stderr] 54 | / match matches.get(2) { [INFO] [stderr] 55 | | Some(m1) => { [INFO] [stderr] 56 | | match m1.as_str() { [INFO] [stderr] 57 | | "-" => { [INFO] [stderr] ... | [INFO] [stderr] 80 | | _ => () [INFO] [stderr] 81 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(m1) = matches.get(2) { [INFO] [stderr] 55 | match m1.as_str() { [INFO] [stderr] 56 | "-" => { [INFO] [stderr] 57 | match matches.get(1) { [INFO] [stderr] 58 | Some(m2) => { [INFO] [stderr] 59 | if m2.as_str() == "ay" { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sweph.rs:58:11 [INFO] [stderr] | [INFO] [stderr] 58 | / match matches.get(1) { [INFO] [stderr] 59 | | Some(m2) => { [INFO] [stderr] 60 | | if m2.as_str() == "ay" { [INFO] [stderr] 61 | | str_section = "ayanamsas"; [INFO] [stderr] ... | [INFO] [stderr] 69 | | _ => () [INFO] [stderr] 70 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | if let Some(m2) = matches.get(1) { [INFO] [stderr] 59 | if m2.as_str() == "ay" { [INFO] [stderr] 60 | str_section = "ayanamsas"; [INFO] [stderr] 61 | str_mode = matches.get(3).unwrap().as_str(); [INFO] [stderr] 62 | } else { [INFO] [stderr] 63 | str_section = "houses"; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | let mut parts = datestr.split("T"); [INFO] [stderr] | ^^^ help: try using a char instead: `'T'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:140:33 [INFO] [stderr] | [INFO] [stderr] 140 | let dt:Vec<&str> = date.split("-").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:141:33 [INFO] [stderr] | [INFO] [stderr] 141 | let ti:Vec<&str> = time.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/sweph.rs:149:32 [INFO] [stderr] | [INFO] [stderr] 149 | let mut parts = coords.split(","); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `aspect_groups`. [INFO] [stderr] --> src/astro.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | for i in 0..num_aspect_groups { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 19 | for in aspect_groups.iter_mut().take(num_aspect_groups) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:170:14 [INFO] [stderr] | [INFO] [stderr] 170 | lat: items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:171:14 [INFO] [stderr] | [INFO] [stderr] 171 | lng: items.get(0).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:172:14 [INFO] [stderr] | [INFO] [stderr] 172 | spd: items.get(2).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:176:14 [INFO] [stderr] | [INFO] [stderr] 176 | lat: items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | lng: items.get(0).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:190:14 [INFO] [stderr] | [INFO] [stderr] 190 | lat: items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:191:14 [INFO] [stderr] | [INFO] [stderr] 191 | lng: items.get(0).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:192:14 [INFO] [stderr] | [INFO] [stderr] 192 | spd: items.get(2).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&items[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:193:15 [INFO] [stderr] | [INFO] [stderr] 193 | glat: geo_items.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_items[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:194:15 [INFO] [stderr] | [INFO] [stderr] 194 | glng: geo_items.get(0).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_items[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:195:15 [INFO] [stderr] | [INFO] [stderr] 195 | gspd: geo_items.get(2).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_items[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/astro.rs:232:63 [INFO] [stderr] | [INFO] [stderr] 232 | pub fn add_rahuketu(bodies:&mut HashMap>,vals:&Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:235:6 [INFO] [stderr] | [INFO] [stderr] 235 | (vals.get(0).unwrap().to_owned() + 180.0) % 360.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vals[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:236:5 [INFO] [stderr] | [INFO] [stderr] 236 | vals.get(1).unwrap().to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vals[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/astro.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | vals.get(2).unwrap().to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&vals[2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:27 [INFO] [stderr] | [INFO] [stderr] 28 | if coord_str.contains(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:62:22 [INFO] [stderr] | [INFO] [stderr] 62 | if line.contains(":") && !line.ends_with(":") && line.len() > 5 { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:62:46 [INFO] [stderr] | [INFO] [stderr] 62 | if line.contains(":") && !line.ends_with(":") && line.len() > 5 { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:72:38 [INFO] [stderr] | [INFO] [stderr] 72 | ayanamsas.insert(li.mode,li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:76:39 [INFO] [stderr] | [INFO] [stderr] 76 | let mut vals:Vec = houses.get(li.mode.as_str()).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&houses[li.mode.as_str()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | let nv = li.values.get(0).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:82:56 [INFO] [stderr] | [INFO] [stderr] 82 | f64_map.insert("ascendant".to_string(),li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | f64_map.insert("ut".to_string(),li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | f64_map.insert("delta_t".to_string(),li.values.get(1).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:95:39 [INFO] [stderr] | [INFO] [stderr] 95 | f64_map.insert(li.key,li.values.get(0).unwrap().to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&li.values[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:120:16 [INFO] [stderr] | [INFO] [stderr] 120 | let vals = topo_bodies.get(k).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&topo_bodies[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | let geo = geo_bodies.get(k).unwrap().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&geo_bodies[k]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:132:48 [INFO] [stderr] | [INFO] [stderr] 132 | body_lngs.insert("ascendant".to_string(), *fm.get("ascendant").unwrap() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fm["ascendant"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:135:41 [INFO] [stderr] | [INFO] [stderr] 135 | body_lngs.insert("mc".to_string(), *fm.get("mc").unwrap() ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&fm["mc"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.42s [INFO] running `"docker" "inspect" "267901360a833cce86a02437f9ac70fe56bff3bed0c2e0bc15c26f243cc180a0"` [INFO] running `"docker" "rm" "-f" "267901360a833cce86a02437f9ac70fe56bff3bed0c2e0bc15c26f243cc180a0"` [INFO] [stdout] 267901360a833cce86a02437f9ac70fe56bff3bed0c2e0bc15c26f243cc180a0