[INFO] updating cached repository neelayjunnarkar/Proj_Euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/neelayjunnarkar/Proj_Euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/neelayjunnarkar/Proj_Euler" "work/ex/clippy-test-run/sources/stable/gh/neelayjunnarkar/Proj_Euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/neelayjunnarkar/Proj_Euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/neelayjunnarkar/Proj_Euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neelayjunnarkar/Proj_Euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neelayjunnarkar/Proj_Euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2fcfe938b1c1c1701e44573307a329796fa3186f [INFO] sha for GitHub repo neelayjunnarkar/Proj_Euler: 2fcfe938b1c1c1701e44573307a329796fa3186f [INFO] validating manifest of neelayjunnarkar/Proj_Euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of neelayjunnarkar/Proj_Euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing neelayjunnarkar/Proj_Euler [INFO] finished frobbing neelayjunnarkar/Proj_Euler [INFO] frobbed toml for neelayjunnarkar/Proj_Euler written to work/ex/clippy-test-run/sources/stable/gh/neelayjunnarkar/Proj_Euler/Cargo.toml [INFO] started frobbing neelayjunnarkar/Proj_Euler [INFO] finished frobbing neelayjunnarkar/Proj_Euler [INFO] frobbed toml for neelayjunnarkar/Proj_Euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/neelayjunnarkar/Proj_Euler/Cargo.toml [INFO] crate neelayjunnarkar/Proj_Euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting neelayjunnarkar/Proj_Euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/neelayjunnarkar/Proj_Euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d916a5066572c5a08efe6501816b8b134159e4a3e5cf32b12c8ff81c1e0e064c [INFO] running `"docker" "start" "-a" "d916a5066572c5a08efe6501816b8b134159e4a3e5cf32b12c8ff81c1e0e064c"` [INFO] [stderr] Checking Proj_Euler v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob4.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob4.rs:11:38 [INFO] [stderr] | [INFO] [stderr] 11 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob5.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob5.rs:9:38 [INFO] [stderr] | [INFO] [stderr] 9 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob11.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob11.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob4.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob4.rs:11:38 [INFO] [stderr] | [INFO] [stderr] 11 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob5.rs:9:28 [INFO] [stderr] | [INFO] [stderr] 9 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prob5.rs:9:38 [INFO] [stderr] | [INFO] [stderr] 9 | Range{curr: start, end: end, step: step, next: start+step} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob11.rs:41:3 [INFO] [stderr] | [INFO] [stderr] 41 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/prob11.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::num::*` [INFO] [stderr] --> src/prob3.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::num::*; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prob3.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | let mut n: u64 = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob10.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: label name `'y_pos` shadows a label name that is already in scope [INFO] [stderr] --> src/prob11.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 90 | 'y_pos: for y in 0..(h-n_adjacents) { [INFO] [stderr] | ------ first declared here [INFO] [stderr] ... [INFO] [stderr] 106 | 'y_pos: for y in 0..(h-n_adjacents) { [INFO] [stderr] | ^^^^^^ lifetime 'y_pos already in scope [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::num::*` [INFO] [stderr] --> src/prob3.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::num::*; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prob3.rs:7:22 [INFO] [stderr] | [INFO] [stderr] 7 | let mut n: u64 = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prob10.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: label name `'y_pos` shadows a label name that is already in scope [INFO] [stderr] --> src/prob11.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 90 | 'y_pos: for y in 0..(h-n_adjacents) { [INFO] [stderr] | ------ first declared here [INFO] [stderr] ... [INFO] [stderr] 106 | 'y_pos: for y in 0..(h-n_adjacents) { [INFO] [stderr] | ^^^^^^ lifetime 'y_pos already in scope [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let mut temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | let mut temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: value assigned to `temp_max` is never read [INFO] [stderr] --> src/prob11.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | temp_max = 1; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `factorial` [INFO] [stderr] --> src/prob15.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | fn factorial(n: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `Proj_Euler` should have a snake case name such as `proj_euler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob1.rs:3:51 [INFO] [stderr] | [INFO] [stderr] 3 | (1..1000).filter(|&x|x % 3 == 0 || x % 5 == 0).fold(0, |acc, elem| acc+elem).to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob2.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | filter(|&f| f%2 == 0). [INFO] [stderr] | ______________________________^ [INFO] [stderr] 33 | | fold(0, |acc, item| acc+item) [INFO] [stderr] | |_____________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/prob4.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | self.next = self.next + self.step; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next += self.step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/prob4.rs:21:57 [INFO] [stderr] | [INFO] [stderr] 21 | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 22 | | None [INFO] [stderr] 23 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/prob4.rs:19:50 [INFO] [stderr] | [INFO] [stderr] 19 | if self.step > 0 && self.curr > self.end { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 20 | | None [INFO] [stderr] 21 | | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/prob5.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | self.next = self.next + self.step; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next += self.step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/prob5.rs:19:57 [INFO] [stderr] | [INFO] [stderr] 19 | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 20 | | None [INFO] [stderr] 21 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/prob5.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | if self.step > 0 && self.curr > self.end { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 18 | | None [INFO] [stderr] 19 | | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob6.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | (((1..101).fold(0, |acc, iter| acc+iter) as f32).powi(2) as u32 - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob6.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | (1..101).map(|x| x*x).fold(0, |acc, iter| acc+iter)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/prob7.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / (1..55_250).map(|x|x*2+1) [INFO] [stderr] 7 | | .filter(|&x| -> bool { [INFO] [stderr] 8 | | for prime in &primes { [INFO] [stderr] 9 | | if x % *prime == 0 && x != *prime { return false } [INFO] [stderr] ... | [INFO] [stderr] 14 | | }) [INFO] [stderr] 15 | | .collect::>(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/prob7.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / (1..55_250).map(|x|x*2+1) [INFO] [stderr] 7 | | .filter(|&x| -> bool { [INFO] [stderr] 8 | | for prime in &primes { [INFO] [stderr] 9 | | if x % *prime == 0 && x != *prime { return false } [INFO] [stderr] ... | [INFO] [stderr] 14 | | }) [INFO] [stderr] 15 | | .collect::>(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prob7.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | if *prime > (x as f64).sqrt() as u32 { break; } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob8.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|n| n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob8.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | .map(|x| x.iter().fold(1u64, |acc, &iter| acc*iter)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prob9.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | let c: f64 = ((a.pow(2) + b.pow(2)) as f64).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(a.pow(2) + b.pow(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/prob9.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if c == c.round() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(c - c.round()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/prob9.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if c == c.round() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob10.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | .filter(|&n| n <= 2_000_000) [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 14 | | .fold(0, |acc, item| acc+item)+2) [INFO] [stderr] | |______________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/prob11.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for x in 0..w { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for in grid.iter().take(w) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/prob11.rs:58:37 [INFO] [stderr] | [INFO] [stderr] 58 | 'y_beginnings: for y_beg in 0..(w-n_adjacents+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=w-n_adjacents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/prob11.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | 'x_beginnings: for x_beg in 0..(h-n_adjacents+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=h-n_adjacents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob12.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | self.curr += self.c as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob13.rs:106:50 [INFO] [stderr] | [INFO] [stderr] 106 | .filter_map(|s| (&s[0..13]).parse().ok()) [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 107 | | .fold(0, |acc, iter: u64| acc+iter) [INFO] [stderr] | |___________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `Proj_Euler`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: function is never used: `factorial` [INFO] [stderr] --> src/prob15.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | fn factorial(n: u64) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `Proj_Euler` should have a snake case name such as `proj_euler` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob1.rs:3:51 [INFO] [stderr] | [INFO] [stderr] 3 | (1..1000).filter(|&x|x % 3 == 0 || x % 5 == 0).fold(0, |acc, elem| acc+elem).to_string() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob2.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | filter(|&f| f%2 == 0). [INFO] [stderr] | ______________________________^ [INFO] [stderr] 33 | | fold(0, |acc, item| acc+item) [INFO] [stderr] | |_____________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/prob4.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | self.next = self.next + self.step; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next += self.step` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/prob4.rs:21:57 [INFO] [stderr] | [INFO] [stderr] 21 | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 22 | | None [INFO] [stderr] 23 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/prob4.rs:19:50 [INFO] [stderr] | [INFO] [stderr] 19 | if self.step > 0 && self.curr > self.end { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 20 | | None [INFO] [stderr] 21 | | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/prob5.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | self.next = self.next + self.step; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.next += self.step` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/prob5.rs:19:57 [INFO] [stderr] | [INFO] [stderr] 19 | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 20 | | None [INFO] [stderr] 21 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/prob5.rs:17:50 [INFO] [stderr] | [INFO] [stderr] 17 | if self.step > 0 && self.curr > self.end { [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 18 | | None [INFO] [stderr] 19 | | } else if self.step < 0 && self.curr < self.end { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob6.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | (((1..101).fold(0, |acc, iter| acc+iter) as f32).powi(2) as u32 - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob6.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | (1..101).map(|x| x*x).fold(0, |acc, iter| acc+iter)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/prob7.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / (1..55_250).map(|x|x*2+1) [INFO] [stderr] 7 | | .filter(|&x| -> bool { [INFO] [stderr] 8 | | for prime in &primes { [INFO] [stderr] 9 | | if x % *prime == 0 && x != *prime { return false } [INFO] [stderr] ... | [INFO] [stderr] 14 | | }) [INFO] [stderr] 15 | | .collect::>(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/prob7.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / (1..55_250).map(|x|x*2+1) [INFO] [stderr] 7 | | .filter(|&x| -> bool { [INFO] [stderr] 8 | | for prime in &primes { [INFO] [stderr] 9 | | if x % *prime == 0 && x != *prime { return false } [INFO] [stderr] ... | [INFO] [stderr] 14 | | }) [INFO] [stderr] 15 | | .collect::>(); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prob7.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | if *prime > (x as f64).sqrt() as u32 { break; } [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob8.rs:26:18 [INFO] [stderr] | [INFO] [stderr] 26 | .map(|n| n as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob8.rs:29:26 [INFO] [stderr] | [INFO] [stderr] 29 | .map(|x| x.iter().fold(1u64, |acc, &iter| acc*iter)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/prob9.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | let c: f64 = ((a.pow(2) + b.pow(2)) as f64).sqrt(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(a.pow(2) + b.pow(2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/prob9.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if c == c.round() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(c - c.round()).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/prob9.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if c == c.round() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob10.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | .filter(|&n| n <= 2_000_000) [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 14 | | .fold(0, |acc, item| acc+item)+2) [INFO] [stderr] | |______________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `grid`. [INFO] [stderr] --> src/prob11.rs:57:14 [INFO] [stderr] | [INFO] [stderr] 57 | for x in 0..w { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for in grid.iter().take(w) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/prob11.rs:58:37 [INFO] [stderr] | [INFO] [stderr] 58 | 'y_beginnings: for y_beg in 0..(w-n_adjacents+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=w-n_adjacents` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/prob11.rs:74:37 [INFO] [stderr] | [INFO] [stderr] 74 | 'x_beginnings: for x_beg in 0..(h-n_adjacents+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=h-n_adjacents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/prob12.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | self.curr += self.c as u64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(self.c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/prob13.rs:106:50 [INFO] [stderr] | [INFO] [stderr] 106 | .filter_map(|s| (&s[0..13]).parse().ok()) [INFO] [stderr] | __________________________________________________^ [INFO] [stderr] 107 | | .fold(0, |acc, iter: u64| acc+iter) [INFO] [stderr] | |___________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `Proj_Euler`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d916a5066572c5a08efe6501816b8b134159e4a3e5cf32b12c8ff81c1e0e064c"` [INFO] running `"docker" "rm" "-f" "d916a5066572c5a08efe6501816b8b134159e4a3e5cf32b12c8ff81c1e0e064c"` [INFO] [stdout] d916a5066572c5a08efe6501816b8b134159e4a3e5cf32b12c8ff81c1e0e064c