[INFO] updating cached repository needto/rust-vcv-parser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/needto/rust-vcv-parser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/needto/rust-vcv-parser" "work/ex/clippy-test-run/sources/stable/gh/needto/rust-vcv-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/needto/rust-vcv-parser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/needto/rust-vcv-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/needto/rust-vcv-parser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/needto/rust-vcv-parser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98620fe9aa4c4759feed9397c0e8f65a01a732d7 [INFO] sha for GitHub repo needto/rust-vcv-parser: 98620fe9aa4c4759feed9397c0e8f65a01a732d7 [INFO] validating manifest of needto/rust-vcv-parser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of needto/rust-vcv-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing needto/rust-vcv-parser [INFO] finished frobbing needto/rust-vcv-parser [INFO] frobbed toml for needto/rust-vcv-parser written to work/ex/clippy-test-run/sources/stable/gh/needto/rust-vcv-parser/Cargo.toml [INFO] started frobbing needto/rust-vcv-parser [INFO] finished frobbing needto/rust-vcv-parser [INFO] frobbed toml for needto/rust-vcv-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/needto/rust-vcv-parser/Cargo.toml [INFO] crate needto/rust-vcv-parser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting needto/rust-vcv-parser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/needto/rust-vcv-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0b4ae1fe77a7efb11d51a8133c1394fd00a12dc720ee8c9378ff8820d735d60f [INFO] running `"docker" "start" "-a" "0b4ae1fe77a7efb11d51a8133c1394fd00a12dc720ee8c9378ff8820d735d60f"` [INFO] [stderr] Compiling crc v1.7.0 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking libflate v0.1.14 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking vcv_parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vcv.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | plugin: plugin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `plugin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vcv.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vcv.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | plugin: plugin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `plugin` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/vcv.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patchstorage.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return parse_patch_list(resp.text().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_patch_list(resp.text().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patchstorage.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return urls; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `urls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patchstorage.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / return match media_info { [INFO] [stderr] 31 | | Some(media_info) => { [INFO] [stderr] 32 | | let mut resp = reqwest::get(&media_info.source_url).unwrap(); [INFO] [stderr] 33 | | assert!(resp.status().is_success()); [INFO] [stderr] ... | [INFO] [stderr] 36 | | None => None [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | match media_info { [INFO] [stderr] 31 | Some(media_info) => { [INFO] [stderr] 32 | let mut resp = reqwest::get(&media_info.source_url).unwrap(); [INFO] [stderr] 33 | assert!(resp.status().is_success()); [INFO] [stderr] 34 | Some(resp.text().unwrap()) [INFO] [stderr] 35 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vcv.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return vcv_patch.modules; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vcv_patch.modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patchstorage.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return parse_patch_list(resp.text().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_patch_list(resp.text().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patchstorage.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | return urls; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `urls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/patchstorage.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / return match media_info { [INFO] [stderr] 31 | | Some(media_info) => { [INFO] [stderr] 32 | | let mut resp = reqwest::get(&media_info.source_url).unwrap(); [INFO] [stderr] 33 | | assert!(resp.status().is_success()); [INFO] [stderr] ... | [INFO] [stderr] 36 | | None => None [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | match media_info { [INFO] [stderr] 31 | Some(media_info) => { [INFO] [stderr] 32 | let mut resp = reqwest::get(&media_info.source_url).unwrap(); [INFO] [stderr] 33 | assert!(resp.status().is_success()); [INFO] [stderr] 34 | Some(resp.text().unwrap()) [INFO] [stderr] 35 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/vcv.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return vcv_patch.modules; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vcv_patch.modules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/vcv.rs:33:56 [INFO] [stderr] | [INFO] [stderr] 33 | let module_statistic = self.entry(module_name).or_insert(ModuleStatistic::new(module_plugin, module_model)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| ModuleStatistic::new(module_plugin, module_model))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | for (_key, value) in statistics { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 28 | for value in statistics.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | for (_key, value) in statistics { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 44 | for value in statistics.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match receiver.recv().unwrap() { [INFO] [stderr] 88 | | Some(modules) => process_module_statistics(modules, &mut module_stats), [INFO] [stderr] 89 | | None => () [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(modules) = receiver.recv().unwrap() { process_module_statistics(modules, &mut module_stats) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/vcv.rs:33:56 [INFO] [stderr] | [INFO] [stderr] 33 | let module_statistic = self.entry(module_name).or_insert(ModuleStatistic::new(module_plugin, module_model)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| ModuleStatistic::new(module_plugin, module_model))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | for (_key, value) in statistics { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 28 | for value in statistics.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/main.rs:44:26 [INFO] [stderr] | [INFO] [stderr] 44 | for (_key, value) in statistics { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 44 | for value in statistics.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match receiver.recv().unwrap() { [INFO] [stderr] 88 | | Some(modules) => process_module_statistics(modules, &mut module_stats), [INFO] [stderr] 89 | | None => () [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(modules) = receiver.recv().unwrap() { process_module_statistics(modules, &mut module_stats) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.95s [INFO] running `"docker" "inspect" "0b4ae1fe77a7efb11d51a8133c1394fd00a12dc720ee8c9378ff8820d735d60f"` [INFO] running `"docker" "rm" "-f" "0b4ae1fe77a7efb11d51a8133c1394fd00a12dc720ee8c9378ff8820d735d60f"` [INFO] [stdout] 0b4ae1fe77a7efb11d51a8133c1394fd00a12dc720ee8c9378ff8820d735d60f