[INFO] updating cached repository ndrewtl/ellipsis
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/ndrewtl/ellipsis
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/ndrewtl/ellipsis" "work/ex/clippy-test-run/sources/stable/gh/ndrewtl/ellipsis"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ndrewtl/ellipsis'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/ndrewtl/ellipsis" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ndrewtl/ellipsis"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ndrewtl/ellipsis'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] b85ee54ca52deea5f00c93f9ac0fd1fdd6680fa2
[INFO] sha for GitHub repo ndrewtl/ellipsis: b85ee54ca52deea5f00c93f9ac0fd1fdd6680fa2
[INFO] validating manifest of ndrewtl/ellipsis on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ndrewtl/ellipsis on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ndrewtl/ellipsis
[INFO] finished frobbing ndrewtl/ellipsis
[INFO] frobbed toml for ndrewtl/ellipsis written to work/ex/clippy-test-run/sources/stable/gh/ndrewtl/ellipsis/Cargo.toml
[INFO] started frobbing ndrewtl/ellipsis
[INFO] finished frobbing ndrewtl/ellipsis
[INFO] frobbed toml for ndrewtl/ellipsis written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ndrewtl/ellipsis/Cargo.toml
[INFO] crate ndrewtl/ellipsis has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ndrewtl/ellipsis against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ndrewtl/ellipsis:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4b962cb6bf60e7ac69c56e13ce500489e2d415badb3ee92afb7eecc8f18e949c
[INFO] running `"docker" "start" "-a" "4b962cb6bf60e7ac69c56e13ce500489e2d415badb3ee92afb7eecc8f18e949c"`
[INFO] [stderr]     Checking shellexpand v1.0.0
[INFO] [stderr]    Compiling cmake v0.1.31
[INFO] [stderr]    Compiling libz-sys v1.0.18
[INFO] [stderr]    Compiling openssl-sys v0.9.33
[INFO] [stderr]    Compiling curl-sys v0.4.7
[INFO] [stderr]     Checking dirs v1.0.3
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking serde_json v1.0.19
[INFO] [stderr]    Compiling libssh2-sys v0.2.8
[INFO] [stderr]    Compiling libgit2-sys v0.7.6
[INFO] [stderr]     Checking git2 v0.7.3
[INFO] [stderr]     Checking ellipsis v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:98:12
[INFO] [stderr]     |
[INFO] [stderr] 98  |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 99  | |
[INFO] [stderr] 100 | |         if let Some(myhome) = dirs::home_dir() {
[INFO] [stderr] 101 | |             Some(myhome.join(".ellipsis"))
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |         }
[INFO] [stderr] 105 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 98  |     } else if let Some(myhome) = dirs::home_dir() {
[INFO] [stderr] 99  |     Some(myhome.join(".ellipsis"))
[INFO] [stderr] 100 | } else {
[INFO] [stderr] 101 |     None
[INFO] [stderr] 102 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:98:12
[INFO] [stderr]     |
[INFO] [stderr] 98  |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 99  | |
[INFO] [stderr] 100 | |         if let Some(myhome) = dirs::home_dir() {
[INFO] [stderr] 101 | |             Some(myhome.join(".ellipsis"))
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |         }
[INFO] [stderr] 105 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 98  |     } else if let Some(myhome) = dirs::home_dir() {
[INFO] [stderr] 99  |     Some(myhome.join(".ellipsis"))
[INFO] [stderr] 100 | } else {
[INFO] [stderr] 101 |     None
[INFO] [stderr] 102 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/ext.rs:21:28
[INFO] [stderr]    |
[INFO] [stderr] 21 |         env::var("EDITOR").unwrap_or(String::from("vi")))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("vi"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/link/mod.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let source = path::PathBuf::from(home_dir().unwrap())
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `path::PathBuf::from()`: `home_dir().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/ext.rs:21:28
[INFO] [stderr]    |
[INFO] [stderr] 21 |         env::var("EDITOR").unwrap_or(String::from("vi")))
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("vi"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/link/mod.rs:45:22
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let source = path::PathBuf::from(home_dir().unwrap())
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `path::PathBuf::from()`: `home_dir().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/unlink/test.rs:38:22
[INFO] [stderr]    |
[INFO] [stderr] 38 |         let source = path::PathBuf::from(home_dir().unwrap())
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `path::PathBuf::from()`: `home_dir().unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2m 56s
[INFO] running `"docker" "inspect" "4b962cb6bf60e7ac69c56e13ce500489e2d415badb3ee92afb7eecc8f18e949c"`
[INFO] running `"docker" "rm" "-f" "4b962cb6bf60e7ac69c56e13ce500489e2d415badb3ee92afb7eecc8f18e949c"`
[INFO] [stdout] 4b962cb6bf60e7ac69c56e13ce500489e2d415badb3ee92afb7eecc8f18e949c