[INFO] updating cached repository ndarilek/tma [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ndarilek/tma [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ndarilek/tma" "work/ex/clippy-test-run/sources/stable/gh/ndarilek/tma"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ndarilek/tma'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ndarilek/tma" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ndarilek/tma"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ndarilek/tma'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a3a45cc95363dfb7ad5544f80999ee9633ab2473 [INFO] sha for GitHub repo ndarilek/tma: a3a45cc95363dfb7ad5544f80999ee9633ab2473 [INFO] validating manifest of ndarilek/tma on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ndarilek/tma on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ndarilek/tma [INFO] finished frobbing ndarilek/tma [INFO] frobbed toml for ndarilek/tma written to work/ex/clippy-test-run/sources/stable/gh/ndarilek/tma/Cargo.toml [INFO] started frobbing ndarilek/tma [INFO] finished frobbing ndarilek/tma [INFO] frobbed toml for ndarilek/tma written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ndarilek/tma/Cargo.toml [INFO] crate ndarilek/tma has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ndarilek/tma against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ndarilek/tma:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef7016716d9d36711b24960029b67eafb4e66423182557bcf7cb26adeb12d1da [INFO] running `"docker" "start" "-a" "ef7016716d9d36711b24960029b67eafb4e66423182557bcf7cb26adeb12d1da"` [INFO] [stderr] Checking clap v2.29.1 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking stderrlog v0.2.3 [INFO] [stderr] Checking structopt v0.1.6 [INFO] [stderr] Checking tma v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:64:50 [INFO] [stderr] | [INFO] [stderr] 64 | toml::from_str(content.as_str()).map_err(|e| err_msg(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `err_msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | self.root.as_ref().map(|r| session_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.root.as_ref() { session_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | self.window[0].root.as_ref().map(|r| window_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.window[0].root.as_ref() { window_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:64:50 [INFO] [stderr] | [INFO] [stderr] 64 | toml::from_str(content.as_str()).map_err(|e| err_msg(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `err_msg` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | self.root.as_ref().map(|r| session_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.root.as_ref() { session_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | self.window[0].root.as_ref().map(|r| window_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.window[0].root.as_ref() { window_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | self.root.as_ref().map(|r| window_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.root.as_ref() { window_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:156:9 [INFO] [stderr] | [INFO] [stderr] 156 | self.root.as_ref().map(|r| window_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.root.as_ref() { window_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | self.root.as_ref().map(|r| pane_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.root.as_ref() { pane_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | self.split.as_ref().map(|s| if s == "horizontal" { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 224 | || args.push("-h"); [INFO] [stderr] 225 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(s) = self.split.as_ref() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:211:13 [INFO] [stderr] | [INFO] [stderr] 211 | self.root.as_ref().map(|r| pane_root.push(r)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(r) = self.root.as_ref() { pane_root.push(r) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | self.split.as_ref().map(|s| if s == "horizontal" { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 224 | || args.push("-h"); [INFO] [stderr] 225 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(s) = self.split.as_ref() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.72s [INFO] running `"docker" "inspect" "ef7016716d9d36711b24960029b67eafb4e66423182557bcf7cb26adeb12d1da"` [INFO] running `"docker" "rm" "-f" "ef7016716d9d36711b24960029b67eafb4e66423182557bcf7cb26adeb12d1da"` [INFO] [stdout] ef7016716d9d36711b24960029b67eafb4e66423182557bcf7cb26adeb12d1da