[INFO] updating cached repository nbabson/RustAdventure [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nbabson/RustAdventure [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nbabson/RustAdventure" "work/ex/clippy-test-run/sources/stable/gh/nbabson/RustAdventure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nbabson/RustAdventure'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nbabson/RustAdventure" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nbabson/RustAdventure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nbabson/RustAdventure'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c51eab3ef9f3fc5fdd133d1d3d86cd93a65bc1e [INFO] sha for GitHub repo nbabson/RustAdventure: 9c51eab3ef9f3fc5fdd133d1d3d86cd93a65bc1e [INFO] validating manifest of nbabson/RustAdventure on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nbabson/RustAdventure on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nbabson/RustAdventure [INFO] finished frobbing nbabson/RustAdventure [INFO] frobbed toml for nbabson/RustAdventure written to work/ex/clippy-test-run/sources/stable/gh/nbabson/RustAdventure/Cargo.toml [INFO] started frobbing nbabson/RustAdventure [INFO] finished frobbing nbabson/RustAdventure [INFO] frobbed toml for nbabson/RustAdventure written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nbabson/RustAdventure/Cargo.toml [INFO] crate nbabson/RustAdventure has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nbabson/RustAdventure against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nbabson/RustAdventure:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67acca4f803d631a29c82a3a4b1287e98952e8cd51e5be9457544362ae3a8432 [INFO] running `"docker" "start" "-a" "67acca4f803d631a29c82a3a4b1287e98952e8cd51e5be9457544362ae3a8432"` [INFO] [stderr] Checking rust_adventure v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn new(n: String, d: String, w: f32, c: Option, v: Visibility) -> Item { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/util.rs:59:65 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn new(n: String, d: String, w: f32, c: Option, v: Visibility) -> Item { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_command<'a,'b>(player: &'a mut Player, dictionary: &HashSet<&str>) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `words`. [INFO] [stderr] --> src/main.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for in words.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | if answer.trim() != "no".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"no"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:8 [INFO] [stderr] | [INFO] [stderr] 131 | if player.inventory.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `player.inventory.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | fn try_to_move(world: &Vec, dir: Direction, old_location: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Location]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:310:24 [INFO] [stderr] | [INFO] [stderr] 310 | if &object.contains.as_ref().unwrap() == &(&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 310 | if object.contains.as_ref().unwrap() == (&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:346:68 [INFO] [stderr] | [INFO] [stderr] 346 | == item.name) && item.visibility != Hidden { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 347 | | found = true; [INFO] [stderr] 348 | | found_at = i; [INFO] [stderr] 349 | | if player.weight + item.weight > MAX_WEIGHT { [INFO] [stderr] ... | [INFO] [stderr] 355 | | println!("You take the {}.", item.name); [INFO] [stderr] 356 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:334:114 [INFO] [stderr] | [INFO] [stderr] 334 | if command.len() > command_index && command[command_index] == item.name && item.visibility != Hidden { [INFO] [stderr] | __________________________________________________________________________________________________________________^ [INFO] [stderr] 335 | | found = true; [INFO] [stderr] 336 | | found_at = i; [INFO] [stderr] 337 | | if player.weight + item.weight > MAX_WEIGHT { [INFO] [stderr] ... | [INFO] [stderr] 343 | | println!("You take the {}.", item.name); [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:364:24 [INFO] [stderr] | [INFO] [stderr] 364 | if &object.contains.as_ref().unwrap() == &(&world[location_index].items[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 364 | if object.contains.as_ref().unwrap() == (&world[location_index].items[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:393:16 [INFO] [stderr] | [INFO] [stderr] 393 | fn look(world: &Vec, location_index: usize, command: Vec, mut command_index: usize, mut player: &mut Player) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Location]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:430:33 [INFO] [stderr] | [INFO] [stderr] 430 | if &player.inventory[i].contains.as_ref().unwrap() == &(&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 430 | if player.inventory[i].contains.as_ref().unwrap() == (&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:473:12 [INFO] [stderr] | [INFO] [stderr] 473 | if &player.inventory[i].name == item { [INFO] [stderr] | -------------------------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `player.inventory[i].name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_adventure`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/locations.rs:33:10 [INFO] [stderr] | [INFO] [stderr] 33 | let i = objects.get("hat").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&objects["hat"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/locations.rs:35:10 [INFO] [stderr] | [INFO] [stderr] 35 | let w = objects.get("crystal ball").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&objects["crystal ball"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/locations.rs:36:2 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(6.5, w.weight); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/locations.rs:36:2 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(6.5, w.weight); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | fn get_command<'a,'b>(player: &'a mut Player, dictionary: &HashSet<&str>) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `words`. [INFO] [stderr] --> src/main.rs:89:22 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for in words.iter().take(len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:122:25 [INFO] [stderr] | [INFO] [stderr] 122 | if answer.trim() != "no".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"no"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:131:8 [INFO] [stderr] | [INFO] [stderr] 131 | if player.inventory.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `player.inventory.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | fn try_to_move(world: &Vec, dir: Direction, old_location: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Location]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:310:24 [INFO] [stderr] | [INFO] [stderr] 310 | if &object.contains.as_ref().unwrap() == &(&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 310 | if object.contains.as_ref().unwrap() == (&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:346:68 [INFO] [stderr] | [INFO] [stderr] 346 | == item.name) && item.visibility != Hidden { [INFO] [stderr] | ____________________________________________________________________^ [INFO] [stderr] 347 | | found = true; [INFO] [stderr] 348 | | found_at = i; [INFO] [stderr] 349 | | if player.weight + item.weight > MAX_WEIGHT { [INFO] [stderr] ... | [INFO] [stderr] 355 | | println!("You take the {}.", item.name); [INFO] [stderr] 356 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:334:114 [INFO] [stderr] | [INFO] [stderr] 334 | if command.len() > command_index && command[command_index] == item.name && item.visibility != Hidden { [INFO] [stderr] | __________________________________________________________________________________________________________________^ [INFO] [stderr] 335 | | found = true; [INFO] [stderr] 336 | | found_at = i; [INFO] [stderr] 337 | | if player.weight + item.weight > MAX_WEIGHT { [INFO] [stderr] ... | [INFO] [stderr] 343 | | println!("You take the {}.", item.name); [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:364:24 [INFO] [stderr] | [INFO] [stderr] 364 | if &object.contains.as_ref().unwrap() == &(&world[location_index].items[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 364 | if object.contains.as_ref().unwrap() == (&world[location_index].items[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:393:16 [INFO] [stderr] | [INFO] [stderr] 393 | fn look(world: &Vec, location_index: usize, command: Vec, mut command_index: usize, mut player: &mut Player) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Location]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/main.rs:430:33 [INFO] [stderr] | [INFO] [stderr] 430 | if &player.inventory[i].contains.as_ref().unwrap() == &(&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 430 | if player.inventory[i].contains.as_ref().unwrap() == (&player.inventory[j].name) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/main.rs:473:12 [INFO] [stderr] | [INFO] [stderr] 473 | if &player.inventory[i].name == item { [INFO] [stderr] | -------------------------^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `player.inventory[i].name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_adventure`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "67acca4f803d631a29c82a3a4b1287e98952e8cd51e5be9457544362ae3a8432"` [INFO] running `"docker" "rm" "-f" "67acca4f803d631a29c82a3a4b1287e98952e8cd51e5be9457544362ae3a8432"` [INFO] [stdout] 67acca4f803d631a29c82a3a4b1287e98952e8cd51e5be9457544362ae3a8432