[INFO] updating cached repository nayato/length-push [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nayato/length-push [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nayato/length-push" "work/ex/clippy-test-run/sources/stable/gh/nayato/length-push"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nayato/length-push'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nayato/length-push" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nayato/length-push"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nayato/length-push'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e11a3187492a061d533f3a5b3c082e1d80a05539 [INFO] sha for GitHub repo nayato/length-push: e11a3187492a061d533f3a5b3c082e1d80a05539 [INFO] validating manifest of nayato/length-push on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nayato/length-push on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nayato/length-push [INFO] finished frobbing nayato/length-push [INFO] frobbed toml for nayato/length-push written to work/ex/clippy-test-run/sources/stable/gh/nayato/length-push/Cargo.toml [INFO] started frobbing nayato/length-push [INFO] finished frobbing nayato/length-push [INFO] frobbed toml for nayato/length-push written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nayato/length-push/Cargo.toml [INFO] crate nayato/length-push has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nayato/length-push against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nayato/length-push:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a9d45e21085c50086bfeeabd1b36e3ad82195214f42f335708f5c41d86407af [INFO] running `"docker" "start" "-a" "5a9d45e21085c50086bfeeabd1b36e3ad82195214f42f335708f5c41d86407af"` [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling syn v0.14.6 [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Checking tokio-core v0.1.12 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking sct v0.3.0 [INFO] [stderr] Checking webpki v0.18.1 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking rustls v0.12.0 [INFO] [stderr] Checking tokio-rustls v0.5.0 [INFO] [stderr] Checking length-push v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments` [INFO] [stderr] --> src/error.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(unused_doc_comment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `unused_doc_comment` has been renamed to `unused_doc_comments` [INFO] [stderr] --> src/error.rs:1:10 [INFO] [stderr] | [INFO] [stderr] 1 | #![allow(unused_doc_comment)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use the new name: `unused_doc_comments` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/counters.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | monitor_thread [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/counters.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | let monitor_thread = thread::Builder::new() [INFO] [stderr] | __________________________^ [INFO] [stderr] 68 | | .name("monitor".to_string()) [INFO] [stderr] 69 | | .spawn(move || { [INFO] [stderr] 70 | | thread::sleep(Duration::from_secs(warmup_seconds)); [INFO] [stderr] ... | [INFO] [stderr] 95 | | }) [INFO] [stderr] 96 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `codec::LengthCodec` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | use codec::LengthCodec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/counters.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | monitor_thread [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/counters.rs:67:26 [INFO] [stderr] | [INFO] [stderr] 67 | let monitor_thread = thread::Builder::new() [INFO] [stderr] | __________________________^ [INFO] [stderr] 68 | | .name("monitor".to_string()) [INFO] [stderr] 69 | | .spawn(move || { [INFO] [stderr] 70 | | thread::sleep(Duration::from_secs(warmup_seconds)); [INFO] [stderr] ... | [INFO] [stderr] 95 | | }) [INFO] [stderr] 96 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `codec::LengthCodec` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | use codec::LengthCodec; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `offset` [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | offset: usize, [INFO] [stderr] | ^^^^^^ help: consider using `_offset` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `LengthCodec` [INFO] [stderr] --> src/codec.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct LengthCodec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/codec.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> LengthCodec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `counters::PerfCounters` [INFO] [stderr] --> src/counters.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> PerfCounters { [INFO] [stderr] 22 | | PerfCounters { [INFO] [stderr] 23 | | req: AtomicUsize::new(0), [INFO] [stderr] 24 | | lat: AtomicUsize::new(0), [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `offset` [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | offset: usize, [INFO] [stderr] | ^^^^^^ help: consider using `_offset` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `LengthCodec` [INFO] [stderr] --> src/codec.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub struct LengthCodec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/codec.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new() -> LengthCodec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `counters::PerfCounters` [INFO] [stderr] --> src/counters.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> PerfCounters { [INFO] [stderr] 22 | | PerfCounters { [INFO] [stderr] 23 | | req: AtomicUsize::new(0), [INFO] [stderr] 24 | | lat: AtomicUsize::new(0), [INFO] [stderr] ... | [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.42s [INFO] running `"docker" "inspect" "5a9d45e21085c50086bfeeabd1b36e3ad82195214f42f335708f5c41d86407af"` [INFO] running `"docker" "rm" "-f" "5a9d45e21085c50086bfeeabd1b36e3ad82195214f42f335708f5c41d86407af"` [INFO] [stdout] 5a9d45e21085c50086bfeeabd1b36e3ad82195214f42f335708f5c41d86407af