[INFO] updating cached repository natir/yacrd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/natir/yacrd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/natir/yacrd" "work/ex/clippy-test-run/sources/stable/gh/natir/yacrd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/natir/yacrd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/natir/yacrd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/yacrd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/yacrd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3fc6ef8b5b51256f0c4bc45b8056167acf34fa58 [INFO] sha for GitHub repo natir/yacrd: 3fc6ef8b5b51256f0c4bc45b8056167acf34fa58 [INFO] validating manifest of natir/yacrd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of natir/yacrd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing natir/yacrd [INFO] finished frobbing natir/yacrd [INFO] frobbed toml for natir/yacrd written to work/ex/clippy-test-run/sources/stable/gh/natir/yacrd/Cargo.toml [INFO] started frobbing natir/yacrd [INFO] finished frobbing natir/yacrd [INFO] frobbed toml for natir/yacrd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/yacrd/Cargo.toml [INFO] crate natir/yacrd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting natir/yacrd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/natir/yacrd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 125c13742b3e65b83ed09dd6a05150d8335d92d9162b4d9193456831089e67f1 [INFO] running `"docker" "start" "-a" "125c13742b3e65b83ed09dd6a05150d8335d92d9162b4d9193456831089e67f1"` [INFO] [stderr] Compiling serde v1.0.70 [INFO] [stderr] Compiling ndarray v0.9.1 [INFO] [stderr] Compiling bv v0.7.4 [INFO] [stderr] Checking bytecount v0.3.1 [INFO] [stderr] Compiling filetime v0.2.1 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling newtype_derive v0.1.6 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Compiling syn v0.14.4 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Compiling lzma-sys v0.1.10 [INFO] [stderr] Checking itertools-num v0.1.1 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking xz2 v0.1.5 [INFO] [stderr] Compiling serde_derive v1.0.70 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking serde_json v1.0.31 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking bio v0.21.0 [INFO] [stderr] Checking yacrd v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:143:50 [INFO] [stderr] | [INFO] [stderr] 143 | let good: HashSet<&str> = expected.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:161:24 [INFO] [stderr] | [INFO] [stderr] 161 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:175:50 [INFO] [stderr] | [INFO] [stderr] 175 | let good: HashSet<&str> = expected.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:204:46 [INFO] [stderr] | [INFO] [stderr] 204 | let result = proxy_deflate.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:235:50 [INFO] [stderr] | [INFO] [stderr] 235 | let good: HashSet<&str> = expected.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:266:28 [INFO] [stderr] | [INFO] [stderr] 266 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:334:50 [INFO] [stderr] | [INFO] [stderr] 334 | let good: HashSet<&str> = expected.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:353:24 [INFO] [stderr] | [INFO] [stderr] 353 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chimera.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / return match r { [INFO] [stderr] 88 | | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 89 | | _ => r, [INFO] [stderr] 90 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 87 | match r { [INFO] [stderr] 88 | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 89 | _ => r, [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:362:22 [INFO] [stderr] | [INFO] [stderr] 362 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:366:28 [INFO] [stderr] | [INFO] [stderr] 366 | const PAF_FILE_COV_1: &'static [u8] = b"1\t10000\t0\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:373:35 [INFO] [stderr] | [INFO] [stderr] 373 | const PAF_FILE_NOTCOV_PRIOR: &'static [u8] = b"1\t10000\t4000\t4500\t-\t2\t10000\t1000\t9000\t7000\t7000\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:377:35 [INFO] [stderr] | [INFO] [stderr] 377 | const PAF_FILE_NOTCOV_OVEXT: &'static [u8] = b"1\t10000\t500\t1500\t-\t2\t10000\t1000\t9000\t7000\t7000\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:381:23 [INFO] [stderr] | [INFO] [stderr] 381 | const MHAP_FILE: &'static [u8] = b"1 2 0.1 2 0 20 4500 12000 0 5500 10000 10000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:385:38 [INFO] [stderr] | [INFO] [stderr] 385 | const MHAP_FILE_MIN_MERS_FLOAT: &'static [u8] = b"1 2 0.1 2.0 0 20 4500 12000 0 5500 10000 10000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:389:30 [INFO] [stderr] | [INFO] [stderr] 389 | const NOT_COVERED_FILE: &'static [u8] = b"1\t10000\t1000\t10000\t-\t2\t10000\t0\t9000\t9000\t9000\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/file.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x00FD_377A_585A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return get_readable_file(input_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_readable_file(input_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (4 - i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (1 - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | const GZIP_FILE: &'static [u8] = &[0o037, 0o213, 0o0, 0o0, 0o0]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | const BZIP_FILE: &'static [u8] = &[0o102, 0o132, 0o0, 0o0, 0o0]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:168:23 [INFO] [stderr] | [INFO] [stderr] 168 | const LZMA_FILE: &'static [u8] = &[0o375, 0o067, 0o172, 0o130, 0o132]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:161:23 [INFO] [stderr] | [INFO] [stderr] 161 | const MHAP_FILE: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:165:20 [INFO] [stderr] | [INFO] [stderr] 165 | const READ_A: &'static [&str; 2] = &["1", "1"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:166:20 [INFO] [stderr] | [INFO] [stderr] 166 | const READ_B: &'static [&str; 2] = &["2", "3"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:167:19 [INFO] [stderr] | [INFO] [stderr] 167 | const ERROR: &'static [f64; 2] = &[0.1, 0.1]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[f64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:168:29 [INFO] [stderr] | [INFO] [stderr] 168 | const SHARED_MIN_MERS: &'static [f64; 2] = &[2.0, 2.0]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[f64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:169:22 [INFO] [stderr] | [INFO] [stderr] 169 | const STRAND_A: &'static [char; 2] = &['0', '0']; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[char; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | const STRAND_B: &'static [char; 2] = &['0', '0']; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[char; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | const BEGIN_A: &'static [u64; 2] = &[100, 550]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:172:19 [INFO] [stderr] | [INFO] [stderr] 172 | const END_A: &'static [u64; 2] = &[450, 900]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:173:22 [INFO] [stderr] | [INFO] [stderr] 173 | const LENGTH_A: &'static [u64; 2] = &[1000, 1000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | const BEGIN_B: &'static [u64; 2] = &[550, 100]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:175:19 [INFO] [stderr] | [INFO] [stderr] 175 | const END_B: &'static [u64; 2] = &[900, 450]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:176:22 [INFO] [stderr] | [INFO] [stderr] 176 | const LENGTH_B: &'static [u64; 2] = &[1000, 1000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:175:32 [INFO] [stderr] | [INFO] [stderr] 175 | const PAF_SAM_FIELD_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255\tam:I:5 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | const READ_A: &'static [&str; 2] = &["1", "1"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:180:22 [INFO] [stderr] | [INFO] [stderr] 180 | const LENGTH_A: &'static [u64; 2] = &[12000, 12000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | const BEGIN_A: &'static [u64; 2] = &[20, 5500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:182:19 [INFO] [stderr] | [INFO] [stderr] 182 | const END_A: &'static [u64; 2] = &[4500, 10000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:183:20 [INFO] [stderr] | [INFO] [stderr] 183 | const STRAND: &'static [char; 2] = &['-', '-']; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[char; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:184:20 [INFO] [stderr] | [INFO] [stderr] 184 | const READ_B: &'static [&str; 2] = &["2", "3"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:185:22 [INFO] [stderr] | [INFO] [stderr] 185 | const LENGTH_B: &'static [u64; 2] = &[10000, 10000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:186:21 [INFO] [stderr] | [INFO] [stderr] 186 | const BEGIN_B: &'static [u64; 2] = &[5500, 0]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:187:19 [INFO] [stderr] | [INFO] [stderr] 187 | const END_B: &'static [u64; 2] = &[10000, 4500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | const NB_MATCH_BASE: &'static [u64; 2] = &[4500, 4500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | const NB_BASE: &'static [u64; 2] = &[4500, 4500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:190:29 [INFO] [stderr] | [INFO] [stderr] 190 | const MAPPING_QUALITY: &'static [u64; 2] = &[255, 255]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return match get_format(filename) { [INFO] [stderr] 58 | | e @ Some(Format::Paf) | [INFO] [stderr] 59 | | e @ Some(Format::Mhap) => e, [INFO] [stderr] 60 | | _ => None, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match get_format(filename) { [INFO] [stderr] 58 | e @ Some(Format::Paf) | [INFO] [stderr] 59 | e @ Some(Format::Mhap) => e, [INFO] [stderr] 60 | _ => None, [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / return if filename == "-" { [INFO] [stderr] 66 | | Some(Format::Paf) [INFO] [stderr] 67 | | } else if filename.contains(".paf") { [INFO] [stderr] 68 | | Some(Format::Paf) [INFO] [stderr] ... | [INFO] [stderr] 76 | | None [INFO] [stderr] 77 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | if filename == "-" { [INFO] [stderr] 66 | Some(Format::Paf) [INFO] [stderr] 67 | } else if filename.contains(".paf") { [INFO] [stderr] 68 | Some(Format::Paf) [INFO] [stderr] 69 | } else if filename.contains(".mhap") { [INFO] [stderr] 70 | Some(Format::Mhap) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/paf.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/paf.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/paf.rs:123:22 [INFO] [stderr] | [INFO] [stderr] 123 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/paf.rs:127:30 [INFO] [stderr] | [INFO] [stderr] 127 | const PAF_FILE_FILTRED: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/paf.rs:148:32 [INFO] [stderr] | [INFO] [stderr] 148 | const PAF_FILE_EXTRACTED: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mhap.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mhap.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/mhap.rs:123:23 [INFO] [stderr] | [INFO] [stderr] 123 | const MHAP_FILE: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/mhap.rs:127:31 [INFO] [stderr] | [INFO] [stderr] 127 | const MHAP_FILE_FILTRED: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/mhap.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | const MHAP_FILE_EXTRACTED: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fasta.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fasta.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fasta.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return subrecord; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `subrecord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fasta.rs:179:24 [INFO] [stderr] | [INFO] [stderr] 179 | const FASTA_FILE: &'static [u8] = b">1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fasta.rs:187:32 [INFO] [stderr] | [INFO] [stderr] 187 | const FASTA_FILE_FILTRED: &'static [u8] = b">2 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fasta.rs:212:34 [INFO] [stderr] | [INFO] [stderr] 212 | const FASTA_FILE_EXTRACTED: &'static [u8] = b">1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fasta.rs:235:34 [INFO] [stderr] | [INFO] [stderr] 235 | const FASTA_FILE_SPLITABLE: &'static [u8] = b">1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fasta.rs:243:32 [INFO] [stderr] | [INFO] [stderr] 243 | const FASTA_FILE_SPLITED: &'static [u8] = b">1_0_4 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fasta.rs:275:30 [INFO] [stderr] | [INFO] [stderr] 275 | const SHORT_FASTA_FILE: &'static [u8] = b">1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fasta.rs:283:36 [INFO] [stderr] | [INFO] [stderr] 283 | const SHORT_FASTA_FILE_SPLIT: &'static [u8] = b">1_0_4 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fastq.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fastq.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fastq.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return subrecord; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `subrecord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fastq.rs:180:24 [INFO] [stderr] | [INFO] [stderr] 180 | const FASTQ_FILE: &'static [u8] = b"@1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fastq.rs:194:32 [INFO] [stderr] | [INFO] [stderr] 194 | const FASTQ_FILE_FILTRED: &'static [u8] = b"@2 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fastq.rs:223:34 [INFO] [stderr] | [INFO] [stderr] 223 | const FASTQ_FILE_EXTRACTED: &'static [u8] = b"@1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fastq.rs:248:34 [INFO] [stderr] | [INFO] [stderr] 248 | const FASTQ_FILE_SPLITABLE: &'static [u8] = b"@1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/postdetection/fastq.rs:262:30 [INFO] [stderr] | [INFO] [stderr] 262 | const FASTQ_FILE_SPLIT: &'static [u8] = b"@1_0_4 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mod.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return begin < length || end < length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `begin < length || end < length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return buffer.to_str().unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer.to_str().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chimera.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / return match r { [INFO] [stderr] 88 | | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 89 | | _ => r, [INFO] [stderr] 90 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 87 | match r { [INFO] [stderr] 88 | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 89 | _ => r, [INFO] [stderr] 90 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/file.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x00FD_377A_585A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return get_readable_file(input_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_readable_file(input_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (4 - i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (1 - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return match get_format(filename) { [INFO] [stderr] 58 | | e @ Some(Format::Paf) | [INFO] [stderr] 59 | | e @ Some(Format::Mhap) => e, [INFO] [stderr] 60 | | _ => None, [INFO] [stderr] 61 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | match get_format(filename) { [INFO] [stderr] 58 | e @ Some(Format::Paf) | [INFO] [stderr] 59 | e @ Some(Format::Mhap) => e, [INFO] [stderr] 60 | _ => None, [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / return if filename == "-" { [INFO] [stderr] 66 | | Some(Format::Paf) [INFO] [stderr] 67 | | } else if filename.contains(".paf") { [INFO] [stderr] 68 | | Some(Format::Paf) [INFO] [stderr] ... | [INFO] [stderr] 76 | | None [INFO] [stderr] 77 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 65 | if filename == "-" { [INFO] [stderr] 66 | Some(Format::Paf) [INFO] [stderr] 67 | } else if filename.contains(".paf") { [INFO] [stderr] 68 | Some(Format::Paf) [INFO] [stderr] 69 | } else if filename.contains(".mhap") { [INFO] [stderr] 70 | Some(Format::Mhap) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/paf.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/paf.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mhap.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mhap.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fasta.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fasta.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fasta.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return subrecord; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `subrecord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fastq.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fastq.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return Vec::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Vec::new()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/fastq.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return subrecord; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `subrecord` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mod.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return begin < length || end < length; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `begin < length || end < length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/postdetection/mod.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return buffer.to_str().unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer.to_str().unwrap().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | / output.write(&json!(map).to_string().into_bytes()).expect( [INFO] [stderr] 240 | | "Error durring write result in json format", [INFO] [stderr] 241 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chimera.rs:254:11 [INFO] [stderr] | [INFO] [stderr] 254 | gaps: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Interval]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chimera.rs:253:10 [INFO] [stderr] | [INFO] [stderr] 253 | len: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / output.write(b"\n").expect( [INFO] [stderr] 265 | | "Error durring writting of result", [INFO] [stderr] 266 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | / output.write(b";").expect( [INFO] [stderr] 280 | | "Error durring writting of result", [INFO] [stderr] 281 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:321:35 [INFO] [stderr] | [INFO] [stderr] 321 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:322:35 [INFO] [stderr] | [INFO] [stderr] 322 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:350:35 [INFO] [stderr] | [INFO] [stderr] 350 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:351:35 [INFO] [stderr] | [INFO] [stderr] 351 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:81:61 [INFO] [stderr] | [INFO] [stderr] 81 | _ => Box::new(BufReader::new(File::open(input_name).expect(&format!( [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 82 | | "Can't open input file {}", [INFO] [stderr] 83 | | input_name [INFO] [stderr] 84 | | )))), [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Can't open input file {}", input_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 97 | for (i, ) in buf.iter().enumerate().take(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (i, ) in buf.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:154:64 [INFO] [stderr] | [INFO] [stderr] 154 | _ => Box::new(BufWriter::new(File::create(output_name).expect(&format!( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 155 | | "Can't open output file {}", [INFO] [stderr] 156 | | output_name [INFO] [stderr] 157 | | )))), [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Can't open output file {}", output_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/mhap.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/mhap.rs:121:36 [INFO] [stderr] | [INFO] [stderr] 121 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/io/paf.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | / let mut sam_field = Vec::new(); [INFO] [stderr] 76 | | if mapping_quality_and_sam.len() > 1 { [INFO] [stderr] 77 | | sam_field = mapping_quality_and_sam[1..].to_vec(); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let sam_field = if mapping_quality_and_sam.len() > 1 { mapping_quality_and_sam[1..].to_vec() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/paf.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/paf.rs:130:36 [INFO] [stderr] | [INFO] [stderr] 130 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/utils.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | } else if filename.contains(".paf") { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 68 | | Some(Format::Paf) [INFO] [stderr] 69 | | } else if filename.contains(".mhap") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/utils.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | return if filename == "-" { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 66 | | Some(Format::Paf) [INFO] [stderr] 67 | | } else if filename.contains(".paf") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:193:27 [INFO] [stderr] | [INFO] [stderr] 193 | let filters: Vec<_> = match matches.is_present("filter") { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 194 | | true => matches.values_of("filter").unwrap().collect(), [INFO] [stderr] 195 | | false => Vec::new(), [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("filter") { matches.values_of("filter").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:197:28 [INFO] [stderr] | [INFO] [stderr] 197 | let extracts: Vec<_> = match matches.is_present("extract") { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 198 | | true => matches.values_of("extract").unwrap().collect(), [INFO] [stderr] 199 | | false => Vec::new(), [INFO] [stderr] 200 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("extract") { matches.values_of("extract").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:201:26 [INFO] [stderr] | [INFO] [stderr] 201 | let splits: Vec<_> = match matches.is_present("split") { [INFO] [stderr] | __________________________^ [INFO] [stderr] 202 | | true => matches.values_of("split").unwrap().collect(), [INFO] [stderr] 203 | | false => Vec::new(), [INFO] [stderr] 204 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("split") { matches.values_of("split").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yacrd`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:239:9 [INFO] [stderr] | [INFO] [stderr] 239 | / output.write(&json!(map).to_string().into_bytes()).expect( [INFO] [stderr] 240 | | "Error durring write result in json format", [INFO] [stderr] 241 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/chimera.rs:254:11 [INFO] [stderr] | [INFO] [stderr] 254 | gaps: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Interval]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/chimera.rs:253:10 [INFO] [stderr] | [INFO] [stderr] 253 | len: &u64, [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / output.write(b"\n").expect( [INFO] [stderr] 265 | | "Error durring writting of result", [INFO] [stderr] 266 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | / output.write(b";").expect( [INFO] [stderr] 280 | | "Error durring writting of result", [INFO] [stderr] 281 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:321:35 [INFO] [stderr] | [INFO] [stderr] 321 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:322:35 [INFO] [stderr] | [INFO] [stderr] 322 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:350:35 [INFO] [stderr] | [INFO] [stderr] 350 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:351:35 [INFO] [stderr] | [INFO] [stderr] 351 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:450:48 [INFO] [stderr] | [INFO] [stderr] 450 | let good: HashSet<&str> = result.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:466:24 [INFO] [stderr] | [INFO] [stderr] 466 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:475:48 [INFO] [stderr] | [INFO] [stderr] 475 | let good: HashSet<&str> = result.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:491:24 [INFO] [stderr] | [INFO] [stderr] 491 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:501:48 [INFO] [stderr] | [INFO] [stderr] 501 | let good: HashSet<&str> = result.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:517:24 [INFO] [stderr] | [INFO] [stderr] 517 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:526:48 [INFO] [stderr] | [INFO] [stderr] 526 | let good: HashSet<&str> = result.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:542:24 [INFO] [stderr] | [INFO] [stderr] 542 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:81:61 [INFO] [stderr] | [INFO] [stderr] 81 | _ => Box::new(BufReader::new(File::open(input_name).expect(&format!( [INFO] [stderr] | _____________________________________________________________^ [INFO] [stderr] 82 | | "Can't open input file {}", [INFO] [stderr] 83 | | input_name [INFO] [stderr] 84 | | )))), [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Can't open input file {}", input_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 97 | for (i, ) in buf.iter().enumerate().take(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 106 | for (i, ) in buf.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:107:24 [INFO] [stderr] | [INFO] [stderr] 107 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:154:64 [INFO] [stderr] | [INFO] [stderr] 154 | _ => Box::new(BufWriter::new(File::create(output_name).expect(&format!( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 155 | | "Can't open output file {}", [INFO] [stderr] 156 | | output_name [INFO] [stderr] 157 | | )))), [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("Can't open output file {}", output_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/mhap.rs:120:36 [INFO] [stderr] | [INFO] [stderr] 120 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/mhap.rs:121:36 [INFO] [stderr] | [INFO] [stderr] 121 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io/mhap.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(record.error, ERROR[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io/mhap.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(record.error, ERROR[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io/mhap.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | assert_eq!(record.shared_min_mers, SHARED_MIN_MERS[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io/mhap.rs:188:13 [INFO] [stderr] | [INFO] [stderr] 188 | assert_eq!(record.shared_min_mers, SHARED_MIN_MERS[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/mhap.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | / writer [INFO] [stderr] 206 | | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] 207 | | .ok() [INFO] [stderr] 208 | | .expect("Error writing record"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/mhap.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/io/paf.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | / let mut sam_field = Vec::new(); [INFO] [stderr] 76 | | if mapping_quality_and_sam.len() > 1 { [INFO] [stderr] 77 | | sam_field = mapping_quality_and_sam[1..].to_vec(); [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let sam_field = if mapping_quality_and_sam.len() > 1 { mapping_quality_and_sam[1..].to_vec() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/paf.rs:129:36 [INFO] [stderr] | [INFO] [stderr] 129 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/paf.rs:130:36 [INFO] [stderr] | [INFO] [stderr] 130 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | / writer [INFO] [stderr] 248 | | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] 249 | | .ok() [INFO] [stderr] 250 | | .expect("Error writing record"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | / writer [INFO] [stderr] 261 | | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] 262 | | .ok() [INFO] [stderr] 263 | | .expect("Error writing record"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:261:25 [INFO] [stderr] | [INFO] [stderr] 261 | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/utils.rs:67:41 [INFO] [stderr] | [INFO] [stderr] 67 | } else if filename.contains(".paf") { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 68 | | Some(Format::Paf) [INFO] [stderr] 69 | | } else if filename.contains(".mhap") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/utils.rs:65:31 [INFO] [stderr] | [INFO] [stderr] 65 | return if filename == "-" { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 66 | | Some(Format::Paf) [INFO] [stderr] 67 | | } else if filename.contains(".paf") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:193:27 [INFO] [stderr] | [INFO] [stderr] 193 | let filters: Vec<_> = match matches.is_present("filter") { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 194 | | true => matches.values_of("filter").unwrap().collect(), [INFO] [stderr] 195 | | false => Vec::new(), [INFO] [stderr] 196 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("filter") { matches.values_of("filter").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:197:28 [INFO] [stderr] | [INFO] [stderr] 197 | let extracts: Vec<_> = match matches.is_present("extract") { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 198 | | true => matches.values_of("extract").unwrap().collect(), [INFO] [stderr] 199 | | false => Vec::new(), [INFO] [stderr] 200 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("extract") { matches.values_of("extract").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:201:26 [INFO] [stderr] | [INFO] [stderr] 201 | let splits: Vec<_> = match matches.is_present("split") { [INFO] [stderr] | __________________________^ [INFO] [stderr] 202 | | true => matches.values_of("split").unwrap().collect(), [INFO] [stderr] 203 | | false => Vec::new(), [INFO] [stderr] 204 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("split") { matches.values_of("split").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yacrd`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "125c13742b3e65b83ed09dd6a05150d8335d92d9162b4d9193456831089e67f1"` [INFO] running `"docker" "rm" "-f" "125c13742b3e65b83ed09dd6a05150d8335d92d9162b4d9193456831089e67f1"` [INFO] [stdout] 125c13742b3e65b83ed09dd6a05150d8335d92d9162b4d9193456831089e67f1