[INFO] updating cached repository natir/yacrd-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/natir/yacrd-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/natir/yacrd-rust" "work/ex/clippy-test-run/sources/stable/gh/natir/yacrd-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/natir/yacrd-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/natir/yacrd-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/yacrd-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/yacrd-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 310414531301469dd69b8c1b133234b6fede684d [INFO] sha for GitHub repo natir/yacrd-rust: 310414531301469dd69b8c1b133234b6fede684d [INFO] validating manifest of natir/yacrd-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of natir/yacrd-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing natir/yacrd-rust [INFO] finished frobbing natir/yacrd-rust [INFO] frobbed toml for natir/yacrd-rust written to work/ex/clippy-test-run/sources/stable/gh/natir/yacrd-rust/Cargo.toml [INFO] started frobbing natir/yacrd-rust [INFO] finished frobbing natir/yacrd-rust [INFO] frobbed toml for natir/yacrd-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/yacrd-rust/Cargo.toml [INFO] crate natir/yacrd-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting natir/yacrd-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/natir/yacrd-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 46319bd994c6052235b508019504c1305b5a2f226c4464dee9b609bc0b3b8051 [INFO] running `"docker" "start" "-a" "46319bd994c6052235b508019504c1305b5a2f226c4464dee9b609bc0b3b8051"` [INFO] [stderr] Compiling serde v1.0.70 [INFO] [stderr] Compiling bv v0.7.4 [INFO] [stderr] Checking bytecount v0.3.1 [INFO] [stderr] Compiling filetime v0.2.1 [INFO] [stderr] Compiling rust-lzma v0.2.1 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Compiling lzma-sys v0.1.10 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking xz2 v0.1.5 [INFO] [stderr] Checking ndarray v0.9.1 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking bio v0.21.0 [INFO] [stderr] Checking yarcd v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::Read` [INFO] [stderr] --> tests/realistic_scenario.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | use std::io::Read; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:82:50 [INFO] [stderr] | [INFO] [stderr] 82 | let good: HashSet<&str> = expected.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:100:24 [INFO] [stderr] | [INFO] [stderr] 100 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:114:50 [INFO] [stderr] | [INFO] [stderr] 114 | let good: HashSet<&str> = expected.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:141:46 [INFO] [stderr] | [INFO] [stderr] 141 | let result = proxy_deflate.split("\n").collect::>(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:170:50 [INFO] [stderr] | [INFO] [stderr] 170 | let good: HashSet<&str> = expected.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> tests/realistic_scenario.rs:197:63 [INFO] [stderr] | [INFO] [stderr] 197 | assert_eq!(String::from_utf8_lossy(&output).split("\n").collect::>(), good); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chimera.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return match r { [INFO] [stderr] 68 | | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 69 | | _ => r, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | match r { [INFO] [stderr] 68 | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 69 | _ => r, [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chimera.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | return Box::new(remove_reads); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(remove_reads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:303:22 [INFO] [stderr] | [INFO] [stderr] 303 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:307:28 [INFO] [stderr] | [INFO] [stderr] 307 | const PAF_FILE_COV_1: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:315:23 [INFO] [stderr] | [INFO] [stderr] 315 | const MHAP_FILE: &'static [u8] = b"1 2 0.1 2 0 20 4500 12000 0 5500 10000 10000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/chimera.rs:319:30 [INFO] [stderr] | [INFO] [stderr] 319 | const NOT_COVERED_FILE: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/file.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x00FD_377A_585A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return get_readable_file(input_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_readable_file(input_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:144:23 [INFO] [stderr] | [INFO] [stderr] 144 | const GZIP_FILE: &'static [u8] = &[0o037, 0o213]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:145:23 [INFO] [stderr] | [INFO] [stderr] 145 | const BZIP_FILE: &'static [u8] = &[0o102, 0o132]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:146:23 [INFO] [stderr] | [INFO] [stderr] 146 | const LZMA_FILE: &'static [u8] = &[0o375, 0o067]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filter.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return filename.replacen(".", &format!("{}.", filterd_suffix), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `filename.replacen(".", &format!("{}.", filterd_suffix), 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:151:22 [INFO] [stderr] | [INFO] [stderr] 151 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:155:30 [INFO] [stderr] | [INFO] [stderr] 155 | const PAF_FILE_FILTRED: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | const MHAP_FILE: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:170:31 [INFO] [stderr] | [INFO] [stderr] 170 | const MHAP_FILE_FILTRED: &'static [u8] = b""; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:181:24 [INFO] [stderr] | [INFO] [stderr] 181 | const FASTA_FILE: &'static [u8] = b">1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:189:32 [INFO] [stderr] | [INFO] [stderr] 189 | const FASTA_FILE_FILTRED: &'static [u8] = b">2 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:204:24 [INFO] [stderr] | [INFO] [stderr] 204 | const FASTQ_FILE: &'static [u8] = b"@1 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/filter.rs:218:32 [INFO] [stderr] | [INFO] [stderr] 218 | const FASTQ_FILE_FILTRED: &'static [u8] = b"@2 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:179:23 [INFO] [stderr] | [INFO] [stderr] 179 | const MHAP_FILE: &'static [u8] = b"1 2 0.1 2 0 100 450 1000 0 550 900 1000 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:183:20 [INFO] [stderr] | [INFO] [stderr] 183 | const READ_A: &'static [&str; 2] = &["1", "1"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:184:20 [INFO] [stderr] | [INFO] [stderr] 184 | const READ_B: &'static [&str; 2] = &["2", "3"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:185:19 [INFO] [stderr] | [INFO] [stderr] 185 | const ERROR: &'static [f64; 2] = &[0.1, 0.1]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[f64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | const SHARED_MIN_MERS: &'static [u64; 2] = &[2, 2]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:187:22 [INFO] [stderr] | [INFO] [stderr] 187 | const STRAND_A: &'static [char; 2] = &['0', '0']; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[char; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:188:22 [INFO] [stderr] | [INFO] [stderr] 188 | const STRAND_B: &'static [char; 2] = &['0', '0']; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[char; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:189:21 [INFO] [stderr] | [INFO] [stderr] 189 | const BEGIN_A: &'static [u64; 2] = &[100, 550]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:190:19 [INFO] [stderr] | [INFO] [stderr] 190 | const END_A: &'static [u64; 2] = &[450, 900]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:191:22 [INFO] [stderr] | [INFO] [stderr] 191 | const LENGTH_A: &'static [u64; 2] = &[1000, 1000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | const BEGIN_B: &'static [u64; 2] = &[550, 100]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:193:19 [INFO] [stderr] | [INFO] [stderr] 193 | const END_B: &'static [u64; 2] = &[900, 450]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/mhap.rs:194:22 [INFO] [stderr] | [INFO] [stderr] 194 | const LENGTH_B: &'static [u64; 2] = &[1000, 1000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:189:22 [INFO] [stderr] | [INFO] [stderr] 189 | const PAF_FILE: &'static [u8] = b"1\t12000\t20\t4500\t-\t2\t10000\t5500\t10000\t4500\t4500\t255 [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:193:32 [INFO] [stderr] | [INFO] [stderr] 193 | const PAF_SAM_FIELD_FILE: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:198:20 [INFO] [stderr] | [INFO] [stderr] 198 | const READ_A: &'static [&str; 2] = &["1", "1"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:199:22 [INFO] [stderr] | [INFO] [stderr] 199 | const LENGTH_A: &'static [u64; 2] = &[12000, 12000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:200:21 [INFO] [stderr] | [INFO] [stderr] 200 | const BEGIN_A: &'static [u64; 2] = &[20, 5500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:201:19 [INFO] [stderr] | [INFO] [stderr] 201 | const END_A: &'static [u64; 2] = &[4500, 10000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:202:20 [INFO] [stderr] | [INFO] [stderr] 202 | const STRAND: &'static [char; 2] = &['-', '-']; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[char; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | const READ_B: &'static [&str; 2] = &["2", "3"]; [INFO] [stderr] | -^^^^^^^---------- help: consider removing `'static`: `&[&str; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:204:22 [INFO] [stderr] | [INFO] [stderr] 204 | const LENGTH_B: &'static [u64; 2] = &[10000, 10000]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:205:21 [INFO] [stderr] | [INFO] [stderr] 205 | const BEGIN_B: &'static [u64; 2] = &[5500, 0]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:206:19 [INFO] [stderr] | [INFO] [stderr] 206 | const END_B: &'static [u64; 2] = &[10000, 4500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:207:27 [INFO] [stderr] | [INFO] [stderr] 207 | const NB_MATCH_BASE: &'static [u64; 2] = &[4500, 4500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | const NB_BASE: &'static [u64; 2] = &[4500, 4500]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/io/paf.rs:209:29 [INFO] [stderr] | [INFO] [stderr] 209 | const MAPPING_QUALITY: &'static [u64; 2] = &[255, 255]; [INFO] [stderr] | -^^^^^^^--------- help: consider removing `'static`: `&[u64; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / return _get_mapping_format( [INFO] [stderr] 38 | | m.is_present("format"), [INFO] [stderr] 39 | | m.value_of("format").unwrap_or("_"), [INFO] [stderr] 40 | | m.value_of("input").unwrap_or("_"), [INFO] [stderr] 41 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | _get_mapping_format( [INFO] [stderr] 38 | m.is_present("format"), [INFO] [stderr] 39 | m.value_of("format").unwrap_or("_"), [INFO] [stderr] 40 | m.value_of("input").unwrap_or("_"), [INFO] [stderr] 41 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return get_format(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_format(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return if filename == "-" { [INFO] [stderr] 58 | | Some(Format::Paf) [INFO] [stderr] 59 | | } else if filename.contains(".paf") { [INFO] [stderr] 60 | | Some(Format::Paf) [INFO] [stderr] ... | [INFO] [stderr] 68 | | None [INFO] [stderr] 69 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | if filename == "-" { [INFO] [stderr] 58 | Some(Format::Paf) [INFO] [stderr] 59 | } else if filename.contains(".paf") { [INFO] [stderr] 60 | Some(Format::Paf) [INFO] [stderr] 61 | } else if filename.contains(".mhap") { [INFO] [stderr] 62 | Some(Format::Mhap) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chimera.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return match r { [INFO] [stderr] 68 | | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 69 | | _ => r, [INFO] [stderr] 70 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | match r { [INFO] [stderr] 68 | Ordering::Equal => self.end.cmp(&other.end), [INFO] [stderr] 69 | _ => r, [INFO] [stderr] 70 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chimera.rs:209:5 [INFO] [stderr] | [INFO] [stderr] 209 | return Box::new(remove_reads); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Box::new(remove_reads)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/file.rs:36:12 [INFO] [stderr] | [INFO] [stderr] 36 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x00FD_377A_585A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return get_readable_file(input_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_readable_file(input_name)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/filter.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return filename.replacen(".", &format!("{}.", filterd_suffix), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `filename.replacen(".", &format!("{}.", filterd_suffix), 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / return _get_mapping_format( [INFO] [stderr] 38 | | m.is_present("format"), [INFO] [stderr] 39 | | m.value_of("format").unwrap_or("_"), [INFO] [stderr] 40 | | m.value_of("input").unwrap_or("_"), [INFO] [stderr] 41 | | ); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | _get_mapping_format( [INFO] [stderr] 38 | m.is_present("format"), [INFO] [stderr] 39 | m.value_of("format").unwrap_or("_"), [INFO] [stderr] 40 | m.value_of("input").unwrap_or("_"), [INFO] [stderr] 41 | ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | return get_format(input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `get_format(input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / return if filename == "-" { [INFO] [stderr] 58 | | Some(Format::Paf) [INFO] [stderr] 59 | | } else if filename.contains(".paf") { [INFO] [stderr] 60 | | Some(Format::Paf) [INFO] [stderr] ... | [INFO] [stderr] 68 | | None [INFO] [stderr] 69 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | if filename == "-" { [INFO] [stderr] 58 | Some(Format::Paf) [INFO] [stderr] 59 | } else if filename.contains(".paf") { [INFO] [stderr] 60 | Some(Format::Paf) [INFO] [stderr] 61 | } else if filename.contains(".mhap") { [INFO] [stderr] 62 | Some(Format::Mhap) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_file` [INFO] [stderr] --> src/io/mhap.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_file` [INFO] [stderr] --> src/io/paf.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | / output [INFO] [stderr] 204 | | .write(b"\n") [INFO] [stderr] 205 | | .expect("Error durring writting of result"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | / output [INFO] [stderr] 223 | | .write(b";") [INFO] [stderr] 224 | | .expect("Error durring writting of result"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:264:35 [INFO] [stderr] | [INFO] [stderr] 264 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:265:35 [INFO] [stderr] | [INFO] [stderr] 265 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:293:35 [INFO] [stderr] | [INFO] [stderr] 293 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/file.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | File::open(input_name).expect(&format!("Can't open input file {}", input_name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't open input file {}", input_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:134:39 [INFO] [stderr] | [INFO] [stderr] 134 | File::create(output_name).expect(&format!("Can't open output file {}", output_name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't open output file {}", output_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn run(reads: &Box>, filename: &str, filterd_suffix: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:71:12 [INFO] [stderr] | [INFO] [stderr] 71 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/mhap.rs:138:36 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/mhap.rs:139:36 [INFO] [stderr] | [INFO] [stderr] 139 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/io/paf.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | / let mut sam_field = Vec::new(); [INFO] [stderr] 92 | | if mapping_quality_and_sam.len() > 1 { [INFO] [stderr] 93 | | sam_field = mapping_quality_and_sam[1..].to_vec(); [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let sam_field = if mapping_quality_and_sam.len() > 1 { mapping_quality_and_sam[1..].to_vec() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/paf.rs:147:36 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/paf.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/utils.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | } else if filename.contains(".paf") { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 60 | | Some(Format::Paf) [INFO] [stderr] 61 | | } else if filename.contains(".mhap") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/utils.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | return if filename == "-" { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 58 | | Some(Format::Paf) [INFO] [stderr] 59 | | } else if filename.contains(".paf") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:139:27 [INFO] [stderr] | [INFO] [stderr] 139 | let filters: Vec<_> = match matches.is_present("filter") { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 140 | | true => matches.values_of("filter").unwrap().collect(), [INFO] [stderr] 141 | | false => Vec::new(), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("filter") { matches.values_of("filter").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yarcd`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `to_file` [INFO] [stderr] --> src/io/mhap.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `to_file` [INFO] [stderr] --> src/io/paf.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:203:13 [INFO] [stderr] | [INFO] [stderr] 203 | / output [INFO] [stderr] 204 | | .write(b"\n") [INFO] [stderr] 205 | | .expect("Error durring writting of result"); [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/chimera.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | / output [INFO] [stderr] 223 | | .write(b";") [INFO] [stderr] 224 | | .expect("Error durring writting of result"); [INFO] [stderr] | |_______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:264:35 [INFO] [stderr] | [INFO] [stderr] 264 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:265:35 [INFO] [stderr] | [INFO] [stderr] 265 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:293:35 [INFO] [stderr] | [INFO] [stderr] 293 | read2mapping.entry(key_a).or_insert(Vec::new()).push(val_a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/chimera.rs:294:35 [INFO] [stderr] | [INFO] [stderr] 294 | read2mapping.entry(key_b).or_insert(Vec::new()).push(val_b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:342:48 [INFO] [stderr] | [INFO] [stderr] 342 | let good: HashSet<&str> = result.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/chimera.rs:349:24 [INFO] [stderr] | [INFO] [stderr] 349 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: Clike enum variant discriminant is not portable to 32-bit targets [INFO] [stderr] --> src/file.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::enum_clike_unportable_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_clike_unportable_variant [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:77:36 [INFO] [stderr] | [INFO] [stderr] 77 | File::open(input_name).expect(&format!("Can't open input file {}", input_name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't open input file {}", input_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:134:39 [INFO] [stderr] | [INFO] [stderr] 134 | File::create(output_name).expect(&format!("Can't open output file {}", output_name)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't open output file {}", output_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn run(reads: &Box>, filename: &str, filterd_suffix: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:71:12 [INFO] [stderr] | [INFO] [stderr] 71 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/filter.rs:105:12 [INFO] [stderr] | [INFO] [stderr] 105 | reads: &Box>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `&HashSet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/mhap.rs:138:36 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/mhap.rs:139:36 [INFO] [stderr] | [INFO] [stderr] 139 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/io/mhap.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | assert_eq!(record.error, ERROR[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/io/mhap.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | assert_eq!(record.error, ERROR[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/mhap.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | / writer [INFO] [stderr] 224 | | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] 225 | | .ok() [INFO] [stderr] 226 | | .expect("Error writing record"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/mhap.rs:224:25 [INFO] [stderr] | [INFO] [stderr] 224 | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/io/paf.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | / let mut sam_field = Vec::new(); [INFO] [stderr] 92 | | if mapping_quality_and_sam.len() > 1 { [INFO] [stderr] 93 | | sam_field = mapping_quality_and_sam[1..].to_vec(); [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let sam_field = if mapping_quality_and_sam.len() > 1 { mapping_quality_and_sam[1..].to_vec() } else { Vec::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/io/paf.rs:147:36 [INFO] [stderr] | [INFO] [stderr] 147 | pub fn to_file>(path: P) -> std::io::Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/io/paf.rs:148:36 [INFO] [stderr] | [INFO] [stderr] 148 | fs::File::create(path).map(|f| Writer::new(f)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Writer::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:266:13 [INFO] [stderr] | [INFO] [stderr] 266 | / writer [INFO] [stderr] 267 | | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] 268 | | .ok() [INFO] [stderr] 269 | | .expect("Error writing record"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:267:25 [INFO] [stderr] | [INFO] [stderr] 267 | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | / writer [INFO] [stderr] 280 | | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] 281 | | .ok() [INFO] [stderr] 282 | | .expect("Error writing record"); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/io/paf.rs:280:25 [INFO] [stderr] | [INFO] [stderr] 280 | .write(&r.ok().expect("Error reading record")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/utils.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | } else if filename.contains(".paf") { [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 60 | | Some(Format::Paf) [INFO] [stderr] 61 | | } else if filename.contains(".mhap") { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/utils.rs:57:31 [INFO] [stderr] | [INFO] [stderr] 57 | return if filename == "-" { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 58 | | Some(Format::Paf) [INFO] [stderr] 59 | | } else if filename.contains(".paf") { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:139:27 [INFO] [stderr] | [INFO] [stderr] 139 | let filters: Vec<_> = match matches.is_present("filter") { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 140 | | true => matches.values_of("filter").unwrap().collect(), [INFO] [stderr] 141 | | false => Vec::new(), [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("filter") { matches.values_of("filter").unwrap().collect() } else { Vec::new() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `yarcd`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "46319bd994c6052235b508019504c1305b5a2f226c4464dee9b609bc0b3b8051"` [INFO] running `"docker" "rm" "-f" "46319bd994c6052235b508019504c1305b5a2f226c4464dee9b609bc0b3b8051"` [INFO] [stdout] 46319bd994c6052235b508019504c1305b5a2f226c4464dee9b609bc0b3b8051