[INFO] updating cached repository natir/mapping2barcode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/natir/mapping2barcode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/natir/mapping2barcode" "work/ex/clippy-test-run/sources/stable/gh/natir/mapping2barcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/natir/mapping2barcode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/natir/mapping2barcode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/mapping2barcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/mapping2barcode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b3f5968927e2e5ecd3dad1fbb1e112b602e96975 [INFO] sha for GitHub repo natir/mapping2barcode: b3f5968927e2e5ecd3dad1fbb1e112b602e96975 [INFO] validating manifest of natir/mapping2barcode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of natir/mapping2barcode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing natir/mapping2barcode [INFO] finished frobbing natir/mapping2barcode [INFO] frobbed toml for natir/mapping2barcode written to work/ex/clippy-test-run/sources/stable/gh/natir/mapping2barcode/Cargo.toml [INFO] started frobbing natir/mapping2barcode [INFO] finished frobbing natir/mapping2barcode [INFO] frobbed toml for natir/mapping2barcode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/natir/mapping2barcode/Cargo.toml [INFO] crate natir/mapping2barcode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting natir/mapping2barcode against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/natir/mapping2barcode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b5b052067cfa5e7f02905307c21acf25cf3173eb123e274030b84eb32112994 [INFO] running `"docker" "start" "-a" "4b5b052067cfa5e7f02905307c21acf25cf3173eb123e274030b84eb32112994"` [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling bv v0.7.4 [INFO] [stderr] Compiling ndarray v0.9.1 [INFO] [stderr] Checking bytecount v0.3.2 [INFO] [stderr] Compiling lzma-sys v0.1.11 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Compiling syn v0.15.14 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking bio v0.20.3 [INFO] [stderr] Checking mapping2barcodegraph v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/file.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x00FD_377A_585A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (4 - i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (1 - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return (contig_graph, contig_len, node2index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(contig_graph, contig_len, node2index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / return if node2index.contains_key(&node) { [INFO] [stderr] 36 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 37 | | } else { [INFO] [stderr] 38 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 39 | | node2index.insert(node, index); [INFO] [stderr] 40 | | index [INFO] [stderr] 41 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | if node2index.contains_key(&node) { [INFO] [stderr] 36 | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 37 | } else { [INFO] [stderr] 38 | let index = graph.add_node(node.clone()); [INFO] [stderr] 39 | node2index.insert(node, index); [INFO] [stderr] 40 | index [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return (premolecule2tig_pos, barcode2premolecule, premolecule2reads, reads2barcode); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(premolecule2tig_pos, barcode2premolecule, premolecule2reads, reads2barcode)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `petgraph::visit::IntoNodeReferences` [INFO] [stderr] --> src/premolecule.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use petgraph::visit::IntoNodeReferences; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return graphs; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `graphs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / return if tig1 == tig2 { [INFO] [stderr] 99 | | same_tig_dist(pos1, pos2) [INFO] [stderr] 100 | | } else { [INFO] [stderr] 101 | | other_tig_dist(node1, pos1, node2, pos2, &tig_graph, &tig2len, threshold, buffer) [INFO] [stderr] 102 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | if tig1 == tig2 { [INFO] [stderr] 99 | same_tig_dist(pos1, pos2) [INFO] [stderr] 100 | } else { [INFO] [stderr] 101 | other_tig_dist(node1, pos1, node2, pos2, &tig_graph, &tig2len, threshold, buffer) [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / return if node2index.contains_key(&node) { [INFO] [stderr] 107 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 108 | | } else { [INFO] [stderr] 109 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 110 | | node2index.insert(node, index); [INFO] [stderr] 111 | | index [INFO] [stderr] 112 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 106 | if node2index.contains_key(&node) { [INFO] [stderr] 107 | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 108 | } else { [INFO] [stderr] 109 | let index = graph.add_node(node.clone()); [INFO] [stderr] 110 | node2index.insert(node, index); [INFO] [stderr] 111 | index [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / return if p1_begin > p2_begin { [INFO] [stderr] 128 | | p1_begin - p2_begin [INFO] [stderr] 129 | | } else { [INFO] [stderr] 130 | | p2_begin - p1_begin [INFO] [stderr] 131 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 127 | if p1_begin > p2_begin { [INFO] [stderr] 128 | p1_begin - p2_begin [INFO] [stderr] 129 | } else { [INFO] [stderr] 130 | p2_begin - p1_begin [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return other_tig_dist_one_edge(p1, p2, graph, tig2len, threshold, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `other_tig_dist_one_edge(p1, p2, graph, tig2len, threshold, &path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return other_tig_dist_x_edge(p1, p2, graph, tig2len, threshold, &path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `other_tig_dist_x_edge(p1, p2, graph, tig2len, threshold, &path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return std::u64::MAX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::u64::MAX` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return cumulative_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cumulative_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | return std::u64::MAX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::u64::MAX` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | return cumulative_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cumulative_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | return (edge, weight.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(edge, weight.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/premolecule.rs:243:84 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn write_graph(graphs: &Vec>, path: String)-> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/file.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | Lzma = 0xFD377A585A, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x00FD_377A_585A` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (4 - i))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/file.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(buf[i] as u64) << (8 * (1 - i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:111:23 [INFO] [stderr] | [INFO] [stderr] 111 | const GZIP_FILE: &'static [u8] = &[0o037, 0o213, 0o0, 0o0, 0o0]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:112:23 [INFO] [stderr] | [INFO] [stderr] 112 | const BZIP_FILE: &'static [u8] = &[0o102, 0o132, 0o0, 0o0, 0o0]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file.rs:113:23 [INFO] [stderr] | [INFO] [stderr] 113 | const LZMA_FILE: &'static [u8] = &[0o375, 0o067, 0o172, 0o130, 0o132]; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return (contig_graph, contig_len, node2index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(contig_graph, contig_len, node2index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / return if node2index.contains_key(&node) { [INFO] [stderr] 36 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 37 | | } else { [INFO] [stderr] 38 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 39 | | node2index.insert(node, index); [INFO] [stderr] 40 | | index [INFO] [stderr] 41 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 35 | if node2index.contains_key(&node) { [INFO] [stderr] 36 | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 37 | } else { [INFO] [stderr] 38 | let index = graph.add_node(node.clone()); [INFO] [stderr] 39 | node2index.insert(node, index); [INFO] [stderr] 40 | index [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | return (premolecule2tig_pos, barcode2premolecule, premolecule2reads, reads2barcode); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(premolecule2tig_pos, barcode2premolecule, premolecule2reads, reads2barcode)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse_info.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return new_id; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `new_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `petgraph::visit::IntoNodeReferences` [INFO] [stderr] --> src/premolecule.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use petgraph::visit::IntoNodeReferences; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return graphs; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `graphs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / return if tig1 == tig2 { [INFO] [stderr] 99 | | same_tig_dist(pos1, pos2) [INFO] [stderr] 100 | | } else { [INFO] [stderr] 101 | | other_tig_dist(node1, pos1, node2, pos2, &tig_graph, &tig2len, threshold, buffer) [INFO] [stderr] 102 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 98 | if tig1 == tig2 { [INFO] [stderr] 99 | same_tig_dist(pos1, pos2) [INFO] [stderr] 100 | } else { [INFO] [stderr] 101 | other_tig_dist(node1, pos1, node2, pos2, &tig_graph, &tig2len, threshold, buffer) [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / return if node2index.contains_key(&node) { [INFO] [stderr] 107 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 108 | | } else { [INFO] [stderr] 109 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 110 | | node2index.insert(node, index); [INFO] [stderr] 111 | | index [INFO] [stderr] 112 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 106 | if node2index.contains_key(&node) { [INFO] [stderr] 107 | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 108 | } else { [INFO] [stderr] 109 | let index = graph.add_node(node.clone()); [INFO] [stderr] 110 | node2index.insert(node, index); [INFO] [stderr] 111 | index [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:127:5 [INFO] [stderr] | [INFO] [stderr] 127 | / return if p1_begin > p2_begin { [INFO] [stderr] 128 | | p1_begin - p2_begin [INFO] [stderr] 129 | | } else { [INFO] [stderr] 130 | | p2_begin - p1_begin [INFO] [stderr] 131 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 127 | if p1_begin > p2_begin { [INFO] [stderr] 128 | p1_begin - p2_begin [INFO] [stderr] 129 | } else { [INFO] [stderr] 130 | p2_begin - p1_begin [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | return other_tig_dist_one_edge(p1, p2, graph, tig2len, threshold, &path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `other_tig_dist_one_edge(p1, p2, graph, tig2len, threshold, &path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | return other_tig_dist_x_edge(p1, p2, graph, tig2len, threshold, &path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `other_tig_dist_x_edge(p1, p2, graph, tig2len, threshold, &path)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | return std::u64::MAX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::u64::MAX` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | return cumulative_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cumulative_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | return std::u64::MAX; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `std::u64::MAX` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | return cumulative_len; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cumulative_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/premolecule.rs:240:5 [INFO] [stderr] | [INFO] [stderr] 240 | return (edge, weight.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(edge, weight.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/premolecule.rs:243:84 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn write_graph(graphs: &Vec>, path: String)-> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/premolecule.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let mut n = 0; [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/premolecule.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | let mut n = 0; [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:72:36 [INFO] [stderr] | [INFO] [stderr] 72 | File::open(input_name).expect(&format!("Can't open input file {}", input_name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't open input file {}", input_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for (i, ) in buf.iter().enumerate().take(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 95 | for (i, ) in buf.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/parse_info.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | return if node2index.contains_key(&node) { [INFO] [stderr] | ____________^ [INFO] [stderr] 36 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 37 | | } else { [INFO] [stderr] 38 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 39 | | node2index.insert(node, index); [INFO] [stderr] 40 | | index [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ help: consider using: `node2index.entry(node)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parse_info.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn ema(tsv_path: String) -> (HashMap)>, HashMap>, HashMap>, HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/parse_info.rs:78:55 [INFO] [stderr] | [INFO] [stderr] 78 | barcode2premolecule.entry(barcode_id.clone()).or_insert(HashSet::new()).insert(premolecule_id.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/parse_info.rs:79:57 [INFO] [stderr] | [INFO] [stderr] 79 | premolecule2reads.entry(premolecule_id.clone()).or_insert(HashSet::new()).insert(new_read_id.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse_info.rs:86:65 [INFO] [stderr] | [INFO] [stderr] 86 | fn found_read_id(reads2barcode: &HashMap, read: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/premolecule.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/premolecule.rs:96:41 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:96:56 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:96:73 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/premolecule.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | / fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] 97 | | { [INFO] [stderr] 98 | | return if tig1 == tig2 { [INFO] [stderr] 99 | | same_tig_dist(pos1, pos2) [INFO] [stderr] ... | [INFO] [stderr] 102 | | }; [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:96:91 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:96:127 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/premolecule.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | return if node2index.contains_key(&node) { [INFO] [stderr] | ____________^ [INFO] [stderr] 107 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 108 | | } else { [INFO] [stderr] 109 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 110 | | node2index.insert(node, index); [INFO] [stderr] 111 | | index [INFO] [stderr] 112 | | }; [INFO] [stderr] | |_____^ help: consider using: `node2index.entry(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:123:22 [INFO] [stderr] | [INFO] [stderr] 123 | fn same_tig_dist(p1: &Vec, p2: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | fn same_tig_dist(p1: &Vec, p2: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:134:59 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:134:110 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/premolecule.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] 135 | | [INFO] [stderr] 136 | | let path; [INFO] [stderr] 137 | | if buffer.contains_key(&(*node1, *node2)) { [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:134:77 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/premolecule.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / if buffer.contains_key(&(*node1, *node2)) { [INFO] [stderr] 138 | | path = buffer.get(&(*node1, *node2)).unwrap().clone(); [INFO] [stderr] 139 | | } else { [INFO] [stderr] 140 | | let p = petgraph::algo::astar(graph, *node1, |finish| finish == *node2, |_| 1, |_| 0); [INFO] [stderr] ... | [INFO] [stderr] 146 | | buffer.insert((*node1, *node2), path.clone()); [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ help: consider using: `buffer.entry((*node1, *node2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/premolecule.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match p.is_none() { [INFO] [stderr] 143 | | true => return std::u64::MAX, [INFO] [stderr] 144 | | false => path = p.unwrap().1, [INFO] [stderr] 145 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if p.is_none() { return std::u64::MAX } else { path = p.unwrap().1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | fn other_tig_dist_one_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:156:47 [INFO] [stderr] | [INFO] [stderr] 156 | fn other_tig_dist_one_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:156:160 [INFO] [stderr] | [INFO] [stderr] 156 | fn other_tig_dist_one_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[petgraph::graph::NodeIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:188:30 [INFO] [stderr] | [INFO] [stderr] 188 | fn other_tig_dist_x_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:188:45 [INFO] [stderr] | [INFO] [stderr] 188 | fn other_tig_dist_x_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:188:158 [INFO] [stderr] | [INFO] [stderr] 188 | fn other_tig_dist_x_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[petgraph::graph::NodeIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:243:28 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn write_graph(graphs: &Vec>, path: String)-> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[petgraph::graph::Graph]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/premolecule.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | graph_writer.write(b"Source,Target,Weight\n").expect("Error durring premolecule graph header write"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | for read in premolecule2reads.get(premolecule).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&premolecule2reads[premolecule]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | let barcode = reads2barcode.get(read).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reads2barcode[read]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:140:58 [INFO] [stderr] | [INFO] [stderr] 140 | let basic_read = &read[0..read.rfind("_").unwrap()]; [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mapping2barcodegraph`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/file.rs:72:36 [INFO] [stderr] | [INFO] [stderr] 72 | File::open(input_name).expect(&format!("Can't open input file {}", input_name)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Can't open input file {}", input_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | for i in 0..5 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 86 | for (i, ) in buf.iter().enumerate().take(5) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:87:25 [INFO] [stderr] | [INFO] [stderr] 87 | five_bit_val |= (buf[i] as u64) << 8 * (4 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/file.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 95 | for (i, ) in buf.iter().enumerate().take(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/file.rs:96:24 [INFO] [stderr] | [INFO] [stderr] 96 | two_bit_val |= (buf[i] as u64) << 8 * (1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(buf[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/parse_info.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | return if node2index.contains_key(&node) { [INFO] [stderr] | ____________^ [INFO] [stderr] 36 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 37 | | } else { [INFO] [stderr] 38 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 39 | | node2index.insert(node, index); [INFO] [stderr] 40 | | index [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_____^ help: consider using: `node2index.entry(node)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parse_info.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn ema(tsv_path: String) -> (HashMap)>, HashMap>, HashMap>, HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/parse_info.rs:78:55 [INFO] [stderr] | [INFO] [stderr] 78 | barcode2premolecule.entry(barcode_id.clone()).or_insert(HashSet::new()).insert(premolecule_id.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/parse_info.rs:79:57 [INFO] [stderr] | [INFO] [stderr] 79 | premolecule2reads.entry(premolecule_id.clone()).or_insert(HashSet::new()).insert(new_read_id.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(HashSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/parse_info.rs:86:65 [INFO] [stderr] | [INFO] [stderr] 86 | fn found_read_id(reads2barcode: &HashMap, read: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/premolecule.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/premolecule.rs:96:41 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:96:56 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:96:73 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/premolecule.rs:96:1 [INFO] [stderr] | [INFO] [stderr] 96 | / fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] 97 | | { [INFO] [stderr] 98 | | return if tig1 == tig2 { [INFO] [stderr] 99 | | same_tig_dist(pos1, pos2) [INFO] [stderr] ... | [INFO] [stderr] 102 | | }; [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:96:91 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:96:127 [INFO] [stderr] | [INFO] [stderr] 96 | fn get_edge_weight(tig1: &String, tig2: &String, pos1: &Vec, pos2: &Vec, node1: &petgraph::graph::NodeIndex, node2: &petgraph::graph::NodeIndex, tig_graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/premolecule.rs:106:12 [INFO] [stderr] | [INFO] [stderr] 106 | return if node2index.contains_key(&node) { [INFO] [stderr] | ____________^ [INFO] [stderr] 107 | | *node2index.get(&node).expect("You can't be her") [INFO] [stderr] 108 | | } else { [INFO] [stderr] 109 | | let index = graph.add_node(node.clone()); [INFO] [stderr] 110 | | node2index.insert(node, index); [INFO] [stderr] 111 | | index [INFO] [stderr] 112 | | }; [INFO] [stderr] | |_____^ help: consider using: `node2index.entry(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:123:22 [INFO] [stderr] | [INFO] [stderr] 123 | fn same_tig_dist(p1: &Vec, p2: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | fn same_tig_dist(p1: &Vec, p2: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:134:59 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:134:110 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/premolecule.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] 135 | | [INFO] [stderr] 136 | | let path; [INFO] [stderr] 137 | | if buffer.contains_key(&(*node1, *node2)) { [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:134:26 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/premolecule.rs:134:77 [INFO] [stderr] | [INFO] [stderr] 134 | fn other_tig_dist(node1: &petgraph::graph::NodeIndex, p1: &Vec, node2: &petgraph::graph::NodeIndex, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, buffer: &mut HashMap<(petgraph::graph::NodeIndex, petgraph::graph::NodeIndex), Vec>) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `petgraph::graph::NodeIndex` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/premolecule.rs:137:5 [INFO] [stderr] | [INFO] [stderr] 137 | / if buffer.contains_key(&(*node1, *node2)) { [INFO] [stderr] 138 | | path = buffer.get(&(*node1, *node2)).unwrap().clone(); [INFO] [stderr] 139 | | } else { [INFO] [stderr] 140 | | let p = petgraph::algo::astar(graph, *node1, |finish| finish == *node2, |_| 1, |_| 0); [INFO] [stderr] ... | [INFO] [stderr] 146 | | buffer.insert((*node1, *node2), path.clone()); [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ help: consider using: `buffer.entry((*node1, *node2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/premolecule.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | / match p.is_none() { [INFO] [stderr] 143 | | true => return std::u64::MAX, [INFO] [stderr] 144 | | false => path = p.unwrap().1, [INFO] [stderr] 145 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if p.is_none() { return std::u64::MAX } else { path = p.unwrap().1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | fn other_tig_dist_one_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:156:47 [INFO] [stderr] | [INFO] [stderr] 156 | fn other_tig_dist_one_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:156:160 [INFO] [stderr] | [INFO] [stderr] 156 | fn other_tig_dist_one_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[petgraph::graph::NodeIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:188:30 [INFO] [stderr] | [INFO] [stderr] 188 | fn other_tig_dist_x_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:188:45 [INFO] [stderr] | [INFO] [stderr] 188 | fn other_tig_dist_x_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:188:158 [INFO] [stderr] | [INFO] [stderr] 188 | fn other_tig_dist_x_edge(p1: &Vec, p2: &Vec, graph: &petgraph::graph::Graph, tig2len: &HashMap, threshold: u64, path: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[petgraph::graph::NodeIndex]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/premolecule.rs:243:28 [INFO] [stderr] | [INFO] [stderr] 243 | pub fn write_graph(graphs: &Vec>, path: String)-> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[petgraph::graph::Graph]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/premolecule.rs:246:5 [INFO] [stderr] | [INFO] [stderr] 246 | graph_writer.write(b"Source,Target,Weight\n").expect("Error durring premolecule graph header write"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | for read in premolecule2reads.get(premolecule).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&premolecule2reads[premolecule]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:139:35 [INFO] [stderr] | [INFO] [stderr] 139 | let barcode = reads2barcode.get(read).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&reads2barcode[read]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:140:58 [INFO] [stderr] | [INFO] [stderr] 140 | let basic_read = &read[0..read.rfind("_").unwrap()]; [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `mapping2barcodegraph`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4b5b052067cfa5e7f02905307c21acf25cf3173eb123e274030b84eb32112994"` [INFO] running `"docker" "rm" "-f" "4b5b052067cfa5e7f02905307c21acf25cf3173eb123e274030b84eb32112994"` [INFO] [stdout] 4b5b052067cfa5e7f02905307c21acf25cf3173eb123e274030b84eb32112994