[INFO] updating cached repository nathantypanski/rash [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nathantypanski/rash [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nathantypanski/rash" "work/ex/clippy-test-run/sources/stable/gh/nathantypanski/rash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nathantypanski/rash'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nathantypanski/rash" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nathantypanski/rash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nathantypanski/rash'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c401f3176f7d3e70115b8acacd988e159f34169c [INFO] sha for GitHub repo nathantypanski/rash: c401f3176f7d3e70115b8acacd988e159f34169c [INFO] validating manifest of nathantypanski/rash on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nathantypanski/rash on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nathantypanski/rash [INFO] finished frobbing nathantypanski/rash [INFO] frobbed toml for nathantypanski/rash written to work/ex/clippy-test-run/sources/stable/gh/nathantypanski/rash/Cargo.toml [INFO] started frobbing nathantypanski/rash [INFO] finished frobbing nathantypanski/rash [INFO] frobbed toml for nathantypanski/rash written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nathantypanski/rash/Cargo.toml [INFO] crate nathantypanski/rash has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nathantypanski/rash against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nathantypanski/rash:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07bb0753100dfc47d3d392017bb7239b9e55fc0bd0c4b6c025e0580ee66c14cd [INFO] running `"docker" "start" "-a" "07bb0753100dfc47d3d392017bb7239b9e55fc0bd0c4b6c025e0580ee66c14cd"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking rash v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | builtins: builtins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `builtins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | history: history, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `history` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | readline: readline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `readline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | builtins: builtins, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `builtins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | history: history, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `history` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | readline: readline, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `readline` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `Stderr`, `Write`, `self` [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | use std::io::{self, Read, Stderr, Write}; [INFO] [stderr] | ^^^^ ^^^^ ^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `words` [INFO] [stderr] --> src/main.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | fn history(&mut self, words: std::str::SplitWhitespace) { [INFO] [stderr] | ^^^^^ help: consider using `_words` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `save_history` [INFO] [stderr] --> src/main.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | fn save_history(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `extern` block uses type `fn(u32)` which is not FFI-safe: this function pointer has Rust-specific calling convention [INFO] [stderr] --> src/main.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | fn signal(sig: u32, cb: extern fn(u32)) -> fn(u32); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(improper_ctypes)] on by default [INFO] [stderr] = help: consider using an `extern fn(...) -> ...` function pointer instead [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | if let Err(_) = readline.load_history("history.txt") { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 53 | | println!("No previous history."); [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_________- help: try this: `if readline.load_history("history.txt").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | let cmd = cmd.clone(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 78 | let cmd = &(*cmd).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 78 | let cmd = &str::clone(cmd); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Read`, `Stderr`, `Write`, `self` [INFO] [stderr] --> src/main.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | use std::io::{self, Read, Stderr, Write}; [INFO] [stderr] | ^^^^ ^^^^ ^^^^^^ ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / loop { [INFO] [stderr] 139 | | match shell.rl() { [INFO] [stderr] 140 | | Ok(_) => { [INFO] [stderr] 141 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(_) = shell.rl() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rash`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `words` [INFO] [stderr] --> src/main.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | fn history(&mut self, words: std::str::SplitWhitespace) { [INFO] [stderr] | ^^^^^ help: consider using `_words` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/main.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `save_history` [INFO] [stderr] --> src/main.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | fn save_history(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: `extern` block uses type `fn(u32)` which is not FFI-safe: this function pointer has Rust-specific calling convention [INFO] [stderr] --> src/main.rs:33:46 [INFO] [stderr] | [INFO] [stderr] 33 | fn signal(sig: u32, cb: extern fn(u32)) -> fn(u32); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(improper_ctypes)] on by default [INFO] [stderr] = help: consider using an `extern fn(...) -> ...` function pointer instead [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:52:16 [INFO] [stderr] | [INFO] [stderr] 52 | if let Err(_) = readline.load_history("history.txt") { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 53 | | println!("No previous history."); [INFO] [stderr] 54 | | }; [INFO] [stderr] | |_________- help: try this: `if readline.load_history("history.txt").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/main.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | let cmd = cmd.clone(); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 78 | let cmd = &(*cmd).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 78 | let cmd = &str::clone(cmd); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | / loop { [INFO] [stderr] 139 | | match shell.rl() { [INFO] [stderr] 140 | | Ok(_) => { [INFO] [stderr] 141 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 146 | | } [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(_) = shell.rl() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rash`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "07bb0753100dfc47d3d392017bb7239b9e55fc0bd0c4b6c025e0580ee66c14cd"` [INFO] running `"docker" "rm" "-f" "07bb0753100dfc47d3d392017bb7239b9e55fc0bd0c4b6c025e0580ee66c14cd"` [INFO] [stdout] 07bb0753100dfc47d3d392017bb7239b9e55fc0bd0c4b6c025e0580ee66c14cd