[INFO] updating cached repository nao-kobayashi/rtail
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nao-kobayashi/rtail
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nao-kobayashi/rtail" "work/ex/clippy-test-run/sources/stable/gh/nao-kobayashi/rtail"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nao-kobayashi/rtail'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nao-kobayashi/rtail" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nao-kobayashi/rtail"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nao-kobayashi/rtail'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3dbebf0ed512d7ada4754cd324bfca2d3440ed6b
[INFO] sha for GitHub repo nao-kobayashi/rtail: 3dbebf0ed512d7ada4754cd324bfca2d3440ed6b
[INFO] validating manifest of nao-kobayashi/rtail on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nao-kobayashi/rtail on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nao-kobayashi/rtail
[INFO] finished frobbing nao-kobayashi/rtail
[INFO] frobbed toml for nao-kobayashi/rtail written to work/ex/clippy-test-run/sources/stable/gh/nao-kobayashi/rtail/Cargo.toml
[INFO] started frobbing nao-kobayashi/rtail
[INFO] finished frobbing nao-kobayashi/rtail
[INFO] frobbed toml for nao-kobayashi/rtail written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nao-kobayashi/rtail/Cargo.toml
[INFO] crate nao-kobayashi/rtail has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nao-kobayashi/rtail against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nao-kobayashi/rtail:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 66dac1d53034244b24e869bb3a529ce3148f0f6fca18f6d5812efb99d4ddedb7
[INFO] running `"docker" "start" "-a" "66dac1d53034244b24e869bb3a529ce3148f0f6fca18f6d5812efb99d4ddedb7"`
[INFO] [stderr]     Checking rtail v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     mmap
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |       let mmap = unsafe { 
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 58 | |         match MmapOptions::new().map(&file) {
[INFO] [stderr] 59 | |             Ok(map) => map,
[INFO] [stderr] 60 | |             Err(e) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |         }
[INFO] [stderr] 65 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:106:12
[INFO] [stderr]     |
[INFO] [stderr] 106 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 107 | |         if let Some(sjis) = encode_shit_jis(buffer) {
[INFO] [stderr] 108 | |             return Some(sjis);
[INFO] [stderr] 109 | |         } else {
[INFO] [stderr] 110 | |             return None;
[INFO] [stderr] 111 | |         }
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 106 |     } else if let Some(sjis) = encode_shit_jis(buffer) {
[INFO] [stderr] 107 |     return Some(sjis);
[INFO] [stderr] 108 | } else {
[INFO] [stderr] 109 |     return None;
[INFO] [stderr] 110 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:16:18
[INFO] [stderr]    |
[INFO] [stderr] 16 |         if &mmap[index..(index + 1)] == b"\n" {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: use: `index..=index`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if line.len() == 0 { continue; }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:67:5
[INFO] [stderr]    |
[INFO] [stderr] 67 |     mmap
[INFO] [stderr]    |     ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |       let mmap = unsafe { 
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 58 | |         match MmapOptions::new().map(&file) {
[INFO] [stderr] 59 | |             Ok(map) => map,
[INFO] [stderr] 60 | |             Err(e) => {
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |         }
[INFO] [stderr] 65 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/main.rs:106:12
[INFO] [stderr]     |
[INFO] [stderr] 106 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 107 | |         if let Some(sjis) = encode_shit_jis(buffer) {
[INFO] [stderr] 108 | |             return Some(sjis);
[INFO] [stderr] 109 | |         } else {
[INFO] [stderr] 110 | |             return None;
[INFO] [stderr] 111 | |         }
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 106 |     } else if let Some(sjis) = encode_shit_jis(buffer) {
[INFO] [stderr] 107 |     return Some(sjis);
[INFO] [stderr] 108 | } else {
[INFO] [stderr] 109 |     return None;
[INFO] [stderr] 110 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/main.rs:16:18
[INFO] [stderr]    |
[INFO] [stderr] 16 |         if &mmap[index..(index + 1)] == b"\n" {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^ help: use: `index..=index`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if line.len() == 0 { continue; }
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.07s
[INFO] running `"docker" "inspect" "66dac1d53034244b24e869bb3a529ce3148f0f6fca18f6d5812efb99d4ddedb7"`
[INFO] running `"docker" "rm" "-f" "66dac1d53034244b24e869bb3a529ce3148f0f6fca18f6d5812efb99d4ddedb7"`
[INFO] [stdout] 66dac1d53034244b24e869bb3a529ce3148f0f6fca18f6d5812efb99d4ddedb7