[INFO] updating cached repository nanoxd/r64 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nanoxd/r64 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nanoxd/r64" "work/ex/clippy-test-run/sources/stable/gh/nanoxd/r64"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nanoxd/r64'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nanoxd/r64" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanoxd/r64"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanoxd/r64'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d25f84c4d00041c6a28edd722f507538e22ac70 [INFO] sha for GitHub repo nanoxd/r64: 2d25f84c4d00041c6a28edd722f507538e22ac70 [INFO] validating manifest of nanoxd/r64 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nanoxd/r64 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nanoxd/r64 [INFO] finished frobbing nanoxd/r64 [INFO] frobbed toml for nanoxd/r64 written to work/ex/clippy-test-run/sources/stable/gh/nanoxd/r64/Cargo.toml [INFO] started frobbing nanoxd/r64 [INFO] finished frobbing nanoxd/r64 [INFO] frobbed toml for nanoxd/r64 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanoxd/r64/Cargo.toml [INFO] crate nanoxd/r64 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nanoxd/r64 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nanoxd/r64:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d2f4c4dc12c87f8521dcd141f83dcc7e513175d715d406f67e99ba2ad5f811f2 [INFO] running `"docker" "start" "-a" "d2f4c4dc12c87f8521dcd141f83dcc7e513175d715d406f67e99ba2ad5f811f2"` [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking num-bigint v0.1.35 [INFO] [stderr] Checking num-rational v0.1.35 [INFO] [stderr] Checking num v0.1.36 [INFO] [stderr] Checking r64 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu/cpu.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | interconnect: interconnect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interconnect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu/cpu.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | interconnect: interconnect, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `interconnect` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | pif_rom: pif_rom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pif_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n64.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | cpu: cpu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/interconnect.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | pif_rom: pif_rom, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pif_rom` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/n64.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | cpu: cpu, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cpu/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cpu/cpu.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | const REG_NAMES: [&'static str; NUM_GPR] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cpu/cp0/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cp0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instruction.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | let value = (self.0 >> 26) & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instruction.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | let value = self.0 & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | Special = 0b000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | Addi = 0b001000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | Addiu = 0b001001, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | Andi = 0b001100, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Ori = 0b001101, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | Lui = 0b001111, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | Mtc0 = 0b010000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | Beql = 0b010100, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | Bne = 0b000101, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | Bnel = 0b010101, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | Lw = 0b100011, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | Sw = 0b101011, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | Jr = 0b001000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rsp.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | if (value & 0xfffffff0) != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cpu/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cpu; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cpu/cpu.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | const REG_NAMES: [&'static str; NUM_GPR] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/cpu/cp0/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod cp0; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instruction.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | let value = (self.0 >> 26) & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/instruction.rs:54:30 [INFO] [stderr] | [INFO] [stderr] 54 | let value = self.0 & 0b111111; [INFO] [stderr] | ^^^^^^^^ help: consider: `0b11_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | Special = 0b000000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | Addi = 0b001000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:6:19 [INFO] [stderr] | [INFO] [stderr] 6 | Addiu = 0b001001, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | Andi = 0b001100, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:9:19 [INFO] [stderr] | [INFO] [stderr] 9 | Ori = 0b001101, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | Lui = 0b001111, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | Mtc0 = 0b010000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | Beql = 0b010100, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | Bne = 0b000101, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | Bnel = 0b010101, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b01_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:18:19 [INFO] [stderr] | [INFO] [stderr] 18 | Lw = 0b100011, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:19:19 [INFO] [stderr] | [INFO] [stderr] 19 | Sw = 0b101011, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b10_1011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu/opcode.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | Jr = 0b001000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0b00_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/rsp.rs:43:21 [INFO] [stderr] | [INFO] [stderr] 43 | if (value & 0xfffffff0) != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let rom = read_bin(rom_file_name); [INFO] [stderr] | ^^^ help: consider using `_rom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/video_interface.rs:31:41 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn write_current_reg(&mut self, value: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/cpu/cpu.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `kseg0_cache_enabled` [INFO] [stderr] --> src/cpu/cp0/reg_config.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | fn kseg0_cache_enabled(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ram` [INFO] [stderr] --> src/interconnect.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | ram: Box<[u16]>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/n64.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_RAM_START` [INFO] [stderr] --> src/mem_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const PIF_RAM_START: u32 = 0x1fc0_07c0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_RAM_LENGTH` [INFO] [stderr] --> src/mem_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const PIF_RAM_LENGTH: u32 = 0x0000_0040; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_RAM_END` [INFO] [stderr] --> src/mem_map.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const PIF_RAM_END: u32 = PIF_RAM_START + PIF_RAM_LENGTH - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SP_BASE_REG` [INFO] [stderr] --> src/mem_map.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const SP_BASE_REG: u32 = 0x0404_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VI_BASE_REG` [INFO] [stderr] --> src/mem_map.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | const VI_BASE_REG: u32 = 0x0440_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PI_BASE_REG` [INFO] [stderr] --> src/mem_map.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | const PI_BASE_REG: u32 = 0x0460_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `reg_num` is used to index `REG_NAMES` [INFO] [stderr] --> src/cpu/cpu.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | for reg_num in 0..NUM_GPR { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for (reg_num, ) in REG_NAMES.iter().enumerate().take(NUM_GPR) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:148:59 [INFO] [stderr] | [INFO] [stderr] 148 | let res = self.read_reg_gpr(instr.rs()) & (instr.imm() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(instr.imm())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:152:59 [INFO] [stderr] | [INFO] [stderr] 152 | let res = self.read_reg_gpr(instr.rs()) | (instr.imm() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(instr.imm())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu/cp0/reg_config.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | (value & (1 << 0)) != 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu/cp0/reg_status.rs:43:46 [INFO] [stderr] | [INFO] [stderr] 43 | interrupts_enabled: (value & (1 << 0)) != 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn opcode(&self) -> Opcode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn rd(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn rs(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn rt(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn imm(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn imm_sign_extended(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn offset(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn offset_sign_extended(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn special_op(&self) -> SpecialOpcode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/peripheral_interface.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | if (value & (1 << 0)) != 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if self.halt { 1 } else { 0 }` [INFO] [stderr] --> src/rsp.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | (if self.halt { 1 } else { 0 } << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/rsp.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | if (value & (1 << 0)) != 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rom` [INFO] [stderr] --> src/main.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | let rom = read_bin(rom_file_name); [INFO] [stderr] | ^^^ help: consider using `_rom` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `value` [INFO] [stderr] --> src/video_interface.rs:31:41 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn write_current_reg(&mut self, value: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_value` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/cpu/cpu.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `kseg0_cache_enabled` [INFO] [stderr] --> src/cpu/cp0/reg_config.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | fn kseg0_cache_enabled(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `ram` [INFO] [stderr] --> src/interconnect.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | ram: Box<[u16]>, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `run` [INFO] [stderr] --> src/n64.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn run(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_RAM_START` [INFO] [stderr] --> src/mem_map.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | const PIF_RAM_START: u32 = 0x1fc0_07c0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_RAM_LENGTH` [INFO] [stderr] --> src/mem_map.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const PIF_RAM_LENGTH: u32 = 0x0000_0040; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PIF_RAM_END` [INFO] [stderr] --> src/mem_map.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const PIF_RAM_END: u32 = PIF_RAM_START + PIF_RAM_LENGTH - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SP_BASE_REG` [INFO] [stderr] --> src/mem_map.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const SP_BASE_REG: u32 = 0x0404_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `VI_BASE_REG` [INFO] [stderr] --> src/mem_map.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | const VI_BASE_REG: u32 = 0x0440_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PI_BASE_REG` [INFO] [stderr] --> src/mem_map.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | const PI_BASE_REG: u32 = 0x0460_0000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `reg_num` is used to index `REG_NAMES` [INFO] [stderr] --> src/cpu/cpu.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | for reg_num in 0..NUM_GPR { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for (reg_num, ) in REG_NAMES.iter().enumerate().take(NUM_GPR) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:148:59 [INFO] [stderr] | [INFO] [stderr] 148 | let res = self.read_reg_gpr(instr.rs()) & (instr.imm() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(instr.imm())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu/cpu.rs:152:59 [INFO] [stderr] | [INFO] [stderr] 152 | let res = self.read_reg_gpr(instr.rs()) | (instr.imm() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(instr.imm())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu/cp0/reg_config.rs:70:26 [INFO] [stderr] | [INFO] [stderr] 70 | (value & (1 << 0)) != 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu/cp0/reg_status.rs:43:46 [INFO] [stderr] | [INFO] [stderr] 43 | interrupts_enabled: (value & (1 << 0)) != 0, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:11:19 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn opcode(&self) -> Opcode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:19:15 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn rd(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:24:15 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn rs(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn rt(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn imm(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn imm_sign_extended(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn offset(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn offset_sign_extended(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/cpu/instruction.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn special_op(&self) -> SpecialOpcode { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/peripheral_interface.rs:10:21 [INFO] [stderr] | [INFO] [stderr] 10 | if (value & (1 << 0)) != 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `if self.halt { 1 } else { 0 }` [INFO] [stderr] --> src/rsp.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | (if self.halt { 1 } else { 0 } << 0) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/rsp.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | if (value & (1 << 0)) != 0 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.28s [INFO] running `"docker" "inspect" "d2f4c4dc12c87f8521dcd141f83dcc7e513175d715d406f67e99ba2ad5f811f2"` [INFO] running `"docker" "rm" "-f" "d2f4c4dc12c87f8521dcd141f83dcc7e513175d715d406f67e99ba2ad5f811f2"` [INFO] [stdout] d2f4c4dc12c87f8521dcd141f83dcc7e513175d715d406f67e99ba2ad5f811f2