[INFO] updating cached repository nanoxd/hello.rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nanoxd/hello.rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nanoxd/hello.rs" "work/ex/clippy-test-run/sources/stable/gh/nanoxd/hello.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nanoxd/hello.rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nanoxd/hello.rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanoxd/hello.rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanoxd/hello.rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 10933bdc16d5a900dcda3ec62264cea34973908a [INFO] sha for GitHub repo nanoxd/hello.rs: 10933bdc16d5a900dcda3ec62264cea34973908a [INFO] validating manifest of nanoxd/hello.rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nanoxd/hello.rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nanoxd/hello.rs [INFO] finished frobbing nanoxd/hello.rs [INFO] frobbed toml for nanoxd/hello.rs written to work/ex/clippy-test-run/sources/stable/gh/nanoxd/hello.rs/Cargo.toml [INFO] started frobbing nanoxd/hello.rs [INFO] finished frobbing nanoxd/hello.rs [INFO] frobbed toml for nanoxd/hello.rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanoxd/hello.rs/Cargo.toml [INFO] crate nanoxd/hello.rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nanoxd/hello.rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nanoxd/hello.rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e193a75ef1f3e850df11cf924590cd08dc56cc5cbe0124132b8c901a4ff6e7ce [INFO] running `"docker" "start" "-a" "e193a75ef1f3e850df11cf924590cd08dc56cc5cbe0124132b8c901a4ff6e7ce"` [INFO] [stderr] Checking hello_rs v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | Some(x) => println!("Item at {} is {}", 5, x), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:91:49 [INFO] [stderr] | [INFO] [stderr] 91 | Some(x) => println!("Item at {} is {}", 5, x), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v2` [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let v2 = v; // Accessing v will now cause an error [INFO] [stderr] | ^^ help: consider using `_v2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Wolf` [INFO] [stderr] --> src/trait_objects.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct Wolf { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `x` [INFO] [stderr] --> src/main.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | x: T, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `y` [INFO] [stderr] --> src/main.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | y: T, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `v2` [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let v2 = v; // Accessing v will now cause an error [INFO] [stderr] | ^^ help: consider using `_v2` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:102:15 [INFO] [stderr] | [INFO] [stderr] 102 | fn sum_vec(v: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | v.iter().fold(0, |a, &b| a + b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match x { [INFO] [stderr] 144 | | Some(Person { name: ref a @ Some(_), .. }) => println!("{:?}", a), [INFO] [stderr] 145 | | _ => {} [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(Person { name: ref a @ Some(_), .. }) = x { println!("{:?}", a) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let noise =` [INFO] [stderr] --> src/main.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | let noise = make_noise(&dog as &Bark); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Wolf` [INFO] [stderr] --> src/trait_objects.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct Wolf { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `x` [INFO] [stderr] --> src/main.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | x: T, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `y` [INFO] [stderr] --> src/main.rs:184:5 [INFO] [stderr] | [INFO] [stderr] 184 | y: T, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:102:15 [INFO] [stderr] | [INFO] [stderr] 102 | fn sum_vec(v: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/main.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | v.iter().fold(0, |a, &b| a + b) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:143:5 [INFO] [stderr] | [INFO] [stderr] 143 | / match x { [INFO] [stderr] 144 | | Some(Person { name: ref a @ Some(_), .. }) => println!("{:?}", a), [INFO] [stderr] 145 | | _ => {} [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(Person { name: ref a @ Some(_), .. }) = x { println!("{:?}", a) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let noise =` [INFO] [stderr] --> src/main.rs:284:5 [INFO] [stderr] | [INFO] [stderr] 284 | let noise = make_noise(&dog as &Bark); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.28s [INFO] running `"docker" "inspect" "e193a75ef1f3e850df11cf924590cd08dc56cc5cbe0124132b8c901a4ff6e7ce"` [INFO] running `"docker" "rm" "-f" "e193a75ef1f3e850df11cf924590cd08dc56cc5cbe0124132b8c901a4ff6e7ce"` [INFO] [stdout] e193a75ef1f3e850df11cf924590cd08dc56cc5cbe0124132b8c901a4ff6e7ce