[INFO] updating cached repository nanocurrency/generate-epoch-blocks [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nanocurrency/generate-epoch-blocks [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nanocurrency/generate-epoch-blocks" "work/ex/clippy-test-run/sources/stable/gh/nanocurrency/generate-epoch-blocks"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nanocurrency/generate-epoch-blocks'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nanocurrency/generate-epoch-blocks" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanocurrency/generate-epoch-blocks"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanocurrency/generate-epoch-blocks'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4419ca7306976cd364abb027651c883e3ea7d021 [INFO] sha for GitHub repo nanocurrency/generate-epoch-blocks: 4419ca7306976cd364abb027651c883e3ea7d021 [INFO] validating manifest of nanocurrency/generate-epoch-blocks on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nanocurrency/generate-epoch-blocks on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nanocurrency/generate-epoch-blocks [INFO] finished frobbing nanocurrency/generate-epoch-blocks [INFO] frobbed toml for nanocurrency/generate-epoch-blocks written to work/ex/clippy-test-run/sources/stable/gh/nanocurrency/generate-epoch-blocks/Cargo.toml [INFO] started frobbing nanocurrency/generate-epoch-blocks [INFO] finished frobbing nanocurrency/generate-epoch-blocks [INFO] frobbed toml for nanocurrency/generate-epoch-blocks written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nanocurrency/generate-epoch-blocks/Cargo.toml [INFO] crate nanocurrency/generate-epoch-blocks has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nanocurrency/generate-epoch-blocks against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nanocurrency/generate-epoch-blocks:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ecb26a83853ede3fca96c7372bff8386ad87d6a206baed147d554c1ee1391910 [INFO] running `"docker" "start" "-a" "ecb26a83853ede3fca96c7372bff8386ad87d6a206baed147d554c1ee1391910"` [INFO] [stderr] Checking byteorder v1.2.6 [INFO] [stderr] Compiling subtle v0.6.3 [INFO] [stderr] Compiling subtle v1.0.0 [INFO] [stderr] Checking supercow v0.1.0 [INFO] [stderr] Compiling clear_on_drop v0.2.3 [INFO] [stderr] Compiling liblmdb-sys v0.2.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking bytes v0.4.10 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking libflate v0.1.18 [INFO] [stderr] Checking blake2 v0.7.1 [INFO] [stderr] Compiling generic-array v0.9.0 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Checking http v0.1.13 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Compiling curve25519-dalek v0.16.4 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Compiling curve25519-dalek v0.20.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking lmdb-zero v0.4.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking ed25519-dalek v0.6.2 [INFO] [stderr] Checking nanocurrency-types v0.3.14 [INFO] [stderr] Checking ed25519-dalek v0.8.1 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking generate-epoch-blocks v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/count-forks.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 55 | | if previous.0.iter().any(|&b| b != 0) { [INFO] [stderr] 56 | | forks += 1; [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if previous.0.iter().any(|&b| b != 0) { [INFO] [stderr] 55 | forks += 1; [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/gen-blocks-inner.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if destination != &[0u8; 32] [INFO] [stderr] | ^^^^^^^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0u8; 32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/gen-blocks-inner.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | && destination != &epoch_link [INFO] [stderr] | ^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `epoch_link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bin/count-forks.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 55 | | if previous.0.iter().any(|&b| b != 0) { [INFO] [stderr] 56 | | forks += 1; [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 54 | } else if previous.0.iter().any(|&b| b != 0) { [INFO] [stderr] 55 | forks += 1; [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/bin/count-forks.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | if &acct[..32] != &previous.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | if acct[..32] != previous.0 { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/bin/count-forks.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | if &acct[..32] != &previous.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 51 | if acct[..32] != previous.0 { [INFO] [stderr] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/gen-blocks-inner.rs:112:12 [INFO] [stderr] | [INFO] [stderr] 112 | if destination != &[0u8; 32] [INFO] [stderr] | ^^^^^^^^^^^^^^^---------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[0u8; 32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/bin/gen-blocks-inner.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | && destination != &epoch_link [INFO] [stderr] | ^^^^^^^^^^^^^^^----------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `epoch_link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/gen-work.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | let fut = stream::iter_result(blocks_inner.into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `blocks_inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/gen-work.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | let fut = stream::iter_result(blocks_inner.into_iter()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `blocks_inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 04s [INFO] running `"docker" "inspect" "ecb26a83853ede3fca96c7372bff8386ad87d6a206baed147d554c1ee1391910"` [INFO] running `"docker" "rm" "-f" "ecb26a83853ede3fca96c7372bff8386ad87d6a206baed147d554c1ee1391910"` [INFO] [stdout] ecb26a83853ede3fca96c7372bff8386ad87d6a206baed147d554c1ee1391910