[INFO] updating cached repository naltiva/Bioinformatics [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/naltiva/Bioinformatics [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/naltiva/Bioinformatics" "work/ex/clippy-test-run/sources/stable/gh/naltiva/Bioinformatics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/naltiva/Bioinformatics'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/naltiva/Bioinformatics" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naltiva/Bioinformatics"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naltiva/Bioinformatics'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 997fb762be7837aa90ec2001657911ffd6fbc348 [INFO] sha for GitHub repo naltiva/Bioinformatics: 997fb762be7837aa90ec2001657911ffd6fbc348 [INFO] validating manifest of naltiva/Bioinformatics on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of naltiva/Bioinformatics on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing naltiva/Bioinformatics [INFO] finished frobbing naltiva/Bioinformatics [INFO] frobbed toml for naltiva/Bioinformatics written to work/ex/clippy-test-run/sources/stable/gh/naltiva/Bioinformatics/Cargo.toml [INFO] started frobbing naltiva/Bioinformatics [INFO] finished frobbing naltiva/Bioinformatics [INFO] frobbed toml for naltiva/Bioinformatics written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naltiva/Bioinformatics/Cargo.toml [INFO] crate naltiva/Bioinformatics has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting naltiva/Bioinformatics against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/naltiva/Bioinformatics:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b7a8fbe07352799188a550bc02a24a99965bd5464ac1e50e9b85344b6c41a39 [INFO] running `"docker" "start" "-a" "8b7a8fbe07352799188a550bc02a24a99965bd5464ac1e50e9b85344b6c41a39"` [INFO] [stderr] Checking PatternCount v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pattern_count.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pattern_count.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return frequent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `frequent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `pattern_count::pattern_count` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use pattern_count::pattern_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/pattern_count.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut max = count_pattern.iter().max().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `PatternCount` should have a snake case name such as `pattern_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pattern_count.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | for i in 0 ..(text.len() - pattern.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=text.len() - pattern.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pattern_count.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pattern_count.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return frequent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `frequent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `pattern_count::pattern_count` [INFO] [stderr] --> src/main.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use pattern_count::pattern_count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/pattern_count.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut max = count_pattern.iter().max().unwrap(); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: crate `PatternCount` should have a snake case name such as `pattern_count` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/pattern_count.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | for i in 0 ..(text.len() - pattern.len() + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=text.len() - pattern.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "8b7a8fbe07352799188a550bc02a24a99965bd5464ac1e50e9b85344b6c41a39"` [INFO] running `"docker" "rm" "-f" "8b7a8fbe07352799188a550bc02a24a99965bd5464ac1e50e9b85344b6c41a39"` [INFO] [stdout] 8b7a8fbe07352799188a550bc02a24a99965bd5464ac1e50e9b85344b6c41a39