[INFO] updating cached repository nakakura/DesignPatterns_Rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nakakura/DesignPatterns_Rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nakakura/DesignPatterns_Rust" "work/ex/clippy-test-run/sources/stable/gh/nakakura/DesignPatterns_Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nakakura/DesignPatterns_Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nakakura/DesignPatterns_Rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nakakura/DesignPatterns_Rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nakakura/DesignPatterns_Rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 229a58974eafe9b5bb92ee74fcb5a11d41bfc910
[INFO] sha for GitHub repo nakakura/DesignPatterns_Rust: 229a58974eafe9b5bb92ee74fcb5a11d41bfc910
[INFO] validating manifest of nakakura/DesignPatterns_Rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nakakura/DesignPatterns_Rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nakakura/DesignPatterns_Rust
[INFO] finished frobbing nakakura/DesignPatterns_Rust
[INFO] frobbed toml for nakakura/DesignPatterns_Rust written to work/ex/clippy-test-run/sources/stable/gh/nakakura/DesignPatterns_Rust/Cargo.toml
[INFO] started frobbing nakakura/DesignPatterns_Rust
[INFO] finished frobbing nakakura/DesignPatterns_Rust
[INFO] frobbed toml for nakakura/DesignPatterns_Rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nakakura/DesignPatterns_Rust/Cargo.toml
[INFO] crate nakakura/DesignPatterns_Rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nakakura/DesignPatterns_Rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nakakura/DesignPatterns_Rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 83b62af9356eaf9fde84669a20cf5719e5a11f3897ad0645b0e30feeaaeb4e2a
[INFO] running `"docker" "start" "-a" "83b62af9356eaf9fde84669a20cf5719e5a11f3897ad0645b0e30feeaaeb4e2a"`
[INFO] [stderr]     Checking rand v0.3.15
[INFO] [stderr]     Checking designpattern_rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/command/main.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |            command_opt.map(|command| {
[INFO] [stderr]    |   _________^
[INFO] [stderr]    |  |_________|
[INFO] [stderr]    | ||
[INFO] [stderr] 51 | ||             let t = &mut *self.target;
[INFO] [stderr] 52 | ||             command.undo(t);
[INFO] [stderr] 53 | ||             self.commands.push_front(command);
[INFO] [stderr] 54 | ||         });
[INFO] [stderr]    | ||__________^- help: try this: `if let Some(command) = command_opt { ... }`
[INFO] [stderr]    | |___________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/command/main.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         match self {
[INFO] [stderr] 102 | |             &MoveForward => {
[INFO] [stderr] 103 | |                 r.move_forward();
[INFO] [stderr] 104 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 112 | |             }
[INFO] [stderr] 113 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 101 |         match *self {
[INFO] [stderr] 102 |             MoveForward => {
[INFO] [stderr] 103 |                 r.move_forward();
[INFO] [stderr] 104 |             },
[INFO] [stderr] 105 |             TurnRight => {
[INFO] [stderr] 106 |                 let (dx, dy) = r.get_direction();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/command/main.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 | /         match self {
[INFO] [stderr] 119 | |             &MoveForward => {
[INFO] [stderr] 120 | |                 let c1 = TurnRight;
[INFO] [stderr] 121 | |                 c1.execute(r);
[INFO] [stderr] ...   |
[INFO] [stderr] 135 | |             }
[INFO] [stderr] 136 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 118 |         match *self {
[INFO] [stderr] 119 |             MoveForward => {
[INFO] [stderr] 120 |                 let c1 = TurnRight;
[INFO] [stderr] 121 |                 c1.execute(r);
[INFO] [stderr] 122 |                 c1.execute(r);
[INFO] [stderr] 123 |                 self.execute(r);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `State`
[INFO] [stderr]   --> src/state/main.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / enum StateContextEnum {
[INFO] [stderr] 10 | |     StatePowerOn(StatePowerOn),
[INFO] [stderr] 11 | |     StatePowerOff(StatePowerOff),
[INFO] [stderr] 12 | |     StateStop(StateStop),
[INFO] [stderr] 13 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/template/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match self {
[INFO] [stderr] 24 | |             &ConcreteProductX1(ref x1) => x1.get_value(),
[INFO] [stderr] 25 | |             &ConcreteProductX2(ref x2) => x2.get_value(),
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |         match *self {
[INFO] [stderr] 24 |             ConcreteProductX1(ref x1) => x1.get_value(),
[INFO] [stderr] 25 |             ConcreteProductX2(ref x2) => x2.get_value(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/template/main.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 | /         match self {
[INFO] [stderr] 34 | |             &ConcreteProductY1(ref y1) => y1.get_value(),
[INFO] [stderr] 35 | |             &ConcreteProductY2(ref y2) => y2.get_value(),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 33 |         match *self {
[INFO] [stderr] 34 |             ConcreteProductY1(ref y1) => y1.get_value(),
[INFO] [stderr] 35 |             ConcreteProductY2(ref y2) => y2.get_value(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/state/main.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match self {
[INFO] [stderr] 22 | |             &StateContextEnum::StatePowerOn(ref s) => {
[INFO] [stderr] 23 | |                 s.on_press_button()
[INFO] [stderr] 24 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |             },
[INFO] [stderr] 31 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 21 |         match *self {
[INFO] [stderr] 22 |             StateContextEnum::StatePowerOn(ref s) => {
[INFO] [stderr] 23 |                 s.on_press_button()
[INFO] [stderr] 24 |             },
[INFO] [stderr] 25 |             StateContextEnum::StatePowerOff(ref s) => {
[INFO] [stderr] 26 |                 s.on_press_button()
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/template/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         match self {
[INFO] [stderr] 24 | |             &ConcreteProductX1(ref x1) => x1.get_value(),
[INFO] [stderr] 25 | |             &ConcreteProductX2(ref x2) => x2.get_value(),
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 23 |         match *self {
[INFO] [stderr] 24 |             ConcreteProductX1(ref x1) => x1.get_value(),
[INFO] [stderr] 25 |             ConcreteProductX2(ref x2) => x2.get_value(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/template/main.rs:33:9
[INFO] [stderr]    |
[INFO] [stderr] 33 | /         match self {
[INFO] [stderr] 34 | |             &ConcreteProductY1(ref y1) => y1.get_value(),
[INFO] [stderr] 35 | |             &ConcreteProductY2(ref y2) => y2.get_value(),
[INFO] [stderr] 36 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 33 |         match *self {
[INFO] [stderr] 34 |             ConcreteProductY1(ref y1) => y1.get_value(),
[INFO] [stderr] 35 |             ConcreteProductY2(ref y2) => y2.get_value(),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `State`
[INFO] [stderr]   --> src/state/main.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / enum StateContextEnum {
[INFO] [stderr] 10 | |     StatePowerOn(StatePowerOn),
[INFO] [stderr] 11 | |     StatePowerOff(StatePowerOff),
[INFO] [stderr] 12 | |     StateStop(StateStop),
[INFO] [stderr] 13 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure
[INFO] [stderr]   --> src/command/main.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 |            command_opt.map(|command| {
[INFO] [stderr]    |   _________^
[INFO] [stderr]    |  |_________|
[INFO] [stderr]    | ||
[INFO] [stderr] 51 | ||             let t = &mut *self.target;
[INFO] [stderr] 52 | ||             command.undo(t);
[INFO] [stderr] 53 | ||             self.commands.push_front(command);
[INFO] [stderr] 54 | ||         });
[INFO] [stderr]    | ||__________^- help: try this: `if let Some(command) = command_opt { ... }`
[INFO] [stderr]    | |___________|
[INFO] [stderr]    | 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::option_map_unit_fn)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/command/main.rs:101:9
[INFO] [stderr]     |
[INFO] [stderr] 101 | /         match self {
[INFO] [stderr] 102 | |             &MoveForward => {
[INFO] [stderr] 103 | |                 r.move_forward();
[INFO] [stderr] 104 | |             },
[INFO] [stderr] ...   |
[INFO] [stderr] 112 | |             }
[INFO] [stderr] 113 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 101 |         match *self {
[INFO] [stderr] 102 |             MoveForward => {
[INFO] [stderr] 103 |                 r.move_forward();
[INFO] [stderr] 104 |             },
[INFO] [stderr] 105 |             TurnRight => {
[INFO] [stderr] 106 |                 let (dx, dy) = r.get_direction();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/command/main.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 | /         match self {
[INFO] [stderr] 119 | |             &MoveForward => {
[INFO] [stderr] 120 | |                 let c1 = TurnRight;
[INFO] [stderr] 121 | |                 c1.execute(r);
[INFO] [stderr] ...   |
[INFO] [stderr] 135 | |             }
[INFO] [stderr] 136 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 118 |         match *self {
[INFO] [stderr] 119 |             MoveForward => {
[INFO] [stderr] 120 |                 let c1 = TurnRight;
[INFO] [stderr] 121 |                 c1.execute(r);
[INFO] [stderr] 122 |                 c1.execute(r);
[INFO] [stderr] 123 |                 self.execute(r);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/state/main.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match self {
[INFO] [stderr] 22 | |             &StateContextEnum::StatePowerOn(ref s) => {
[INFO] [stderr] 23 | |                 s.on_press_button()
[INFO] [stderr] 24 | |             },
[INFO] [stderr] ...  |
[INFO] [stderr] 30 | |             },
[INFO] [stderr] 31 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 21 |         match *self {
[INFO] [stderr] 22 |             StateContextEnum::StatePowerOn(ref s) => {
[INFO] [stderr] 23 |                 s.on_press_button()
[INFO] [stderr] 24 |             },
[INFO] [stderr] 25 |             StateContextEnum::StatePowerOff(ref s) => {
[INFO] [stderr] 26 |                 s.on_press_button()
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.19s
[INFO] running `"docker" "inspect" "83b62af9356eaf9fde84669a20cf5719e5a11f3897ad0645b0e30feeaaeb4e2a"`
[INFO] running `"docker" "rm" "-f" "83b62af9356eaf9fde84669a20cf5719e5a11f3897ad0645b0e30feeaaeb4e2a"`
[INFO] [stdout] 83b62af9356eaf9fde84669a20cf5719e5a11f3897ad0645b0e30feeaaeb4e2a