[INFO] updating cached repository naftulikay/nfty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/naftulikay/nfty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/naftulikay/nfty" "work/ex/clippy-test-run/sources/stable/gh/naftulikay/nfty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/naftulikay/nfty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/naftulikay/nfty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naftulikay/nfty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naftulikay/nfty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] be981c67eab4c1e47266c89a1ccced37f16ec0e1 [INFO] sha for GitHub repo naftulikay/nfty: be981c67eab4c1e47266c89a1ccced37f16ec0e1 [INFO] validating manifest of naftulikay/nfty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of naftulikay/nfty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing naftulikay/nfty [INFO] finished frobbing naftulikay/nfty [INFO] frobbed toml for naftulikay/nfty written to work/ex/clippy-test-run/sources/stable/gh/naftulikay/nfty/Cargo.toml [INFO] started frobbing naftulikay/nfty [INFO] finished frobbing naftulikay/nfty [INFO] frobbed toml for naftulikay/nfty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/naftulikay/nfty/Cargo.toml [INFO] crate naftulikay/nfty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting naftulikay/nfty against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/naftulikay/nfty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db7b28288ea5057fc6d3b5f6ce51ff0a1e3c84f310684e813e420b142dbc1694 [INFO] running `"docker" "start" "-a" "db7b28288ea5057fc6d3b5f6ce51ff0a1e3c84f310684e813e420b142dbc1694"` [INFO] [stderr] Compiling pkg-config v0.3.10 [INFO] [stderr] Compiling cmake v0.1.30 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking ordered-float v0.5.0 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking parking_lot_core v0.2.13 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking serde-value v0.5.2 [INFO] [stderr] Checking parking_lot v0.5.4 [INFO] [stderr] Compiling structopt-derive v0.2.6 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling curl-sys v0.4.2 [INFO] [stderr] Compiling libgit2-sys v0.7.1 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking structopt v0.2.6 [INFO] [stderr] Checking log4rs v0.8.0 [INFO] [stderr] Checking log4rs-syslog v3.0.1 [INFO] [stderr] Checking git2 v0.7.1 [INFO] [stderr] Checking nfty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/project/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return project_dir.exists() && project_dir.is_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `project_dir.exists() && project_dir.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/api/project/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/api/project/mod.rs:32:44 [INFO] [stderr] | [INFO] [stderr] 32 | pub static ref PROJECT_ROOT: PathBuf = home_dir().expect("unable to get home dir").join("devel").join("src"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/api/project/mod.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | return project_dir.exists() && project_dir.is_dir() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `project_dir.exists() && project_dir.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/api/project/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/api/project/mod.rs:32:44 [INFO] [stderr] | [INFO] [stderr] 32 | pub static ref PROJECT_ROOT: PathBuf = home_dir().expect("unable to get home dir").join("devel").join("src"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/cli/bring/mod.rs:30:75 [INFO] [stderr] | [INFO] [stderr] 30 | self.repositories.par_iter().zip(bars).for_each(|(repository, mut bar)| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/cli/bring/mod.rs:30:75 [INFO] [stderr] | [INFO] [stderr] 30 | self.repositories.par_iter().zip(bars).for_each(|(repository, mut bar)| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 16s [INFO] running `"docker" "inspect" "db7b28288ea5057fc6d3b5f6ce51ff0a1e3c84f310684e813e420b142dbc1694"` [INFO] running `"docker" "rm" "-f" "db7b28288ea5057fc6d3b5f6ce51ff0a1e3c84f310684e813e420b142dbc1694"` [INFO] [stdout] db7b28288ea5057fc6d3b5f6ce51ff0a1e3c84f310684e813e420b142dbc1694