[INFO] updating cached repository nachoparker/dutree
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/nachoparker/dutree
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/nachoparker/dutree" "work/ex/clippy-test-run/sources/stable/gh/nachoparker/dutree"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nachoparker/dutree'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/nachoparker/dutree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nachoparker/dutree"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nachoparker/dutree'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 970323dcf7f851351bbaf42ffca163d3e87e0ce1
[INFO] sha for GitHub repo nachoparker/dutree: 970323dcf7f851351bbaf42ffca163d3e87e0ce1
[INFO] validating manifest of nachoparker/dutree on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of nachoparker/dutree on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing nachoparker/dutree
[INFO] finished frobbing nachoparker/dutree
[INFO] frobbed toml for nachoparker/dutree written to work/ex/clippy-test-run/sources/stable/gh/nachoparker/dutree/Cargo.toml
[INFO] started frobbing nachoparker/dutree
[INFO] finished frobbing nachoparker/dutree
[INFO] frobbed toml for nachoparker/dutree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nachoparker/dutree/Cargo.toml
[INFO] crate nachoparker/dutree has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting nachoparker/dutree against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nachoparker/dutree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c76799e591673d6bee22a14b9b0219e63bb190c57ff9ab058dba39e27b023a32
[INFO] running `"docker" "start" "-a" "c76799e591673d6bee22a14b9b0219e63bb190c57ff9ab058dba39e27b023a32"`
[INFO] [stderr]     Checking terminal_size v0.1.7
[INFO] [stderr]     Checking dutree v0.2.9 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:481:16
[INFO] [stderr]     |
[INFO] [stderr] 481 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 482 | |             if let Some( col ) = color_dict.get( &"or".to_string() )  {
[INFO] [stderr] 483 | |                 return Some( &col );
[INFO] [stderr] 484 | |             }
[INFO] [stderr] 485 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 481 |         } else if let Some( col ) = color_dict.get( &"or".to_string() )  {
[INFO] [stderr] 482 |     return Some( &col );
[INFO] [stderr] 483 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:481:16
[INFO] [stderr]     |
[INFO] [stderr] 481 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 482 | |             if let Some( col ) = color_dict.get( &"or".to_string() )  {
[INFO] [stderr] 483 | |                 return Some( &col );
[INFO] [stderr] 484 | |             }
[INFO] [stderr] 485 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 481 |         } else if let Some( col ) = color_dict.get( &"or".to_string() )  {
[INFO] [stderr] 482 |     return Some( &col );
[INFO] [stderr] 483 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:135:12
[INFO] [stderr]     |
[INFO] [stderr] 135 |         if opt.free.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `opt.free.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:155:35
[INFO] [stderr]     |
[INFO] [stderr] 155 |         let mut depth = depth_opt.unwrap_or("1".to_string()).parse().unwrap_or(1);
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:165:37
[INFO] [stderr]     |
[INFO] [stderr] 165 |             let aggr_val = aggr_opt.unwrap_or("1M".to_string());
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1M".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:215:25
[INFO] [stderr]     |
[INFO] [stderr] 215 |     abspath.file_name().unwrap_or( std::ffi::OsStr::new( "/" ) )  // '/' has no filename
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::ffi::OsStr::new( "/" ))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:135:12
[INFO] [stderr]     |
[INFO] [stderr] 135 |         if opt.free.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `opt.free.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:277:69
[INFO] [stderr]     |
[INFO] [stderr] 277 |                         if cfg.hiddn_flag && entry_name.starts_with("."){ continue }
[INFO] [stderr]     |                                                                     ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/lib.rs:380:28
[INFO] [stderr]     |
[INFO] [stderr] 380 |                       if let Some(_) = entry.entries {
[INFO] [stderr]     |  _____________________-      ^^^^^^^
[INFO] [stderr] 381 | |                         entry.print_entries( op, bytes, bytes_flag, ascii_flag,
[INFO] [stderr] 382 | |                                              bar_width, tree_name_width );
[INFO] [stderr] 383 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if entry.entries.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:416:21
[INFO] [stderr]     |
[INFO] [stderr] 416 | fn fmt_bar( bytes : &Vec<u64>, width : usize, ascii_flag : bool ) -> String {
[INFO] [stderr]     |                     ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:155:35
[INFO] [stderr]     |
[INFO] [stderr] 155 |         let mut depth = depth_opt.unwrap_or("1".to_string()).parse().unwrap_or(1);
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:165:37
[INFO] [stderr]     |
[INFO] [stderr] 165 |             let aggr_val = aggr_opt.unwrap_or("1M".to_string());
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "1M".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:215:25
[INFO] [stderr]     |
[INFO] [stderr] 215 |     abspath.file_name().unwrap_or( std::ffi::OsStr::new( "/" ) )  // '/' has no filename
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| std::ffi::OsStr::new( "/" ))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's keys
[INFO] [stderr]    --> src/lib.rs:510:28
[INFO] [stderr]     |
[INFO] [stderr] 510 |         for ( key , _ ) in color_dict {
[INFO] [stderr]     |                            ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 510 |         for key in color_dict.keys() {
[INFO] [stderr]     |             ^^^    ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:537:41
[INFO] [stderr]     |
[INFO] [stderr] 537 |     let env_str = env::var("LS_COLORS").unwrap_or( "".to_string() );
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:541:12
[INFO] [stderr]     |
[INFO] [stderr] 541 |         if entry.len() == 0 { break; }
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `entry.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:277:69
[INFO] [stderr]     |
[INFO] [stderr] 277 |                         if cfg.hiddn_flag && entry_name.starts_with("."){ continue }
[INFO] [stderr]     |                                                                     ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/lib.rs:380:28
[INFO] [stderr]     |
[INFO] [stderr] 380 |                       if let Some(_) = entry.entries {
[INFO] [stderr]     |  _____________________-      ^^^^^^^
[INFO] [stderr] 381 | |                         entry.print_entries( op, bytes, bytes_flag, ascii_flag,
[INFO] [stderr] 382 | |                                              bar_width, tree_name_width );
[INFO] [stderr] 383 | |                     }
[INFO] [stderr]     | |_____________________- help: try this: `if entry.entries.is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:416:21
[INFO] [stderr]     |
[INFO] [stderr] 416 | fn fmt_bar( bytes : &Vec<u64>, width : usize, ascii_flag : bool ) -> String {
[INFO] [stderr]     |                     ^^^^^^^^^ help: change this to: `&[u64]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to want to iterate on a map's keys
[INFO] [stderr]    --> src/lib.rs:510:28
[INFO] [stderr]     |
[INFO] [stderr] 510 |         for ( key , _ ) in color_dict {
[INFO] [stderr]     |                            ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::for_kv_map)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stderr] help: use the corresponding method
[INFO] [stderr]     |
[INFO] [stderr] 510 |         for key in color_dict.keys() {
[INFO] [stderr]     |             ^^^    ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:537:41
[INFO] [stderr]     |
[INFO] [stderr] 537 |     let env_str = env::var("LS_COLORS").unwrap_or( "".to_string() );
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:541:12
[INFO] [stderr]     |
[INFO] [stderr] 541 |         if entry.len() == 0 { break; }
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `entry.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.66s
[INFO] running `"docker" "inspect" "c76799e591673d6bee22a14b9b0219e63bb190c57ff9ab058dba39e27b023a32"`
[INFO] running `"docker" "rm" "-f" "c76799e591673d6bee22a14b9b0219e63bb190c57ff9ab058dba39e27b023a32"`
[INFO] [stdout] c76799e591673d6bee22a14b9b0219e63bb190c57ff9ab058dba39e27b023a32