[INFO] updating cached repository nacardin/wayland-tutorials [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nacardin/wayland-tutorials [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nacardin/wayland-tutorials" "work/ex/clippy-test-run/sources/stable/gh/nacardin/wayland-tutorials"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nacardin/wayland-tutorials'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nacardin/wayland-tutorials" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nacardin/wayland-tutorials"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nacardin/wayland-tutorials'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce64fae65654adfe30683807b85aff0ff0325a37 [INFO] sha for GitHub repo nacardin/wayland-tutorials: ce64fae65654adfe30683807b85aff0ff0325a37 [INFO] validating manifest of nacardin/wayland-tutorials on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nacardin/wayland-tutorials on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nacardin/wayland-tutorials [INFO] finished frobbing nacardin/wayland-tutorials [INFO] frobbed toml for nacardin/wayland-tutorials written to work/ex/clippy-test-run/sources/stable/gh/nacardin/wayland-tutorials/Cargo.toml [INFO] started frobbing nacardin/wayland-tutorials [INFO] finished frobbing nacardin/wayland-tutorials [INFO] frobbed toml for nacardin/wayland-tutorials written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nacardin/wayland-tutorials/Cargo.toml [INFO] crate nacardin/wayland-tutorials has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting nacardin/wayland-tutorials against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nacardin/wayland-tutorials:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 08e31c0009111b989967c6decba348e8f1a6bc575c2340f1a07d1de67e9e22cc [INFO] running `"docker" "start" "-a" "08e31c0009111b989967c6decba348e8f1a6bc575c2340f1a07d1de67e9e22cc"` [INFO] [stderr] Compiling libloading v0.4.2 [INFO] [stderr] Compiling wayland-scanner v0.12.2 [INFO] [stderr] Compiling wayland-client v0.12.2 [INFO] [stderr] Checking dlib v0.4.0 [INFO] [stderr] Checking wayland-sys v0.12.2 [INFO] [stderr] Checking wayland-tutorials v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | true => 0xFFFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | false => 0xFF000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | true => 0xFFFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:159:22 [INFO] [stderr] | [INFO] [stderr] 159 | false => 0xFF000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:180:52 [INFO] [stderr] | [INFO] [stderr] 180 | enter: |_, _, _pointer, _serial, _surface, x, y| {}, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:180:55 [INFO] [stderr] | [INFO] [stderr] 180 | enter: |_, _, _pointer, _serial, _surface, x, y| {}, [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/main.rs:189:50 [INFO] [stderr] | [INFO] [stderr] 189 | button: |_, _, _pointer, _serial, _time, button, state| {}, [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:189:58 [INFO] [stderr] | [INFO] [stderr] 189 | button: |_, _, _pointer, _serial, _time, button, state| {}, [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `keys` [INFO] [stderr] --> src/main.rs:200:54 [INFO] [stderr] | [INFO] [stderr] 200 | keymap: |_, _, _keyboard, _serial, _surface, keys| {}, [INFO] [stderr] | ^^^^ help: consider using `_keys` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `keys` [INFO] [stderr] --> src/main.rs:201:53 [INFO] [stderr] | [INFO] [stderr] 201 | enter: |_, _, _keyboard, _serial, _surface, keys| {}, [INFO] [stderr] | ^^^^ help: consider using `_keys` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mods_depressed` [INFO] [stderr] --> src/main.rs:227:47 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_mods_depressed` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mods_latched` [INFO] [stderr] --> src/main.rs:227:63 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_mods_latched` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mods_locked` [INFO] [stderr] --> src/main.rs:227:77 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_mods_locked` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `group` [INFO] [stderr] --> src/main.rs:227:90 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^ help: consider using `_group` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | let pixel_value = match is_coords_in_rect(&readable_app_state.rect, x, y) { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 158 | | true => 0xFFFFFFFF, [INFO] [stderr] 159 | | false => 0xFF000000 [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_coords_in_rect(&readable_app_state.rect, x, y) { 0xFFFFFFFF } else { 0xFF000000 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:180:52 [INFO] [stderr] | [INFO] [stderr] 180 | enter: |_, _, _pointer, _serial, _surface, x, y| {}, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/main.rs:180:55 [INFO] [stderr] | [INFO] [stderr] 180 | enter: |_, _, _pointer, _serial, _surface, x, y| {}, [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/main.rs:189:50 [INFO] [stderr] | [INFO] [stderr] 189 | button: |_, _, _pointer, _serial, _time, button, state| {}, [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/main.rs:189:58 [INFO] [stderr] | [INFO] [stderr] 189 | button: |_, _, _pointer, _serial, _time, button, state| {}, [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `keys` [INFO] [stderr] --> src/main.rs:200:54 [INFO] [stderr] | [INFO] [stderr] 200 | keymap: |_, _, _keyboard, _serial, _surface, keys| {}, [INFO] [stderr] | ^^^^ help: consider using `_keys` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `keys` [INFO] [stderr] --> src/main.rs:201:53 [INFO] [stderr] | [INFO] [stderr] 201 | enter: |_, _, _keyboard, _serial, _surface, keys| {}, [INFO] [stderr] | ^^^^ help: consider using `_keys` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mods_depressed` [INFO] [stderr] --> src/main.rs:227:47 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_mods_depressed` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mods_latched` [INFO] [stderr] --> src/main.rs:227:63 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_mods_latched` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mods_locked` [INFO] [stderr] --> src/main.rs:227:77 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_mods_locked` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `group` [INFO] [stderr] --> src/main.rs:227:90 [INFO] [stderr] | [INFO] [stderr] 227 | modifiers: |_, _, _keyboard, _serial, mods_depressed, mods_latched, mods_locked, group| {}, [INFO] [stderr] | ^^^^^ help: consider using `_group` instead [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:211:21 [INFO] [stderr] | [INFO] [stderr] 211 | writable_app_state.rect.y = writable_app_state.rect.y - 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.y -= 5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | writable_app_state.rect.y = writable_app_state.rect.y + 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.y += 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:217:21 [INFO] [stderr] | [INFO] [stderr] 217 | writable_app_state.rect.x = writable_app_state.rect.x - 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.x -= 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | writable_app_state.rect.x = writable_app_state.rect.x + 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.x += 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:157:27 [INFO] [stderr] | [INFO] [stderr] 157 | let pixel_value = match is_coords_in_rect(&readable_app_state.rect, x, y) { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 158 | | true => 0xFFFFFFFF, [INFO] [stderr] 159 | | false => 0xFF000000 [INFO] [stderr] 160 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if is_coords_in_rect(&readable_app_state.rect, x, y) { 0xFFFFFFFF } else { 0xFF000000 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:211:21 [INFO] [stderr] | [INFO] [stderr] 211 | writable_app_state.rect.y = writable_app_state.rect.y - 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.y -= 5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | writable_app_state.rect.y = writable_app_state.rect.y + 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.y += 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:217:21 [INFO] [stderr] | [INFO] [stderr] 217 | writable_app_state.rect.x = writable_app_state.rect.x - 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.x -= 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:220:21 [INFO] [stderr] | [INFO] [stderr] 220 | writable_app_state.rect.x = writable_app_state.rect.x + 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writable_app_state.rect.x += 5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.04s [INFO] running `"docker" "inspect" "08e31c0009111b989967c6decba348e8f1a6bc575c2340f1a07d1de67e9e22cc"` [INFO] running `"docker" "rm" "-f" "08e31c0009111b989967c6decba348e8f1a6bc575c2340f1a07d1de67e9e22cc"` [INFO] [stdout] 08e31c0009111b989967c6decba348e8f1a6bc575c2340f1a07d1de67e9e22cc