[INFO] updating cached repository nacardin/cargo-build-deps [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/nacardin/cargo-build-deps [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/nacardin/cargo-build-deps" "work/ex/clippy-test-run/sources/stable/gh/nacardin/cargo-build-deps"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/nacardin/cargo-build-deps'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/nacardin/cargo-build-deps" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nacardin/cargo-build-deps"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nacardin/cargo-build-deps'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 439596846ec0558d64870ba0ef3008748323ca16 [INFO] sha for GitHub repo nacardin/cargo-build-deps: 439596846ec0558d64870ba0ef3008748323ca16 [INFO] validating manifest of nacardin/cargo-build-deps on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of nacardin/cargo-build-deps on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing nacardin/cargo-build-deps [INFO] finished frobbing nacardin/cargo-build-deps [INFO] frobbed toml for nacardin/cargo-build-deps written to work/ex/clippy-test-run/sources/stable/gh/nacardin/cargo-build-deps/Cargo.toml [INFO] started frobbing nacardin/cargo-build-deps [INFO] finished frobbing nacardin/cargo-build-deps [INFO] frobbed toml for nacardin/cargo-build-deps written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/nacardin/cargo-build-deps/Cargo.toml [INFO] crate nacardin/cargo-build-deps has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] linting nacardin/cargo-build-deps against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/nacardin/cargo-build-deps:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 802b434ac1227e8cd05b2172131e40ef9d14505f4d96c7887457a5e0cc62a013 [INFO] running `"docker" "start" "-a" "802b434ac1227e8cd05b2172131e40ef9d14505f4d96c7887457a5e0cc62a013"` [INFO] [stderr] Checking cargo-build-deps v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match toml { [INFO] [stderr] 46 | | &Toml::Table(ref table) => { [INFO] [stderr] 47 | | match table.get("package") { [INFO] [stderr] 48 | | Some(&Toml::Table(ref table)) => { [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => panic!("failed to parse Cargo.toml: incorrect format"), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *toml { [INFO] [stderr] 46 | Toml::Table(ref table) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:89 [INFO] [stderr] | [INFO] [stderr] 72 | let mut value_parts = value.as_str().unwrap().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / match toml { [INFO] [stderr] 46 | | &Toml::Table(ref table) => { [INFO] [stderr] 47 | | match table.get("package") { [INFO] [stderr] 48 | | Some(&Toml::Table(ref table)) => { [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => panic!("failed to parse Cargo.toml: incorrect format"), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 45 | match *toml { [INFO] [stderr] 46 | Toml::Table(ref table) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:72:89 [INFO] [stderr] | [INFO] [stderr] 72 | let mut value_parts = value.as_str().unwrap().split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "802b434ac1227e8cd05b2172131e40ef9d14505f4d96c7887457a5e0cc62a013"` [INFO] running `"docker" "rm" "-f" "802b434ac1227e8cd05b2172131e40ef9d14505f4d96c7887457a5e0cc62a013"` [INFO] [stdout] 802b434ac1227e8cd05b2172131e40ef9d14505f4d96c7887457a5e0cc62a013