[INFO] updating cached repository na-o-ys/train-dijkstra-demo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/na-o-ys/train-dijkstra-demo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/na-o-ys/train-dijkstra-demo" "work/ex/clippy-test-run/sources/stable/gh/na-o-ys/train-dijkstra-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/na-o-ys/train-dijkstra-demo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/na-o-ys/train-dijkstra-demo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/na-o-ys/train-dijkstra-demo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/na-o-ys/train-dijkstra-demo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e4be6a1addd959ae23c70e829c8ec2e3e86bc259 [INFO] sha for GitHub repo na-o-ys/train-dijkstra-demo: e4be6a1addd959ae23c70e829c8ec2e3e86bc259 [INFO] validating manifest of na-o-ys/train-dijkstra-demo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of na-o-ys/train-dijkstra-demo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing na-o-ys/train-dijkstra-demo [INFO] finished frobbing na-o-ys/train-dijkstra-demo [INFO] frobbed toml for na-o-ys/train-dijkstra-demo written to work/ex/clippy-test-run/sources/stable/gh/na-o-ys/train-dijkstra-demo/Cargo.toml [INFO] started frobbing na-o-ys/train-dijkstra-demo [INFO] finished frobbing na-o-ys/train-dijkstra-demo [INFO] frobbed toml for na-o-ys/train-dijkstra-demo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/na-o-ys/train-dijkstra-demo/Cargo.toml [INFO] crate na-o-ys/train-dijkstra-demo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting na-o-ys/train-dijkstra-demo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/na-o-ys/train-dijkstra-demo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc3d10df933ee701cd9d5b8db2cc3f662e8094d71e579fa835e423a7f598ce9f [INFO] running `"docker" "start" "-a" "fc3d10df933ee701cd9d5b8db2cc3f662e8094d71e579fa835e423a7f598ce9f"` [INFO] [stderr] Checking serde_json v0.9.9 [INFO] [stderr] Checking train-dijkstra-demo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timetable.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | TimeTable { stations: stations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `stations` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/timetable.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | TimeTable { stations: stations } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `stations` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:21:44 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn initialize(time: Time, station: &String) -> Node { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 21 | pub fn initialize(time: Time, station: &str) -> Node { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `station.clone()` to [INFO] [stderr] | [INFO] [stderr] 24 | station_to: station.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/time.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | let selfmins = &self.hour * 60 + &self.min; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/timetable.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn station(&self, station: &String) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/node.rs:21:44 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn initialize(time: Time, station: &String) -> Node { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 21 | pub fn initialize(time: Time, station: &str) -> Node { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `station.clone()` to [INFO] [stderr] | [INFO] [stderr] 24 | station_to: station.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/time.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | let selfmins = &self.hour * 60 + &self.min; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `self.min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/timetable.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn station(&self, station: &String) -> Option<&Vec> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/main.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.40s [INFO] running `"docker" "inspect" "fc3d10df933ee701cd9d5b8db2cc3f662e8094d71e579fa835e423a7f598ce9f"` [INFO] running `"docker" "rm" "-f" "fc3d10df933ee701cd9d5b8db2cc3f662e8094d71e579fa835e423a7f598ce9f"` [INFO] [stdout] fc3d10df933ee701cd9d5b8db2cc3f662e8094d71e579fa835e423a7f598ce9f