[INFO] updating cached repository n3phtys/rs-cli-utils [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/n3phtys/rs-cli-utils [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/n3phtys/rs-cli-utils" "work/ex/clippy-test-run/sources/stable/gh/n3phtys/rs-cli-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/n3phtys/rs-cli-utils'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/n3phtys/rs-cli-utils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n3phtys/rs-cli-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n3phtys/rs-cli-utils'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 32d61941dc8f27d81ff9a55a91653288f59fc49a [INFO] sha for GitHub repo n3phtys/rs-cli-utils: 32d61941dc8f27d81ff9a55a91653288f59fc49a [INFO] validating manifest of n3phtys/rs-cli-utils on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of n3phtys/rs-cli-utils on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing n3phtys/rs-cli-utils [INFO] finished frobbing n3phtys/rs-cli-utils [INFO] frobbed toml for n3phtys/rs-cli-utils written to work/ex/clippy-test-run/sources/stable/gh/n3phtys/rs-cli-utils/Cargo.toml [INFO] started frobbing n3phtys/rs-cli-utils [INFO] finished frobbing n3phtys/rs-cli-utils [INFO] frobbed toml for n3phtys/rs-cli-utils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n3phtys/rs-cli-utils/Cargo.toml [INFO] crate n3phtys/rs-cli-utils has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting n3phtys/rs-cli-utils against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/n3phtys/rs-cli-utils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3dd2b03a04fa6e008f52deff6d5e2a2d75c40bb43a7a52d522bc687d3d2e98c3 [INFO] running `"docker" "start" "-a" "3dd2b03a04fa6e008f52deff6d5e2a2d75c40bb43a7a52d522bc687d3d2e98c3"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/bin/execute.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: unused manifest key: bin.0.src [INFO] [stderr] warning: unused manifest key: bin.1.src [INFO] [stderr] Checking cli-utils v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/timer.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | let time_ms: u64 = time_ns / 1000000u64; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/timer.rs:30:69 [INFO] [stderr] | [INFO] [stderr] 30 | println!("Command took {} ms (+ {} nanos)", time_ms, (time_ns % 1000000)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/timer.rs:28:34 [INFO] [stderr] | [INFO] [stderr] 28 | let time_ms: u64 = time_ns / 1000000u64; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/timer.rs:30:69 [INFO] [stderr] | [INFO] [stderr] 30 | println!("Command took {} ms (+ {} nanos)", time_ms, (time_ns % 1000000)); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/execute.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `CmdResult { time_begin_ns: begin_ns, time_end_ns: end_ns, output: std::str::from_utf8(&stdout_of_child).unwrap().to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.90s [INFO] running `"docker" "inspect" "3dd2b03a04fa6e008f52deff6d5e2a2d75c40bb43a7a52d522bc687d3d2e98c3"` [INFO] running `"docker" "rm" "-f" "3dd2b03a04fa6e008f52deff6d5e2a2d75c40bb43a7a52d522bc687d3d2e98c3"` [INFO] [stdout] 3dd2b03a04fa6e008f52deff6d5e2a2d75c40bb43a7a52d522bc687d3d2e98c3