[INFO] updating cached repository n2kia4/bkm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/n2kia4/bkm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/n2kia4/bkm" "work/ex/clippy-test-run/sources/stable/gh/n2kia4/bkm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/n2kia4/bkm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/n2kia4/bkm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n2kia4/bkm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n2kia4/bkm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3553ec702eb9d290d38c77b793bbc222bbb8f278 [INFO] sha for GitHub repo n2kia4/bkm: 3553ec702eb9d290d38c77b793bbc222bbb8f278 [INFO] validating manifest of n2kia4/bkm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of n2kia4/bkm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing n2kia4/bkm [INFO] finished frobbing n2kia4/bkm [INFO] frobbed toml for n2kia4/bkm written to work/ex/clippy-test-run/sources/stable/gh/n2kia4/bkm/Cargo.toml [INFO] started frobbing n2kia4/bkm [INFO] finished frobbing n2kia4/bkm [INFO] frobbed toml for n2kia4/bkm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/n2kia4/bkm/Cargo.toml [INFO] crate n2kia4/bkm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting n2kia4/bkm against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/n2kia4/bkm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 909c56639566710c226d8a7b06b84c8ea8332e57a5b3b8b0348f26a3db3572b0 [INFO] running `"docker" "start" "-a" "909c56639566710c226d8a7b06b84c8ea8332e57a5b3b8b0348f26a3db3572b0"` [INFO] [stderr] Compiling unicase v2.1.0 [INFO] [stderr] Checking libsqlite3-sys v0.9.3 [INFO] [stderr] Checking serde_json v1.0.30 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Checking rusqlite v0.14.0 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking mime v0.3.9 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking hyper v0.12.10 [INFO] [stderr] Checking hyper-tls v0.3.0 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking bkm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | let db = DB { conn: conn }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | let db = DB { conn: conn}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:22:23 [INFO] [stderr] | [INFO] [stderr] 22 | let db = DB { conn: conn }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:268:23 [INFO] [stderr] | [INFO] [stderr] 268 | let db = DB { conn: conn}; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | title [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | let title = self.conn.query_row( [INFO] [stderr] | _____________________^ [INFO] [stderr] 205 | | query, &[&id], |r| r.get(0)).expect("no match index"); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd/search.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | if bookmarks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bookmarks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:81:39 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn add_bookmark(&self, title: &String, url: &String) -> Result<(), &str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:81:53 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn add_bookmark(&self, title: &String, url: &String) -> Result<(), &str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:148:51 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn update_bookmark(&self, id: i64, title: &String, url: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:148:65 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn update_bookmark(&self, id: i64, title: &String, url: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | for tag in t.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/database.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | title [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/database.rs:204:21 [INFO] [stderr] | [INFO] [stderr] 204 | let title = self.conn.query_row( [INFO] [stderr] | _____________________^ [INFO] [stderr] 205 | | query, &[&id], |r| r.get(0)).expect("no match index"); [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmd/search.rs:25:8 [INFO] [stderr] | [INFO] [stderr] 25 | if bookmarks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bookmarks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:81:39 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn add_bookmark(&self, title: &String, url: &String) -> Result<(), &str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:81:53 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn add_bookmark(&self, title: &String, url: &String) -> Result<(), &str> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:148:51 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn update_bookmark(&self, id: i64, title: &String, url: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/database.rs:148:65 [INFO] [stderr] | [INFO] [stderr] 148 | pub fn update_bookmark(&self, id: i64, title: &String, url: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/utils.rs:25:32 [INFO] [stderr] | [INFO] [stderr] 25 | for tag in t.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.55s [INFO] running `"docker" "inspect" "909c56639566710c226d8a7b06b84c8ea8332e57a5b3b8b0348f26a3db3572b0"` [INFO] running `"docker" "rm" "-f" "909c56639566710c226d8a7b06b84c8ea8332e57a5b3b8b0348f26a3db3572b0"` [INFO] [stdout] 909c56639566710c226d8a7b06b84c8ea8332e57a5b3b8b0348f26a3db3572b0